[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v3 21/25] tools/helper: Cleanup Makefile
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Fri, 22 Jul 2022 14:06:36 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0sockyqUQ192qkRWDk7L0M9+vX96BUdJhjWpGJq0C0o=; b=JNQ3iq8/9V0ngCu/l3ahI7creRe1yNVJjPbJoZp0ros60vjHLuBZEOkRv9DzzHOhnWFyWyrM4k8Mak/pIlvyl+E2jp5nd6MoqyrUKwGxQp1a4dHCWKhrxAT1eLj3FlGo/pdYgAUE6X3JT9pRYrKG9OVxzpwYonVHuLvknuQCvAC7XVUl9+eVKGLPzxf2UT/aMvFmvzlO5n7nlnvqlQCPghujQWN2V8PVxMsi85Y/8C2sjmsDVkCgYlA/xGNeeknhe59rddfRi7y5JAUHR65KfRFJV7m2xxTVL4cdUm5axlt9ekXAR6RUNwl0Xapd7CmoczGLBiQ9WFMVjsgd4iIlQw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0sockyqUQ192qkRWDk7L0M9+vX96BUdJhjWpGJq0C0o=; b=MUJdcJ9cI9TGglQEWbzb4FQbfm9oaRMA6YWpsp1NTphytMa2p7o/TMe/fjDhmRzZThpvpO1lmdFeAU1U04MfyUeQBrRoFX/4f+cutDzgxvWYbd7WyiDFpWXjBmhFPd8V2YgrbdT/HxI2LQ8ID/Mlp1+gb9l3xgA+6EsFHql1VnTwGTxul8pxtb/xAdEw/gImt1fGV8iG2JeNiKSl80KxlicEotUhfHOFm3v0/Y8dxj6OH1MgHZBppDXrpV+1Hhqp8x+rT2CeOQX5+zjfOCy3k8JQiTpt7NLzQ9FL69MsAOpJEAJJVQxoaxBnB9v6oMOPv0Dbnx3KUwa7kM16zDzUsw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=PMooFyZHk/kUT6oz5QMOFIHsfZCONyMIsmFUw8LAls1JM+VzWP52fNP+gvyzHlYn5XJ/XPx6RGp5tkRm+uGEbdlvwdZj+WQmFp/jIYppb6+27g9vuvUlPiD2IwSy8sSXg3JcXQr7U5KPqu4Ejxpy76yFTKYhVSJTSadU0FqFRS3RwKCA/j7WfTMkxw/Jup7b2/FMHB9n0/OZorrfwbsej7uMq2pl/+ZbSI56a42BWJc7HbFMYpFw1gk7t/jNcdy5w9+Q4E13B9I07aYcDpYlojNcuFtF1tRMQvx8xvxnnqtm5LLJwHdi4NXJZaFAdroWt5d2MfYg61QgU2F9TxpSIw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cfeA2vGikfOi0Nzil+7L4nQ9JSiZ+AyKY4iTGHyh54UC0qzAUp51HWNP9BM+1k2sr50pR7yX34YYUUDoeYAyIRmhrJ61aolOaoRZOSVrjRGbzNwsAMGtP0RBSgf4EgjnQdir3kW2RZU3q5JxBxcUq0gBw5EVBxI5mlZz4J/hn8qBJdAHkGl8jnkEFR+mYWOU+uf3Tn+GZzxNbr9nijg/zwKWZuAW6LIqlRhPmm/gPcRBjOoArcz4brzmvGf/lTQ2L4OWa07xOXH7clwkHsPINjAK7QiIdQsd/fZ+GbTcC/0dQcRLt0PtYwiGHanPxUGZ7fl3sIowHfMrrnIbeJb3Lw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 22 Jul 2022 14:06:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYh+SpG67mKDjnhUizMZbh76UNia2KmLeA
- Thread-topic: [XEN PATCH v3 21/25] tools/helper: Cleanup Makefile
> On 24 Jun 2022, at 17:04, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
>
> Use $(TARGETS) to collect targets.
> Collect library to link against in $(LDLIBS).
> Remove extra "-f" flags that is already part of $(RM).
>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> ---
>
> Notes:
> v3:
> - apply changes to the new "init-dom0less" helper.
> - make use of the new macro $(xenlibs-ldlibs,)
>
> tools/helpers/Makefile | 23 +++++++++++++----------
> 1 file changed, 13 insertions(+), 10 deletions(-)
>
> diff --git a/tools/helpers/Makefile b/tools/helpers/Makefile
> index 8d78ab1e90..7c9d671b32 100644
> --- a/tools/helpers/Makefile
> +++ b/tools/helpers/Makefile
> @@ -5,13 +5,13 @@
> XEN_ROOT = $(CURDIR)/../..
> include $(XEN_ROOT)/tools/Rules.mk
>
> -PROGS += xen-init-dom0
> +TARGETS += xen-init-dom0
Can this be TARGETS :=
The rest looks good, so with this addressed
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
I’ve also built and run the tool stack with (up to) this patch on both fvp-base
for arm and
qemu for x86_64 and the binaries are ok.
Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|
