[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Arm32: restore proper name of .dtb section start symbol


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Date: Mon, 25 Jul 2022 10:16:03 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wS9vItpIuIK9OlfLSP7o6peJlfETlLDCYbgMyPx/Gjw=; b=DQDtdyv8SPhxpALRFh4M25H7lZCTmZUmJd+sbq7mDYOy38zQiZU3O78eU0Mr/V+FdkuCSw7/fV5fnupAdkc82/Jvg/z45AqAb7r6tG/x5vK4aJi3Yn1t/DcWMY+X5iBcrlilbKwC+kvPtk1przZ9bYob+UO/PZEvsl7I+rorjlDAkkrPloVdIB52JTJ0qeIfB2xrFF84Fv4vghwKUnkqK7WhFRWCqY8qvsSmDsp9Pz/pPuDCW1JAr/qOxDEMYYnNBc3cQ2cIeGEQNoL/+6TJUDMrKyL+0sgxQRJoOIkyxSVLZRReoN4GM6eZs5n8PGzvZFkjnscMc6FZhaRvATABog==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wS9vItpIuIK9OlfLSP7o6peJlfETlLDCYbgMyPx/Gjw=; b=BXE9hCw7tQY0lmZo7Nu64mpfBy0VrfKwGSrlVE0s1w4eCfDC7Yw7uwZL71E2372UD9qSzaNVMBBSCzx7tDLiG1UpUIRDawn5r2TqW4dtGLnS4XXi2ISGpBALnMQqwTXbKtLXVDv89qbZ+Fh4lVSEkepuaE7JjAHsDxk5KN9Gyu1zMgMeJN9iwdsHM/aVGOXRs35LNB7V8Gohu7hhz85mfzMtNQkwGzYfZq48lwy88NP9BJ1Q0CRC8DAiR4sJrVUvcvWaZPN7kghQCAwZ2zoB3VEfKAj9qIDcE01Pa6EnT2FAtO2O2bx7obCJtVRckBudFtm81S4e/PYnx56JSbRrwg==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=RaS++jbYPKV2Ur80Fzb0Msb7ULa9wexhqBAZKRXYBW2KcR3NQUC8bg9gdhPr2enCRZPlLAAgrkqBKy1xc4EP9PgefTNa0oc2VgjkN6IBZBVCSDDleeEEG+fQDLERijIzK2aXUaaK2VbuPBFyU8+b9j7/o4zw3w+823I/g5T7OIAVUvzfg/ksmak8uVIYssin6W5KQVZMA4ACaDucLb4MEBSd7a34jSCgdDXXfOSRRbeKTL1zZGsVRpDCgX8TbhsYlISxVvs8FfoJUiWuPJNTHpZ/zjthoXyIQhB1hLV5w/ThwV0IYddlPZ9IlIl2ABG6KALYaYUzKngH05tbjMSK5g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kHatFPrOxmQ1qzIXhFfNMsKU+e6GIE+hij5gvX1fNfYs2xI82HQ124oaMLVgm1dacdE1kfBpKzyZgvtddWCKCcfNSviojBjviHx9zY+QvctsX9eTPPJ4RyVsZrr1Y7QmuhREoCaZ+ZfeXZj2ZQXBx+aWPS2uCUNW7kVa1ukUTWufC9suDqfbTVX/Q1SiP1iRYoBI6d3S8vDRKLRxBFo0PMBvHdaAaNFCXG+X531zJ/AFEhsz+QWXFEW+oIdTameW1Sdbk5z8hLvY7uk5oAsUk3eRq6Hc+qz80Pd/Q0SQ8h6Wcz3x6426aOZt1VNRlIqmJc5B9oL9+vWlWCi88tIXOw==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
  • Delivery-date: Mon, 25 Jul 2022 10:16:21 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHYoA8PRqZOjU+nJkmLp8Hrm92H6a2O3vcA
  • Thread-topic: [PATCH] Arm32: restore proper name of .dtb section start symbol

Hi Jan,

> On 25 Jul 2022, at 11:12, Jan Beulich <jbeulich@xxxxxxxx> wrote:
> 
> This addresses a build failure when CONFIG_DTB_FILE evaluates to a non-
> empty string.
> 
> Fixes: d07358f2dccd ("xen/arm32: head.S: Introduce a macro to load the 
> physical address of a symbol")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>

Cheers
Bertrand

> ---
> Of course this really would be a prime candidate for avoiding the
> use of linker-script-defined symbols in the first place, by using
> .startof.(.dtb). If only Clang also supported that ...
> 
> --- a/xen/arch/arm/arm32/head.S
> +++ b/xen/arch/arm/arm32/head.S
> @@ -162,7 +162,7 @@ past_zImage:
> 
>         /* Using the DTB in the .dtb section? */
> .ifnes CONFIG_DTB_FILE,""
> -        load_paddr r8, _stdb
> +        load_paddr r8, _sdtb
> .endif
> 
>         /* Initialize the UART if earlyprintk has been enabled. */




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.