[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] include: correct re-building conditions around hypercall-defs.h
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 25 Jul 2022 14:29:40 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fRqYbcHK+4yb1FARcdcQ9AdkIFK+6TUR+T8EfUhaX64=; b=WLPKKvCR9WMO2SDOj/HFf6v5CK2qfo9pFMcjWtQB1RJgpfAok7B7Yi5agTOiymx+IGrsW9qNgcBPmIUFlbcualbV0Q5NxzMWBN4XXM3MrQHa996bjds3bSQTYSBCQUrA63jtoIB6UzmQdUgR12Pm496o3stfNH6dVaPDa1C1x9Ap9CqnhmgoZmSl1rxpoQTtb4ajWfhz6dTi4w3VncVEKXnaL/Fo6hVxeyx1ROQ0TwtV1NHBBncPyTBQQsXbrrxnrlnx6TQqQp4by2Mk5nyZuZc3TN6O3BZr85AVA/xGIghtSJLJUz0vdUUqemmGbHsrdPO8GPqlkPZDvJXeieSUew==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iBY9k0eLvaX030arjIqz5QhpeXF5+q1k48hwR8zpADFTybxpEjaIedlL98ZE/6LsnufrZzY1+mZIVpa+MpT5b10WYCB7Tfo91jhmR2rQXGsI8HJjbKn3FFy31gBW5oEJmNmkK3FSjwDaERMR9xfo9l3a4/FIMRFVLvNGXAd8479AFR/PG1XSJgNf8Go88VMfCXmbwOtNYOiK36e4jf7Azlje/l3YITW/H+CMVJGUhiMPpvpJkuhgBAykSHG2QTpw6UyrECa1ch7MaFXoXVWLZBvhBTWhsOzqKD/5QXMFiUCe7MhSQE2EZMUlNVbit9IOjytTojXl08soJanpWTmMTQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Mon, 25 Jul 2022 12:29:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25.07.2022 14:24, Anthony PERARD wrote:
> On Mon, Jul 25, 2022 at 02:08:04PM +0200, Jan Beulich wrote:
>> For a .cmd file to be picked up, the respective target needs to be
>> listed in $(targets). This wasn't the case for hypercall-defs.i, leading
>> to permanent re-building even on an entirely unchanged tree (because of
>> the command apparently having changed).
>>
>> Fixes: eca1f00d0227 ("xen: generate hypercall interface related code")
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>
>> --- a/xen/include/Makefile
>> +++ b/xen/include/Makefile
>> @@ -114,7 +114,7 @@ all: $(obj)/xen/hypercall-defs.h
>> $(obj)/xen/hypercall-defs.h: $(obj)/hypercall-defs.i
>> $(srctree)/scripts/gen_hypercall.awk FORCE
>> $(call if_changed,genhyp)
>>
>> -targets += xen/hypercall-defs.h
>> +targets += hypercall-defs.i xen/hypercall-defs.h
>
> Do you want to remove "hypercall-defs.i" from $(clean-files) at the same
> time?
Oh, right - I certainly should.
> In any case,
> Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Thanks.
Jan
|
