[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [IMAGEBUILDER PATCH] uboot-script-gen: allow fit generation with no dom0 kernel



On Wed, 27 Jul 2022, Jason Shuhua Lei wrote:
> Hello,
> > -----Original Message-----
> > From: Smith, Jackson <rsmith@xxxxxxxxxxxxxxxxxxxxx>
> > 
> > > -----Original Message-----
> > > From: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > >
> > > On Mon, 25 Jul 2022, Smith, Jackson wrote:
> > > > Hi Stefano,
> > > >
> > > > My colleague Jason Lei and I would like to submit a patch to 
> > > > imagebuilder.
> > > >
> > > > It seems that generating a .fit with a true dom0less configuration
> > > > fails
> > > because an extraneous comma is included in the its file.
> > > >
> > > > We believe this change resolves the issue.
> > >
> > > Hi Jackson, thanks for your contribution!
> > >
> > > Yes, I see the problem: the code assumes there is a dom0 kernel. If
> > > there is no
> > > dom0 kernel then load_files will be wrongly starting with a ","
> > >
> > > I would be happy to commit your patch. I assume I can add your
> > > Signed-off-by to it, right?
> > 
> > Yes, that is fine. Could you also add Jason, as he worked this out 
> > initially?
> > I've added him to the message so he can give his ok.
> > 
> Yes, I would like to be signed off on the patch as well using this email.

Done, thanks!



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.