[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 2.5 violation
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Thu, 28 Jul 2022 07:57:39 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=518BQPcRIgn/1beATg9RVQUAzXF2X4/va0UYn3KBO/0=; b=SWHqqpO6bUlDCvSl68yzhRmSWf3qAvTkV4rTqozw8A27e2BIWEYy3OBQXJjXsvXTsO5zD4yBqoqILYRcu/WfyzYVfTRqInscfR7jwkR0LllSO0FFQ7moawu4DzRztuIzlnpnDtry+H47zkRy+O8PtvV+tQDMo459NXcF8PwJf3ABZKVqUGLJNuCJfdfopqV8POw7JrKdhebWCg7tj2Qymtnz9R8hk4/xGv3qHuJwwPeaKYdAhlFK2L11jfy5puvgObhwKs1/+0rcHXbaj4rGQQBH9y/Dl47x3jGqt2+jODa4g6o8zvMdMVDo3YxRzBWh4ph5EtNoG/nWbtJWI5sNmg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=518BQPcRIgn/1beATg9RVQUAzXF2X4/va0UYn3KBO/0=; b=RXh8Z38jrGg5mg8JmO0sWYuohTiNIMm43F3W+H4rw7PrboW7SroRLh1lHhl1FuFe/tu7j3XPDknzrNkOMF4CUFUfCHUY/btuoLy5uYoJPr9oB+66di6nflBXnY6WwNXbDx1r906gkZUsKuHOx4tBJl3ejeaIvCzb5zkpC/jjnY1OzpzpZfZDc4q4guKiZV8Hlg4YZJljWsutHf6IqDkAigLkeGgDEJwM21WvBerg7cf1JiEA3x1Hnqp4ZChWlAmLUI0vasx0z01u+1IOx6p5h6MH/WRRKHRSqtSb86lZHbQDt3ZDfKvsWqODpy/xdezcvVpntZakaE+jpSYK1aMU0w==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=iSBo+fpXSzwvfqwXLXTqkWs8g1+q7iojx0wQbXJAmXMS9RZS1iiCfV97HZyR9u83LrCT4jZYmCqencAzXtXgDtvam4pqIIIHwqmrnwJsFZPGswUYxTkpol25VKgngRcnW6oiq1Szc32ytSJ0ZdYs6fDKSkHTsdmvJ8ZjMMRZiG90ROS6ZbdBrqPVVxi1LgXuY4ZIujj+nh+VnY4R7KiT61aOnqOs4Y6QxuVPFDyva6cV6iWwE2lg8TwEaUfmragkwnc5vDTDukugUnHXos174d9rz2+ueUZD6rtYok5Vt585XH4rIyDxJFeyjrxAV9t5wAEszcVjiVJY2bptxCDGDQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ijkgkTJtJwcVeQT5OixMMp277xf8AJAxvZiCE+HHB45pxliGyayeYymJ94kwQ2y3OWiXdiPkAPXiGszNx+JxuBaDVcSLpbwRJbETiBNCiukZuOZkeYXawjiaxLcXknAPGtqz3GU7c0KhCIFVtZJZG97Fu8AbhgwnH0mYpC4cQJK5E6UK9NXMeaE7BxNwHaOUiKC5QvCZsDYuTFq/M0qX17AqpGqJhzBqIWS9d42B4mJqjomSwm0i77zY+4djj8cgvOtvifLugHZ3Ch0JgI3yV8nATYxmAqXZetnQukU6LZSpxIPalSab5gn2acKMV0UdiGRgcH9M2N/T3XKeIGCAWA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 28 Jul 2022 07:57:53 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYoc45O9kZLijXrUyjjlrBuGCX1a2SXJWAgAEPNoA=
- Thread-topic: [PATCH 2/2] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 2.5 violation
Hi Julien,
> On 27 Jul 2022, at 16:46, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Xenia,
>
> On 27/07/2022 16:32, Xenia Ragiadakou wrote:
>> Remove unused macro atomic_xchg().
>> Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
>> ---
>> xen/arch/arm/include/asm/atomic.h | 2 --
>> 1 file changed, 2 deletions(-)
>> diff --git a/xen/arch/arm/include/asm/atomic.h
>> b/xen/arch/arm/include/asm/atomic.h
>> index f5ef744b4b..a2dc125291 100644
>> --- a/xen/arch/arm/include/asm/atomic.h
>> +++ b/xen/arch/arm/include/asm/atomic.h
>> @@ -223,8 +223,6 @@ static inline int atomic_add_unless(atomic_t *v, int a,
>> int u)
>> return __atomic_add_unless(v, a, u);
>> }
>> -#define atomic_xchg(v, new) (xchg(&((v)->counter), new))
>> -
>
> While I agree this is unused today, the wrapper is quite trivial and part of
> the generic API (x86 also provides one). So I am not in favor of removing it
> just to please MISRA.
>
> That said, if Bertrand and Stefano agrees with removing it then you should
> also remove the x86 version to avoid inconsistency.
I think we can keep this and maybe add a comment on top to document a known
violation:
/* TODO: MISRA_VIOLATION 2.5 */
The FUSA SIG is still working on defining how to document those in the code.
I think I suggested one way to do this at some point but the discussion never
finished.
Cheers
Bertrand
>
> Cheers,
>
> --
> Julien Grall
|
