[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation


  • To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 28 Jul 2022 11:26:57 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8Z5sZRmGAOzPBz1xFfN/4/KVaxEVUoXwzI6FaPG+h7w=; b=Cj5xE7AAaMRWeR64Mxpv64Bc2gNFFGtpxYOz8tSZvUhYK+pOaW5mhtxuVLpvtOPmAIqSjqSewePb8xNHh1LLkBD3GCAkhv6InToFHf5qqhxINb9cp+l/y61EmYKFnIRFDA6bEs+s2vKwUwclBWbHocXvRt2l+ih94KkP2aPs4huamFZ5cWDkiTDfbl+tN7ejn/d2JS3G4kbsWMN9N5TL8X/YDzZ3kcJdOXWpdvWz4I/Bqfp9pRKP2Evq40L2TVzD5H5eCBGrDQL+Cuw19Bwje74RK+bshC3Ei+3euimK2M4VL6gngu6T0oQa5omNY0QsK88dH1dop0nPfhuSRhzYXg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FnQ2NK3OOlXkxV8gOfjd621AuVqlbjvmXnJwDzOLos8ebymDtJhC8VJ4c5vvIa3B2XdFanDSnweAZ9GeXfZY0e3nCQX3CsoE6bCwjFmPvjJrb4IQPML1Vpr4QwDNbJX31lLPSPLb0aEcaytuT2Ua4iMF0tbBs6chrtkUQ83Q5/4D+zbsNMnBlI1ifVN3kRBdrzTAE+B3NafE26ZtUIPKntqEc8tnaaxQtAZs/mYDPrjLaYkbJFicY0uJNhX8wbA71ArMpcsGynekLH/FBPl5L+fm/C5l+dqlYATyf3yGEJXl+bi44S6nRoVIqdNQeaAhLX1TDJm+649rRmbEe5+6Rg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 28 Jul 2022 09:27:06 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 28.07.2022 09:57, Xenia Ragiadakou wrote:
> --- a/xen/arch/arm/include/asm/current.h
> +++ b/xen/arch/arm/include/asm/current.h
> @@ -44,8 +44,11 @@ static inline struct cpu_info *get_cpu_info(void)
>  
>  #define guest_cpu_user_regs() (&get_cpu_info()->guest_cpu_user_regs)
>  
> +extern void return_to_new_vcpu32(void);
> +extern void return_to_new_vcpu64(void);

While ultimately it's the Arm maintainers to judge, may I suggest that
these be put in arm/domain.c to limit visibility?

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.