[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] arm/domain: fix comment for arch_set_info_guest
- To: Julien Grall <julien@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Thu, 28 Jul 2022 18:08:40 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rxiOG7xtmKa5GcyJ5nBQ1r+LJwJUQzFcdlUsfmfQhz0=; b=Df9OLGMviaBFjTsscWZ3bRAWeETWL97pd3JvXyi4UViM/yD0nXCfBFrQ9d01VpojRvn18hWgsvKvRsrT6QaiOIXJs0CEbAjIv0YPnYr5MTomOOy4qjRrHx8Czd+YUW2JGsekv5NoQSWkAGpbpdvyZt/NGeHFYzRo4mz0SWGs1/6c4dl5A7dNgWI2GhxbS/hHiGhgAmdW/z02rzMgVwQb/HrWsvtJ4PgtgoroTJR3oOAfmI0f+Isj4thUkp+LxIgI1P++DtaiRHk6+3+I+REJWpAOTeL/+zQ8wIPJBpCQAxyC71OdKPF4LcvDVY6T/hZwnowcexa9lGcPX1IFADbzYQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rxiOG7xtmKa5GcyJ5nBQ1r+LJwJUQzFcdlUsfmfQhz0=; b=f6cXst+GFg9K+Mzceqh0zp+ycUUxlk4j64atrOu1tuR/JlyrbnQxCDoDVbJ4QZ/5GKn8XNF6d/z74RxEgcKE9Uj+k1J5eN5so4zlWXXx2ptCDVx0k0lap1CjZOXtYEh22Sup1vP31hzOysfL9fSMswd3JmEc1q8qryBhD+hs4xFb1nJtwy38KmBZiPhYLv6UjrKTfWXBu58Z/krTBjcyZOTTKDm1DB1PmLrT0tljQrvwRpBgHKmUkKFdNZGW33jEcQr3Z9Dhe+02wYWUp//UTRTvOP4lv7ZMe9sqEYB0UGON7p3qAhotrLZlf0wpr9QMxBtPoGtX8bGYxDQY84hdGA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=lPY8LAxHu7JHaxyrI9qJeSayC20YmusE9ILwbsArsF1cUO051XwHrGxGMpgZrMr74nXvH5WJp15wWkUYjNudlJ1HKJQ/gOliqatzisiiH6D2T4PqqLkwpyhS72AhsgewOlAQPhHZ8idGe92NQKfRy6LP0gPWc8bkbWP+i0dzE8iYUyUptL6LyTFLyUxVyYHoumuU8k6hjEG8ng6237Lnm0tmwixEO12HBNailfDedm09nLwCEP9SbU9DVlxg+8Em4pfbWiYZfTdRVCU5iTSGgexLuLxUvmhgx/fCrXvi2VParX7CGaDPoiwW6JJi9UXcT9exY4bKkUml324dzewkEw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cf8DrvD43c4ac6huKM1lMv9odAoGJEaxZqROxrlpXtBCGBbRtI91fq4uX2CvZYRSKjf8sLAcBNrpwqKEWC6rA+OySlghdZjtfnIG5m1ucee0tVohYOJ3hRvDiGK14n/8oB/pmbLryCxBYe8GP2Z2P3hWI57z8EbB/PsfTwUwAGDwMj77ijszX4mEwSaowrSWoIGL6q344ULHCaWeML1kfAWVcfeGT3vrjtJRsvK82JkDPuin3GCSFGs2Am4fEeUfLsbwkzjGbJGCn+NGvTVcYMCVifCv+qBcSTxvtR93POZBxEA95DD8/VtRvuSuPXpGUOahmQ84iHvW7LGO9qLGNg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen development discussion <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 28 Jul 2022 18:09:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYoDVxqGFUWjtG0EOgt/onXyD48a2UGUWAgAAAcIA=
- Thread-topic: [PATCH] arm/domain: fix comment for arch_set_info_guest
> On 28 Jul 2022, at 19:07, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Luca,
>
> On 25/07/2022 15:46, Luca Fancellu wrote:
>> The function arch_set_info_guest is not reached anymore through
>> VCPUOP_initialise on arm, update the comment.
>> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
>> ---
>> xen/arch/arm/domain.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
>> index 2f8eaab7b56b..6451cd013c1a 100644
>> --- a/xen/arch/arm/domain.c
>> +++ b/xen/arch/arm/domain.c
>> @@ -882,9 +882,9 @@ static int is_guest_pv64_psr(uint64_t psr)
>> #endif
>> /*
>> - * Initialise VCPU state. The context can be supplied by either the
>> - * toolstack (XEN_DOMCTL_setvcpucontext) or the guest
>> - * (VCPUOP_initialise) and therefore must be properly validated.
>> + * Initialise VCPU state. The context can be supplied by the toolstack
>> + * (XEN_DOMCTL_setvcpucontext) and therefore must be properly validated,
>> + * or by PSCI call (PSCI_cpu_on) handled by vpsci module.
>> */
>
> I would prefer if the comment doesn't mention who are the callers. So there
> are no need to modify the comment the next time we add/remove a caller. How
> about something like:
>
> "Initialise vCPU state. The context may be supplied by an external entity, so
> we need to validate it"
Sounds good! I’ll update and push it soon!
>
> Cheers,
>
> --
> Julien Grall
|
