[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation


  • To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 29 Jul 2022 08:26:16 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hBBSuU4xfU+gyIFGQY9nTp5nRAfNW1b24aKWveF/5ys=; b=Zq/jrUWicRIWtHPyaENQNCVwYB7VJRwJBQcvlvgokEDwQZgDepGMFbseD694Uy7guT9pAyqwNgPuGGwPEZrGi+dNRUUZhsaCTJwZfVp3IPIUFPNAdDW6AiSihtkEoH+m+mxOzPA5t162dKZzi2eVf4Viz9QhGb3hL2BpuhAioOQcb+uCMvx1z4bAQIMnQEAc21RJuEphDVnt3rtZTRgrU7de91vJlcFkS4x7mAdHc4nN7nHxN4l3O6lhtjvjcC0JoYYt5pN9Ig/Exz6oWWB7aGPDbtTwDTkxeVA8hSPGzvQeTP1NwMkwET57Gyy+jnBPrrBEG/ttCeb5zuQIORAu/Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bMMiP9mTyYza4c4sbXusG4MT3SnNm8+WuI4JmDj1mNHm6bpeZVVtzMxaLZU+A2qmGLPK7o2d+dX0idEi9+6BgCvxrZKnTFj9Fu8CrMfqsV3xA3pTB6MHyhv3KzpV7UM9u56VDRxzVWWySVckY5xYNSe7VQCaB9X0JcvLqfgc9FYX9nQFbgk35ita0fMbYa993Z4BmwZxgUo5MSEyF0AhOIk2kXfULURB9ENZFZxMrNjzeMTeUQF/ZEg5dVsWIX3i8Av/T5ursfYJPasjtGNVkLaEGwVqVaaZ5cuquklPPSIDrMUqZGkIruRg0De+anDSnoh2fRVpGAFMfrVzQX+pxw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 29 Jul 2022 06:26:23 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 28.07.2022 18:21, Xenia Ragiadakou wrote:
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -63,7 +63,7 @@ static void do_idle(void)
>      rcu_idle_exit(cpu);
>  }
>  
> -void idle_loop(void)
> +static void idle_loop(void)

While you're adding "noreturn" below, shouldn't this one be marked so
as well? Preferably with the addition:
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.