Re: [xen-unstable-smoke bisection] complete build-amd64-libvirt

[Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>]

On 29.07.22 12:08, Julien Grall wrote:


Hello Julien

> (+ Anthony)
>
> Hi,
>
> On 29/07/2022 07:48, Oleksandr Tyshchenko wrote:
>>
>> On 29.07.22 09:22, Jan Beulich wrote:
>>
>> Hello Jan
>>
>>> On 29.07.2022 03:04, osstest service owner wrote:
>>>> branch xen-unstable-smoke
>>>> xenbranch xen-unstable-smoke
>>>> job build-amd64-libvirt
>>>> testid libvirt-build
>>>>
>>>> Tree: libvirt git://xenbits.xen.org/libvirt.git
>>>> Tree: libvirt_keycodemapdb 
>>>> https://urldefense.com/v3/__https://gitlab.com/keycodemap/keycodemapdb.git__;!!GF_29dbcQIUBPA!0s_nyAgds977dw0dGPgFJGkIaBiKiXH3nR11Ni6gGjN5gQmB0DEhKrm5SUX4R0WhK8YkQemR6RVhiojpzij9yLM$
>>>>  
>>>> [gitlab[.]com]
>>>> Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
>>>> Tree: qemuu git://xenbits.xen.org/qemu-xen.git
>>>> Tree: xen git://xenbits.xen.org/xen.git
>>>>
>>>> *** Found and reproduced problem changeset ***
>>>>
>>>>     Bug is in tree:  xen git://xenbits.xen.org/xen.git
>>>>     Bug introduced: 66dd1c62b2a3c707bd5c55750d10a8223fbd577f
>>>>     Bug not present: f732240fd3bac25116151db5ddeb7203b62e85ce
>>>>     Last fail repro: 
>>>> https://urldefense.com/v3/__http://logs.test-lab.xenproject.org/osstest/logs/171909/__;!!GF_29dbcQIUBPA!0s_nyAgds977dw0dGPgFJGkIaBiKiXH3nR11Ni6gGjN5gQmB0DEhKrm5SUX4R0WhK8YkQemR6RVhiojpmYABJkc$
>>>>  
>>>> [logs[.]test-lab[.]xenproject[.]org]
>>>>
>>>>
>>>>     commit 66dd1c62b2a3c707bd5c55750d10a8223fbd577f
>>>>     Author: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
>>>>     Date:   Fri Jul 15 22:20:24 2022 +0300
>>>>             libxl: Add support for Virtio disk configuration
>>> Just in case you didn't notice it: Something's wrong here. I didn't 
>>> look
>>> at the details at all. Please advise whether a fix will soon arrive or
>>> whether we should revert for the time being.
>>
>> Sorry for the breakage. At the moment I have no idea what is wrong here,
>
> From the build log:
>
> ../../src/libxl/xen_xl.c: In function 'xenParseXLDisk':
> ../../src/libxl/xen_xl.c:779:17: error: enumeration value 
> 'LIBXL_DISK_BACKEND_STANDALONE' not handled in switch 
> [-Werror=switch-enum]
>                  switch (libxldisk->backend) {
>                  ^~~~~~
>
> The switch contains a default branch [1], so I am a bit puzzled why 
> GCC is not happy here.

Libvirt seems to compiled with -Wswitch-enum

And https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html says the 
following:

"-Wswitch-enum

Warn whenever a switch statement has an index of enumerated type and 
lacks a case for one or more of the named codes of that enumeration. 
case labels outside the enumeration range also provoke warnings when 
this option is used. The only difference between -Wswitch and this 
option is that this option gives a warning about an omitted enumeration 
code even if there is a default label."


[snip]

-- 
Regards,

Oleksandr Tyshchenko