[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 7/7] tools/ocaml/libs/eventchn: do not leak event channels and OCaml 5.0 compat
- To: Edwin Torok <edvin.torok@xxxxxxxxxx>
- From: Christian Lindig <christian.lindig@xxxxxxxxxx>
- Date: Mon, 1 Aug 2022 08:20:29 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yFuibLHE/ZBSyhSmXInM/auRWgawUhMAHJytLYRD1DI=; b=jIu9elPyAC86F7iQ9LO4nHg5oTZTyziFeSeFyHaI9ttWXjmtOtnsoF3Sw/ilpci6nwad264EOrJPtx8aXgqeCrSBgJFZYd8BU7dCoFFg5krX2dl5YDaUDmuIk00aJ3KJpQW/FWDHFiOGoy9WmViVjGJU1cz3zOUQyltpCIGT2LjP4FrMf5QtNa53UGVZQFNzQX8wC5pqFukoem+daODuZ4jWTHUh1oWw8RZphX3XoMa2PoxfxSIuSj/erQuZC1r2MOs9O+vvBHtae/4fIa/MiC5MELTyOcBtNb//NIoo8ypUmVYTo6m88nVOzg5iux5q2m+8aU9qJhoqDeEpSnOVVw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Phih/HBu5RfO5/qN0aKM7VsM93PlpocJwfNyzTZd4kP1VkfpfPhjJX748hrubEBgloBW4XRkE5e7nDCyYnODM05/QkdV6EUgvWEFRW7TW/w/0RcnSAgxBu/mI6kTpmAzq34kkS5NqsOvG4VmyBI9eoVLHmKniEOywkf6ZsJLQXuE5MC2y19rXxBbdGPYZbOhxd9cJxjX1MeGw5tYEqvW6EzKcj8BJ0u4AsfDarswDwi8te7ATx4Ub2ag82jl8sDb7MY59WXaMrnXaZIC4sMNjMP1yNcS2En3lyjGka2c0Umm2MkisNpPPAdFETVpjcLa7C0xnVAHsDCd3ttMFl3RTw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
- Delivery-date: Mon, 01 Aug 2022 08:20:39 +0000
- Ironport-data: A9a23:FP1UzamRhoeH4P8YHEgfL+Lo5mJPLROM6qJN2KgaY0/mBrAAGkV4Lpauux3sYxRXZD5wrreUNv97ip7up9dUYzqvePD74t4E+aSJagUKZylAgRz/sVfJUOR/8Hb3+WnMjEB6DHPpfMnycs3aMPvn5rCiDySGnVpIErlIrn4RLkaG+8+whVwTlASq1MnmyyzYJBdBULcZSaEm+m5WgOdLN99w+gFyDSByRlZttiyDE5ly80HmZFTYm8rPycZMXeaFv2CyKd5ODTmjyvMIf2VHW97uBsZhkWpmUhpj1Vi92fLwZjtwDXftmQoUrI5GhOIEolcNK1i1U9+mpiiyfiZuWboWl/tTadktlKAvIyEdSRhp2uxG60bzxqL2/EgM849UJkJ/ZwmCVWG8z3CFsK/I4Ibuf4jJjH0LEQNWlYu5HRfUDMVPzztuuwu9FiQDFiUcv8beNy6/OYb7dD3gL5me4i6ZAR0yoS53csJgqlNT/nxF/cUGoSh4taJN0hBtEUCdE380iiD+kIvSLHvwtUA2bGEDGMn5QzYGPkO/KApNwuCws92x8MayvcRZ6mG21QBYxpYPNckE7ake9hXej8cTytR/5KLIUP03Q9pCOSTITOQZQci4VDT1mO+OMxPb2akMY30u7Pcn2XcFc9RUeoj6131k3z660F11x2+++68bhuaKgGXczQENgIymYo/IUXcEtq1ihzvxxbchLfFtN3N8CjTxjrY31V7+CGirMq6K5CN+HVOjGJmWson8J3h9CfcULQDGskhqDNpbr+Hwrw/IZvGJSIfXj6h0PNf0B8H9IcXFHayd4Bzf7DDRzreEoYiOVZRGl5pHvv8UPfxivwvAOxZ9LM2pFbhGqXZHlrxir7+L/4W7h8NQ2UsPggF1sySBvS36M3xXpJVlgEPZjcxXzM7mppjDb+ziU8wV7LuiPwH2PMLhDxnKB9a/TMMLtKXzrmRV/CWHpPCfsWQwJOxKl7NwCEpS2K0ArQ1rarEG8sDK1C2mVhIMllj4UK2n07D1cmLmXfIARCQh/m+yrLGEA4a7fXI8aRZZYRPzkAXFgE4IMGaa0N4tV9oYI244GgQ0noeAkBkRImVtPIB6Q0liikAkIb+QlLWDuext2N+iOEbg36PGw3bjRYGQNgZ2C+aHaHAXes/gPmzXuyy8FH4UBjDFmjuroLa7wHPDBA4ScnkClUnjNFGVgtAPOwzV4Ve06hZkEAnwsPDjCe36hMWF0XUXUNTMR0wBe29yA1pmkWGR5pazx7j6wt0d//0W9jVnxzflRbFGpIvUXVDUV7YW7KeuLZtZIQ+x4PeetrYlt6upMSMFPC6BR1cAEMM0Xs2LELY6eAyByb9SL8UW+Fm3wt4QlBiYhL6yQmHzN6DdbbyY/jrpmJk9L8mcShQBit4zxL8qwte4ODql85fGD97vT2r18vEZRz3XlaaV+yC/gVtIjrM7Xn6CW1YQ8xMHsTPVpHPZXd5i8zuXoCp5amE5IzkZcm7Hhvm3NL91LiuFAXMu2Q5Yca70nQxHwKCLR5NXjPpH+i5lVzMAt6h7FbC12Ph6I2VCQYa19aH0bKZfcz26RRanW8rsAlS2pm9q5LmLEcqeb8xrxXu4iQ+juqkJHMbi6gpbYHajO+1ViVHCKG03YiEpmXUXj/+TcvkP5D0xFuWQH4UfTwrs8Qsx4QYrFLpsnbuC5/g4PZbal5ckJdfnRJxUPNnFci1qXF4bHTYAWNxr2KYrMwmFbMTG9z9+Rlw83TWXwTU6tCuvELPGKquqjO3KTqijJUe9KjXOMNXj03maj3nnreDz0cMkpZLfZRGyH4dm3GeQh7dvDJ19/UCx5Re6a4u9GNe1I18uC6x3aqnwesWsi6M/N1OWhB9JJwLVy8/0tRDEVYWr6qavDadNb6I5RrWxMtpG+vnxylZVeV4f5V891I+jWs/Iha49G+dgYEoevQSwAlOa4COydSd0UtfhwWlYGeHYLtduo80jEfY710GpDBDt7kRaStc12l6GdmwqN/xy2wZaqSmYQ6CTBjqKRRVxblGddYXVpba4eZNKqLKoQHMnKYWJUn6vwSQ3GWgKL0JXrOx5tgV+vXqZbBx7tvdzI32ct9bmR/wse8NxrEwcBcn853W9q1jV5eMYfGOloE3Y1Vk4f9JVPY2aQVfNrRy7wCImBQZjtQqFZRkgRU76jJcaKijOx6/IJxvxtqZeLaNwY7X5ibj3pnjM3rKuZw+IUM91XWkL1QakIrMakfxOKthh37Odv0UGxnjB13k1TaA21Tzy3bWfHrhh/tTkHDccg84RGQdsgOOloFTcczBOrKmqKUNjWcBnin6L2mAcbkgFks9gRsP1391U8H1omvMZsQhyvTVfhTXR0Mk=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYo3Q0zonO5SaiM0uTICRa4leQlK2ZuDaA
- Thread-topic: [PATCH v1 7/7] tools/ocaml/libs/eventchn: do not leak event channels and OCaml 5.0 compat
Add
a finalizer on the event channel value, so that it calls
`xenevtchn_close`
when the value would be GCed.
In
practice oxenstored seems to be the only user of this,
and
it creates a single global event channel only,
but
freeing this could still be useful when run with OCAMLRUNPARAM=c
The
code was previously casting a C pointer to an OCaml value,
which
should be avoided: OCaml 5.0 won't support it.
(all
"naked" C pointers must be wrapped inside an OCaml value,
either
an Abstract tag, or Nativeint, see the manual
|
|
