Re: [PATCH v1 0/7] tools/ocaml code and build cleanups

[Christian Lindig <christian.lindig@xxxxxxxxxx>]

On 29 Jul 2022, at 18:53, Edwin Török <edvin.torok@xxxxxxxxxx> wrote:

Various OCaml code cleanups to make building and working on Oxenstored easier,
including compatibility with newer language versions.
This does not yet change the minimum version of OCaml.

A version of this series in a git repository is publicly available at:
https://nam04.safelinks.protection.outlook.com/?url="">
https://nam04.safelinks.protection.outlook.com/?url="">

Edwin Török (7):
tools/ocaml/Makefile: do not run ocamldep during make clean
tools/ocaml/*/Makefile: generate paths.ml from configure
tools/ocaml/*/dune: dune based build system
tools/ocaml: Makefile to drive dune
tools/ocaml: fix compiler warnings
tools/ocaml/libs/xb: hide type of Xb.t
tools/ocaml/libs/eventchn: do not leak event channels and OCaml 5.0
compat

Makefile | 5 ++
tools/.gitignore | 7 ++
tools/configure | 4 +-
tools/configure.ac | 2 +
tools/dune | 5 ++
tools/dune-project | 1 +
tools/ocaml/Makefile.dune | 88 +++++++++++++++++++
tools/ocaml/Makefile.rules | 2 +
tools/ocaml/dune-project | 27 ++++++
tools/ocaml/dune-workspace.dev.in | 2 +
tools/ocaml/dune-workspace.in | 18 ++++
tools/ocaml/libs/eventchn/dune | 11 +++
tools/ocaml/libs/eventchn/xeneventchn_stubs.c | 29 +++++-
tools/ocaml/libs/mmap/dune | 9 ++
tools/ocaml/libs/xb/dune | 10 +++
tools/ocaml/libs/xb/xb.ml | 3 +
tools/ocaml/libs/xb/xb.mli | 9 +-
tools/ocaml/libs/xc/dune | 16 ++++
tools/ocaml/libs/xs/Makefile | 5 --
tools/ocaml/libs/xs/dune | 15 ++++
tools/ocaml/libs/xs/paths.ml.in | 1 +
tools/ocaml/xenstored/Makefile | 5 --
tools/ocaml/xenstored/connection.ml | 10 +--
tools/ocaml/xenstored/dune | 51 +++++++++++
tools/ocaml/xenstored/paths.ml.in | 4 +
tools/ocaml/xenstored/process.ml | 5 +-
26 files changed, 315 insertions(+), 29 deletions(-)
create mode 100644 tools/.gitignore
create mode 100644 tools/dune
create mode 100644 tools/dune-project
create mode 100644 tools/ocaml/Makefile.dune
create mode 100644 tools/ocaml/dune-project
create mode 100644 tools/ocaml/dune-workspace.dev.in
create mode 100644 tools/ocaml/dune-workspace.in
create mode 100644 tools/ocaml/libs/eventchn/dune
create mode 100644 tools/ocaml/libs/mmap/dune
create mode 100644 tools/ocaml/libs/xb/dune
create mode 100644 tools/ocaml/libs/xc/dune
create mode 100644 tools/ocaml/libs/xs/dune
create mode 100644 tools/ocaml/libs/xs/paths.ml.in
create mode 100644 tools/ocaml/xenstored/dune
create mode 100644 tools/ocaml/xenstored/paths.ml.in

Acked-by: Christian Lindig <christian.lindig@xxxxxxxxxx>