[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm64: efibind: fix MISRA C 2012 Directive 4.10 violation
- To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 1 Aug 2022 13:02:15 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IFIA8bg01IggligMdL9rmyK4dzg2+r+xoKYewqwRoVo=; b=LR8qDhd1fGb8rHE856sOZ7pK1TysQUGR1fAJ8rAlJhHJaeh5MoJfWOF+v65tg4fW28Wj8G+iOgFpqtgcr0zXBfUcgp/Rfl55AHXuuUgV59qZao2vXeDiNtTUi9GXEp8h7+QjMVnUxOwxryKb55AVj1klQEC6SNsXO9PMbxy/J1vHevVsDltv4YTA0AuNyuerkndc2fFh99GFMpSDsPC3VGB18tBC7vXEm4NYzR6TPwcewaK0w58PQEHJNLbTJ/eofp4Ks0u4UtNyzoT5HftUBcauxP16ta0DjXcc+EVZXY/gRPV1ppyU8LUSW/ojIcO38dCz/8Iao/eKAYRwfpSHbg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iJUZRwZVPAeTgiiE2hVj0/aGGzxPw3iurSCasjx63s920b4PbZpCtbIR5E38qaNNkANxL0MLub55lMzs0wagSYhpX3oDml4pAUXN5k6ASIrYUvyHynMLLDa/MsG7fJSxTHDgS0/Zczt/jH2+tlz3bDpp5eGohPcYA09OYS/oGk6ZHfbBf78+gjCIz1P6u5xrymnkHEggXBN185pNBh66yZr81/imwCig6hmA/rtc46oDW6o8jxrGqr/HBNQXYpbETUrTzWCXIUWln9NZ6V/VXQtKEFmAg/nV4sVBQHqTZrehxrTtXarqGQWxT4JD5BrlOIK03bdiJcLM/g4sJI6I/Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 01 Aug 2022 11:02:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01.08.2022 12:43, Xenia Ragiadakou wrote:
> Prevent header file from being included more than once by adding ifndef guard.
If such a change is to be made, please also adjust the x86-64 instance of
the header.
However, these headers are inherited from the gnu-efi package, and hence
should see as little customization as possible (you may have noticed
that we didn't even correct the bogus "Module Name:" value in the x86-64
header). While for this particular change I'm not outright opposed, such
an exception to the usual handling would want recording in the
description. Actually - at least the x86-64 header has meanwhile gained
a guard in gnu-efi, so that one likely will want importing instead of
adding a custom one. (I'm looking only at 3.0.14, which I have readily
available - there may be a guard even for aarch64 in an up-to-date
version, so please double check.)
Jan
|
