[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v3 06/25] tools/fuzz/x86_instruction_emulator: rework makefile


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Wed, 3 Aug 2022 11:15:59 +0100
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 03 Aug 2022 10:16:21 +0000
  • Ironport-data: A9a23:wxb3Bq05GRaQMgrHO/bDix16xZWOz3FdZch4Cdl9DyJ0cfeTg2ku/ST6PRR+1leKQTQnb2+unZjdzyympCmA/QC4l6PdVM3r+rdfYeDmwFIi4XRw0zCbFUJ3UWnZMYFZSOAdAiEtvvxegxE9YjT75l0vp0zZNZ2nV00ktU5XsxTuEYGObTdMdz3vyieI0kz8mi8FEJwO/paeswykx4W7fG0p6S66iKwemWFTiEuHMmbkTsIpt+/wYw31d7Yr0sEWSv5OLU+IHRKbRF/3WPyQzHRBXUuqncgSj8ISyO9vYaEYZDKxAcIjblOhzXjhgPGIeFyjRRcBolaoVLT63B3zhxwVMd7PJ8hMOZf1QcB8FSw7oKGshcNFi44mAvCGMfv8Oc7xbQa3xre/Sa5OMg8IHKVDTj0TtkfMUKEzfLoeofxzJbY2bEkEvmQiidUlQpIcExypzCzvRT6CejthcYQG+/MgAp8NN5xondD1mz1brOVamcoaH89Md8X9ahYQ12VUT3M3g9MLPbwrPVbci8Vbf0TFwWnubS4/04zjWIACIDp3kn8Yz68tmlEZba1hlv+vq97dYnh9OzgfYpmDqkofJjExZY0Pbz+gSNk7IwrORv3aJcEzTplscpAlbBwrTobqaigWn3GtmAuUulHaBEKoVL/+yRNM+qgPUhEbxAOoEbpcsn0g/9/tL4oElEObDs0wijCZWve1RQTo5+T6tQKIV8iLaT9VK+UJPDgYXi6CX/w2X26CAInA1nAuN6NIDaeQNT1d0Xj8QcUGNWgIyXMWkRaVi5ZOqCr7jmqaALHZNroRCbRT/IO3OM+XlA1uY3MQaS/c6S/wGfXdwKqGXNH/3EvZGf0WPhaXERT1xerfAF+uMWOjKZnrrCoGbu677wmMcQvPGznsofzivWGPQWAa3DnI7FQhon4qScSVgKcDWEUJzVmXtmZ9V0L0RQ14qDW5g1Slx7VITVpbylsuaOSaZmaKOh46pg8Gf11cWSr9qOcxk8lJ1u0y8rKrHZZql+FC/GEJ41FdFYhMo8MPHPD4/PyA9dCPUZL4cJEWRYIrMFXdWSRyMWpvgBYD0zgSUCsoTzd8ZmXnc0OOVSVT7UbXguHpi+tYaa2xeU31y+VU6re08SrH8XmkD2xFPqdHcj+K4sknOvvZ5/DpoEGBf2UwEDG5p0efgqWN7AjV/TsIUEQ01wm+u+CBNHFEbiiQRH7QTlmTwvysOYDNsG4NsCcjBoKMvqTpcbdC9Y/cLpqbHb1BwNflDa76hG1oBL8KKWkNIcbRvCsR5LaPGzH5qD/rJ7RjYbR4TtFmzwcfyk7zs08PYrB9P+4mWgtwZ3c591f/kNwnhvFInBgVnB5da/LSsEmgU1pWaMsYnqbBLzdZDBes9X5oJHTxaxY60ejWEzCmmAbpX3R0l5Y7d22iO2o5XutDIgPStBteesHuJEVWUCUo2GFs6ztF6R6MJGgS91T0/qYXRssmoBkY88IcIUHBmHUoHHnl84N8r022plV0sVpNabwTZmoQh4HduWm9J9Yf0paXr5ES0vQsItDSrvQ6OkEwBcIvTuaJh2fgrFSI67xngQKCZ8fS9vj12VGcNLNYC0aB4xT4+b2xJ0PqVoZw3n/o1inIn+oxAQAdTul1536ZJHNXSSFXI8X4t9xHlmLiXg9+34tJlYs8sNTu3N5S3tgB1poygLCmNJECcr6T4rSnlxZ/h9gzUjXnCA4N9+8Q0WF09PM/l9QuYT11e+XWvzoEmi5wT/NdNY1KCLDJC94PGzk75W1smCWWX0mxb3Oz230c24MVVBffNkZ9PkMe6ODTAcr0+MHzWsFNOLBCBr4dQpcndu6ICljGBmISWnvIjDEPlyrvLzlvJLvtt6TU2msMLYc5HttVFGVzudhW/t2P6zKsBeMb/nQ3oEz0azq0Ycwej9nOxkX44LE44viRiameoDIRLiwBgHSIU2GfsJsd1lHMq8wjLiAfZ5t3ovrlBLQgVHKYpueFoZBC7yZZXSBEBMn+zVycd07mBy7cvTtlykT+m5Z5N9LucD2OKS9Zp0ZgDE29uSrgOteHIh+4YVT88emV+LLVg7ul0OahVVaHY/EnuAk9+NsU7tMatO6nPFUYznSmpHa47Y9/lEqRdNOI/1HKal9NdkebVIJpY/VwTUrMoiNdmdsXiX7hKrzUWmJZ8D0h/4muTn4OLWGh/bBDsckyZSlMf6RNabtHCGwQZtHi6vTN7QO0CW98Icm4XHHnoE2MXv6oTKUSXe6pURsQ/Fh/hL/SOQEEXJgKjoVVw8Aw6+Vvt9P19ygrzODZG15wW4Xs+2PakX2jp+3an2t+kscYbDUYkXYrQIyQOCv+vQrXRrBwM+sUmoKehjuCDUw8e0yYUpgYDiiqUiMcth/+HrlGtm0g6+fhl6kqKRR0VO3sT6qL4PbrpkFO2H9hTig0VXKOiN9YmU/LAqFo+qlYKj+xn0kvNIfpp7xAiha7CRpovKcQCfQJWxwtSRrNpqnkXFY6HoVIWCMiasYgkz/PMF0VXbD9EvC2XIaYidO2yVLcql5FXwgyhBPZJiFNlVqzO8quZ4BJh/unO8Ohfn/4MO7l+FAH+Glk/YtFIIPPpYTIuUyN10bBgvUwXhe9VkoYEjDDer0R2IUTg0MSvFBl7ke9KoALHAnDZOuJF8yMw6AM9AeYRToqxw+1pKSVgbdJiTgXiK0r6hr6uE1xWmM1mT5bOlsgtF6qGjyuD9FvJjyHDU2/Dyo/uoJWdy9ISyjjL/M5FAtcuKAsA5qYkDZ1oeMZPcYkvbv4X1J6BA==
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Wed, Aug 03, 2022 at 07:56:34AM +0200, Jan Beulich wrote:
> On 02.08.2022 19:09, Anthony PERARD wrote:
> > On Mon, Jul 11, 2022 at 04:08:55PM +0200, Jan Beulich wrote:
> >> Can you confirm things to work when
> >> building locally in just this subdir, e.g. via
> >>
> >> make -sC .../tools/fuzz/x86_instruction_emulator 
> >> CC=/build/afl/2.52b-base/afl-gcc
> >>
> >> ?
> > 
> > Yes, that still works. But I'm not sure why you would ask since the
> > tools/ build system works this way, execution of make in a subdir
> > doesn't depends on the execution from the parent dir (it doesn't
> > depends on anything in the envvar).
> 
> Oh, I wasn't even aware of this as a general feature in tools/. Is
> this going to survive your rework to use non-recursive makefiles?

Yes. Executing `make` in any subdir will still works. It should be even
better than the current situation, even in a fresh clone, we could
simply run `./configure && make -C subdir` and make will make everything
needed, that is probably the "include/" dir and the "libs/" if they are
needed by anything in that subdir.

At the moment, one can run ./configure then `make -C tools/include` and
`make -C tools/libs` and probably run make in most subdir without having
to wait for a long run of `make build-tools`.

Cheers,

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.