[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 5/7] tools/ocaml: fix compiler warnings
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Edwin Torok <edvin.torok@xxxxxxxxxx>
- From: Christian Lindig <christian.lindig@xxxxxxxxxx>
- Date: Wed, 3 Aug 2022 10:47:36 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=veWF1bdpfh5dSJptFsfMk+nY7W/saD8jKwHmD0ZAIig=; b=BFjuK+yrN0WlnEK7xhBpVDLXIBG9DtjZ85s+XQo0DCpY5nwJGLq9F5S7hUuS1GR51cmy0tDdMzLbxXbgXbjxml3ufZ52mIvbJlq9r+Md7k3g36Iq27saa3pyxAKDDFDNC7hmdcGer1zhx9h/x9RYWVArt9d22sl8tyJ0K3iHZqG05eA8JoaxdWM3oIBZNcNxIasGgNp5MakmgbAp+Y0XxwE12fdHg7wNAyBDghbgRtiBv9eEMEVkB7WnPzMfuSZQILbl6dVdfVf+CNdQtswmfR/O/6TifzDfDMt2eWUAjLZT0XUn76XZTIbSjoKdy+Boxlsjoj/+NKtQRnvEab5/Pg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OvsqcX/gqDlHOMAZdwqpTUzzuCaM3BZym1ij+A9nSqDeirbgd529O7klLR+pNTRPAU822kxP9rDj/TgoKIGAN7Fg/wcurafnoDYL3ue/VuW0NOHagVpnVLhJXAzEEDpaCSBh4DKFsFnrhav9ujIkau5plamwYVQfBcriKhhq8Hhbqe8SUuBB48Su8VndxpSDNvZlOnunAX6RxOzKaSjbE/Cvq7fSkWB60IPyDNGm9uPyRlhTF/HeWzXS8RQv08L8Nu3vUz2lYJOOQimaedWZ+E/leDcHJGKmLeDZ9C/zC10GJPlcZ8gYv1K5EtaIZ6EyLC/V5vWgWs4q37VdVQQJfg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
- Delivery-date: Wed, 03 Aug 2022 10:47:49 +0000
- Ironport-data: A9a23:HNJmLakuPh4x2e8aZO3pshLo5gyYJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xJJWjuBa6mNNjfweN90YIW18kIAsZOAn4JrHARr+3w3RiMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV ena+qUzA3f4nW8vWo4ow/jb8kk37Kyp4GlwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2kyNr0E9714PF1o+ PIoMDs9ZRu+tuCPlefTpulE3qzPLeHNFaZG4zRL6micCvwrB5feX6/N+NlUmi8qgdxDFurfY MxfbidzaBPHYFtEPVJ/5JAWxb/0wCWgNWAG7gvK+8Lb4ECKpOB1+LPtKtvOZt2DQ4NRn0CUp 23u9GXlGBAKcteYzFJp91rz2beUwHmgAOr+EpWa/blA0V6R51YBVjoPblSAv+O7oGexDoc3x 0s8v3BGQbIJ3FymSJzxUgO1pFaAvwUAQJxAHusi8gaPx6HIpQGDCQAsQjdfZfQ8ucQxRDhs0 UWG9/v2ARR/vbvTTmiSnop4thu3MCkRaGQFPCkNSFJc58G5+d5tyBXSUtxkDai5yMXvHi39y CyLqy54gKgPickM1OOw+lWvby+Qm6UlhzUdvm3/Nl9JJCsgDGJ5T+REMWTm0Ms=
- Ironport-hdrordr: A9a23:X1sM5K/XKi0oxWLEG6Fuk+Fudb1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQodcdDpAtjifZquz+8O3WBxB8bpYOCCggeVxe5ZnOzfKlHbehEWs9QtrZ uIEJIOReEYb2IK6/oSiTPQe7lP/DDEytHQuQ609QYOcegeUdAF0+4PMHf/LqQZfml7LKt8MK DZyttMpjKmd3hSRN+8HGM5U+/KoMCOvI76YDYdbiRXpzWmvHeN0vrXAhKY1hARX3dk2rE561 XIlAT/++GKr+y78BnBzGXehq4m1ucJi+EzRfBkuPJlaQkEuTzYJriJnIfy+QzdldvfqGrCVu O85yvIcf4DrE85NVvF3CcFkzOQrArGrUWShWNwyEGT3/DRVXY0DdFMipledQac4008vMtk2K YOxG6BsYFLZCmw1RgUd7DzJm5Xf2eP0A0feNQo/gpieJpbbKUUoZ0U/UtTHptFFCXm6Jo/GO 0rCM3H/v5ZfV6Tcnic5wBUsZeRd2V2Gg3DTlkJu8ST3TQTlHdlz1EAzMhamnsb7poyR5RN+u yBOKV1k7NFSNMQcMtGda88aNryDnaITQPHMWqUL1iiHKYbO2jVo5qy+7kx7PHCQu198HLzou W1bLp1jx9DR6u1M7z+4HRiyGG/fEytGTLw18pZ+591/rXhWbuDC1zwdGwT
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYo3Q92aLfQ5z7jEOjsQTVnpAyA62dA6CAgAACWYA=
- Thread-topic: [PATCH v1 5/7] tools/ocaml: fix compiler warnings
There
are no side effects here. Can't the line simply be deleted?
Yes. The compiler tells us about unused bindings like these and this is the easy way to acknowledge this without removing the code but it could be removed as well.
— C
|
|
