[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 1/7] tools/ocaml/Makefile: do not run ocamldep during make clean
- To: Edwin Torok <edvin.torok@xxxxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Wed, 3 Aug 2022 11:57:10 +0100
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 03 Aug 2022 10:57:33 +0000
- Ironport-data: A9a23:OPzZvarlyj6OqqIFjbYF7TqsVu1eBmJgZRIvgKrLsJaIsI4StFCzt garIBnXaP/YNjajLd0iaN7koExTsJHRy4RkS1NpryxgFH8QoJuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt MiaT/f3YTdJ4BYpdDNPg06/gEk35q6q6GtD5gZWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqUg+blbLm1i/ 8caFwkfVi26vOmv0piCH7wEasQLdKEHPasas3BkizrYEewnUdbIRKCiCd1whWlqwJoURLCHO pRfOWEHgBfoOnWjPn8eDo4+m+G5wGHyaTRCpHqepLYt4niVxwt0uFToGIWLJ4bTHpoO9qqej mLj/zqnGC5KD+yklDy63FiilMKTnwquDer+E5Xnr6U30TV/3Fc7Fxk+RVa95/6jhSaWS99Zb kAZ5Ccqhawz71CwCMnwWQWip3yJtQJaXMBfe8U44gyQzqvf4y6CG3MJCDVGbbQOuMYoSBQw2 1SOntevAiZg2IB5UlrEqO3S92nrf3FIcylSPkfoUDfp/fHbo94foR7jRO1hL5entuDMIjrp0 Rqz+X1Wa6oosSIb60mq1QmZ3mPw/sWQE1RdChb/BTz8sF4gDGKxT8nxsAWAs64dRGqMZgPZ1 EXojfRy+wzn4XulsCWWCNsAE7iyjxpuGG2N2AU/d3XNGtnExpJCQWyzyGsnTKuRGpxYEQIFm WeK0e+r2LddPWGxcYh8aJ+rBsIhwMDITIq4B6yKM4YUPMMtJWdrGR2CgmbJhwjQfLUEy/lja f93j+72ZZrlNUiX5GXvHLpMuVPa7is/2XnSVfjG8vhT6pLHPSb9YepUbzOzghURtvzsTPP9r 4kCbKNnCnx3DIXDX8Ug2ddNdg1bdyNqXM+eRg4+XrfrHzeK0VoJU5f5qY7NsaQ890iJvo8kJ k2AZ3I=
- Ironport-hdrordr: A9a23:SeBK+KGVViudCsjBpLqE6MeALOsnbusQ8zAXP0AYc3Jom+ij5q STdZUgpHrJYVkqNU3I9ertBEDEewK6yXcX2/hyAV7BZmnbUQKTRekIh7cKgQeQeBEWntQts5 uIGJIeNDSfNzdHsfo=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Aug 03, 2022 at 10:24:26AM +0000, Edwin Torok wrote:
>
> -ifneq ($(MAKECMDGOALS),clean)
> +ifeq (,$(findstring clean,$(MAKECMDGOALS)))
I think it would be better with $(filter-out,):
ifeq (,$(filter-out %clean,$(MAKECMDGOALS)))
> .ocamldep.make: $(ALL_OCAML_OBJ_SOURCES) Makefile
> $(OCAML_TOPLEVEL)/Makefile.rules
> $(call quiet-command, $(OCAMLDEP) $(ALL_OCAML_OBJ_SOURCES) *.mli
> $o,MLDEP,)
Also, don't hide this rule, instead, hide the "-include", there is no
need to have make waist time trying to find a rule to make
".ocamldep.make" and failing when not needed.
> endif
> --
> 2.34.1
--
Anthony PERARD
|
