[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 3/7] tools/ocaml/*/dune: dune based build system


  • To: Edwin Török <edvin.torok@xxxxxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Wed, 3 Aug 2022 12:25:32 +0100
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>
  • Delivery-date: Wed, 03 Aug 2022 11:25:48 +0000
  • Ironport-data: A9a23:u/WLFKsW5Snp9ROCuEKwgAaqZufnOphVZnV0MsmfNr3fNXix3RfKay+Q/FW+adQQAGeMLe/JN1EfVX4R8wfhrKbi6CpY64WqmF36eDt31gdESYEq8x0Nr3Ym3tovaXfk+c9kvjbJUzTAoepdnHVYCqP2blErZArqUg/lYzHv7xU6NTyr5GRw/Q0I85xT+yX1F2Ws5VqEtGu1QTLIujTFaJFPPVk9tPzbQtB9huV5P0/FdJAEEAgsy/1IC37C4dueRPHVGd4YVHaxWHgqj8br8/jn45Cz8D9Pfn3Ge92DtTEEsmlCNEYS7EkEoNONf3tjnSkNSKX364q8xjzSfmPXUBzJLpMOaRrZkwcWQ94t58eMsMxw0NdyatkZfH269VLRDuAV+FqYNdqHe5fBf4OLzvyIZyj4gRBhoSPUayF4eD/2H+jDXPFYWWqBGk8H2Ovyzu7kxQLgk5ASPSN1v/i+R4WHGDbNqsBpMe+5U3j08DB4Gl9VV2yUT+XD93dmt6A9PvR4FW/hJjbkNsDJsPM3dpSFO9BAOGl8z92ZxaCxVF+ByuCV6dDD1u8YLH2ttJaCKA93nzxN4Nmy7lKC0zDsZ/4Of/p8fRmEGNJt0kbbh/r1NAVYr/UQ7aCvQbT4Vn1CVwg8+Fx+ecUuzMOXUQeuzkLcNBn1+dXKmHbZoG0l7LWdgRm2+hKzKGkOhHCucZrIQJNkM0DkNpIIPHiJhwWpAzPUys8oGwr4ng7w9baQXJ6mgWowlE162U+oUy4wC3CYCb4KTAp1YgFXDoTK5rYsXZf7doORfbB4Wo2Geak8zZ3Ctj6yzKUY/Skwf57+jmD+7O288t5ywFJICKWQSmNztM5Rsb/6MrX0mAMaiqnXSxMJKmOXOv/TfDAK/PeyUzmaZBMS9jzhS535KfsL+LIidI6V/82IZV3nCeBBNd0gGcHfDWIoZPgyIx3Rsf/L7mSV/hfsRfEVkJSdOPlOQ+Zvdh7ifisn6KAuVBIR8vPCm75WeTR1wbkOezjx1BB62r/quyYITaqcTmUo0HCXuMoXtQwP88OIrIIDpRhm59W8e1EbtC6a5qthNU/oA/QFpSPM/N4NxbaX5hFoKDPCSM4Z2Ubal9fwHz6AuEaGUkuIObjLUw6McbT4A4rMfQFEJJ72Zh/R1FwF4fhvyVENtGuvEsVm3LiFATMXU/0+Kv6Nk8N1LCB1Rg1GsFC3c0JoH8c1wjXtliNL+e5NwpyY1MyGC9sCv02Vv5BgxzvSAC1XUIJwE7eEYvcqDIHBdMUfI8g1Edx2K66Jka9VCPzruOZccbwkdFzlu9kZKNbJCYrHZ9V0U9Rvu2th0au2XtRYpOIP9e3rTvcJFfS35h0C5fhKS6WF2QgB+P7LhWNz5xj+/7JFjkw374BLtAeMXElA0hjNgwMDhCm/DktRX67LRONY31YwHcYmzNb1pe/dko9hLkBY7ohniN4hqTVB7fnYgghQZYdG6idcB3NJLqhyXh//4XjIU0aAVkIaMphbY8+rcb+ZaeImqs685KiUmkhWEDANI/yMKfxgzDDL56CaafHnKFDlUayzFy7Ce7CJhOqrAn2/yQuaddpOW0u5e2RXfkEDbz5XmETE1IusXCL29hSDOrmlN0G47ETsjXNx3Xg1Mp7WGTQEgXktEuNvCu02TfntYgQsF4UAucQbsmOL+IxF9WVYy4ldNnBcuUKDDbS8BchkIM/2SDp2WkzJQkuOk2Jw6xc6fBLEnGPrbzz9De0FoCpnLdh2XbsfPgK91oOSc2tITdXVf+G1oJEaTbbTGbmtomMLz9c046Zg5cF9tqo7Ii2V49R8+raDA0vRZCUWRpwSpRe3IjjO1ZQnlDGXcGl0dzCJadXkCvERfXkpuz8QU2v5m8Y4F8DkJ9ahWfSPytBeMRGxL2yiaEihMsDhNhzMd5g+NDMRWS7jqD+JB9+39K/V8mOmCfDEnIziI1n/HhZQluwDJqUuaQ2rWcfmP4ZDHEPhNVLUb7+AvTc952z00DvrsvJBWy7cbCsKoLz/35xJrcdDb4IoM1yC+GENw2houTFVmF9nZZgFmkfv+13Co8mfF8/GJLV+Vwb3XDPq+wyuEAqArT9hkCgNdVENS5MJHfhpOTu/nYj4DOoxrCMtkbkxKWWlJBqUJoddJtSQFXgvDNoQi+W+vZ06XtwRlc2jgtP3ffr3yIdu3QbVL0xmMIHH37Ke+ibITmTsC/o3ycNSfl73A+kz9vOKkHPpdH1Cwe7XNJ7C6nx15hg3U/gM2uoqpYgPg2NeGEHPbnDnyGe/u3g+Kxgf8d2SpvoQLC+ZI8QVo0dprDD4JtN1ok1IIL08aKLYoEzHpF+5Gi3D/zYZj2YRFD7zoIM6HJ3y+vQO3sw3H6jhUT238mZ+9MSx0hqaM0yET7vS2KBl6tAJnFWLHqRg/7mg2VtJzLs2zX2/w3XvpomstWoqmiaJSL2/nR8mmlQaPRAgk02kIyx9b1kggFMXvR71Jf7O3Q3WIpeW9Q4s/k7/r/s3D5M9VlEFMe5vs4lHEUGaWor5KMssqckQBgWF0gteoRE3cT1YZDe5V3c2/grNwacIVtfcpQ02tETUhg1PH+kxn2K88H3g6ygFVOpbelRvGRjL+HYPcNM448t7UWmyCsUh/QMjQHYZqZkJ0oMNTlhVEPfJ1RQxJ62CRFPlppbjdg==
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Fri, Jul 29, 2022 at 06:53:26PM +0100, Edwin Török wrote:
> Based on Christian Lindig's work.

Should we have is "Signed-off-by" tag then? Also he might be the author
of the patch, isn't it?

> Initially this will be used to build unit tests, and to make development
> easier.
>
> Dune supports proper incremental builds and editor integration with
> merlin/LSP.
> 
> For now the Makefile based build system is retained too: this is not a
> hard dependency on Dune.
> 
> Using version 2.1 of Dune build language here, because that is the one
> available in Ubuntu Focal (part of the CI here).
> 
> No functional change.
> 
> Signed-off-by: Edwin Török <edvin.torok@xxxxxxxxxx>
> ---
>  create mode 100644 tools/dune
>  create mode 100644 tools/dune-project

Should this two new "dune*" files be added to MAINTAINERS in the OCAML
section?

> diff --git a/tools/.gitignore b/tools/.gitignore
> new file mode 100644
> index 0000000000..c211749a3b
> --- /dev/null
> +++ b/tools/.gitignore
> @@ -0,0 +1,7 @@
> +dune-workspace*

Is this file going to be in many subdirectory or just in tools/ ? You can
prepend a slash to tell git to ignore this file only in this directory.

> +_build/

Is this where dune is going to do out-of-tree build by default? Also, is
this only going to be in tools/_build/ ?


> +.merlin
> +*.h.gch
> +*.opam
> +ocaml/*.install
> +include/_xentoolcore_list.h

That last line doesn't seems related to dune, why is it in this patch?

Also, can you sort the lines in this .gitignore?

Thanks,

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.