[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 04/10] console: support multiple serial console simultaneously
- To: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 5 Aug 2022 09:41:09 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TMVZkPaBcQFTELXHDK18Lma/45F58cCxaNf992O8oDE=; b=SVhEPfRYElZoM0OXItpI+yJ1XeTYYYjBnV+nWe1Aifne49Hbni0g1lo1kENmv8c/wQJTnBVAm/x+fH15YrPzn6X6Yg5KcuUNruzXvn1Mjg5mOsYMK9xPKMiNqtCkZYYdTcl/ox2idZQuVlhUR7WHHxbtyYnArGaeb/ahkmUASlIkPA+VOarVaDQ05uOkzBzqpPJq+i8T+EBJt6aXQTrQYD3OyQXf7tpTht2WnicvP6AKDxDChe4O16/fVTFXvoLUZUB/0/QRkccmehkoocxG7p90hknNZa2fTnuXzMv2gehgpwuqHo6/Jc1V/dPKBiHH4L/aByGix6kwc/M/rv+eGg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FWVadnHgU70SJ4Jbrn5V0Rslm9Zldgcmdy1B9Hot/1nNlGUNMN/d9Kf1HLstLxMicE5lN6Fnj4hL1FKhyaKbG51tYLwt7p390o2qYXPjOjwwA80q26f8ArsfMLMF5ZbMGWjZjoROZsFWGEPRjbUW4e0iwh5nRRFWmRV+LFijMiTihyRl6RDMaTmO6mQEA4Gvej1yag+cqShr6ZUxIjZze/iDP7/2ba493Sby6tTWsvDHyqEaN8DLQuMoA33rgzLU+HOZqywxdCmsfbtwQqhtjFhs2bCLBWb43LCVBARvSmF37+FPKEQ1BqJiOIqR1ksRnPNiWeZSffQkM7MzS5yOdA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 05 Aug 2022 07:41:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 26.07.2022 05:23, Marek Marczykowski-Górecki wrote:
> Previously only one serial console was supported at the same time. Using
> console=com1,dbgp,vga silently ignored all but last serial console (in
> this case: only dbgp and vga were active).
>
> Fix this by storing not a single sercon_handle, but an array of them, up
> to MAX_SERCONS entries. The value of MAX_SERCONS can be chosen in
> kconfig, the default (4) is arbitrary, inspired by the number of
> SERHND_IDX values.
>
> Make console_steal() aware of multiple consoles too. It can now either
> steal output from specific console (for gdbstub), or from all of them at
> once (for console suspend).
>
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
Actually I should have clarified yesterday that despite my effort to
review this change, I'm not convinced of its need. I simply don't see
the use case of having multiple serial consoles at a time, and afaict
console and gdb connection can already be run over different channels.
Jan
|
