[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/3] xen/cpu: Minor coding style fixes
- To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 5 Aug 2022 14:50:13 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UBAYKGBQ4ZkaDkXTgIo3+RIjMC6njktJsE/xLLQtPVc=; b=VfjPDW8U0i10EJcw5DyGYqV/7Ee4x7ecEf/8a6VYBDKBDmtPqHfPJuCREX0H2Ecq12wD/mYKGlsaxwSfAj+PunRN3yZZBn1IyJJKZ0bl8fr+bZETiNe2dWOJuj2OdwbcUDBBEkLM7NCW+PRWHYnYr4OV5yNivuInpdiEO6x8OxV53JSFFRCs1VdK2tmJsvTIJyhZxGd/CQGu2d+nJdDLW8Ylx0aU/WJbphFSoPKpG8vbjG6w+AU2TFwcTqB5N8uZqqp23dRB51e4kp1jrORknUYVGreptIpG2rCLCvvIq7UOH9s7T1TT30Acngj9x/H4K+JEtrFw8MA/3IcRmwsjFw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KCaBPDKEgrohx+JX5BY8hpxXVpkg6potRRK6sXNu+effyIvYiTQtiPVW7UL5FREo3Q45pzbmppoIRbD0gdBZnXIbq1grW+JM4EAxOLobGCTmMfdSVginUupEeEhKQ46FXSqem42fFzZW0MOi8lde09auJMTI8TYS0ZwNfTADw/hKwjKpQlfQ8XN5g4WYyQ7kN5khge4IuxVNrVsvtf+jPKekJmfbUvvYHWqsG7QOoR0Fed2knmqh1llJgZiqpKR9mvBNS4Mg2pdozxbork9xwYw+wThre2AnUB0s1uNsDkwe7/jUK5inhUetBX4dDIxkX5KynrUo3mck5BAKIZgB+g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 05 Aug 2022 12:50:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05.08.2022 14:44, Xenia Ragiadakou wrote:
> Xenia Ragiadakou (3):
> xen/cpu: Fix MISRA C 2012 Rule 20.7 violation
> xen/cpu: Add missing white space around arithmetic operators
> xen/cpu: Undefine MASK_DECLARE_ macros after their usage
>
> xen/common/cpu.c | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
However,
- I don't see why patches 1 and 2 needed splitting, when patch 1 already
touches all those lines. It is the usual thing for us to make cosmetic
adjustments when touching a line anyway.
- Patch 3, while fine to be separate, wants a Requested-by: or
Suggested-by: me (which I guess can be taken care of while committing).
Jan
|
