[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] arm/domain: fix comment for arch_set_info_guest
- To: Xen development discussion <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Fri, 5 Aug 2022 13:12:50 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MZlSKummqDwyA7XSeCEvJAjoFOPoUHXJcN868r8iNcY=; b=RKnW1sC97J0OanPGQ4qprJK9a5y0jWlMD9I5LiuyS0c4JX9LQtkVE42E3EtrXxos4xBZbjmQdmMDdKMskBwiNmC517ledFlWrduSuDZBwnYKu1soZsYHmNX/eu49dAdbKfkBg1uubMgJouBxPcv3BZaAskU+yQ26IPOnwXZqtW+jlOfGHjdWfq0BQLcLpcRH02utb00nZ+ydqvTcjU/ufIr9hnkg2k7t8Qjq0gvTRV+BXvF2AIAZMP6qzp/GjgeJRxq/pV+3MUJrbPszg+mM/l57jI5CVQCLHmGW5TmEWe/6BXwfSpNP0LpdwOfeaf6sZGKk00TjZtedAT9c5zqyoQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MZlSKummqDwyA7XSeCEvJAjoFOPoUHXJcN868r8iNcY=; b=Z92UR6A873UJhF/+ajwtuu3GNT37pmLu8kCgetj9AG3hR+K3//H5XfjjCsjQd+K/jsyn69TB35VoIqRIE1sbDfobQ/cDMs+S2qbmYjOGyeysodMrwszuWx7vZ3f/fLzo4owMR6iMCggjyVhHpiLH9RqeWJEr1j5sifxr2GmUJ2N/e+G4IHd4/NZZT3huGCR3q9+KmGXbyRvbT1s9eXXZOIRCGUggahtK/IIvEA7CM0MNN/k6h2/Cy4EBwpBsjfk9qg81HIjHjgymaIj57IIk3aJUMBrPiP6/5rFswxmMk3D6Dey3PlfGSzIwR2uhqipZk5Gi+IgYMxpZCG3vdQmHbQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=A6lX5AdE1sH5dm4pCnzQiI7UAjmoe8EgJlepyfCqwW1Xsf7+kTOcK+voBTjmVSF2m6M+40ASh06bHA4b5ob0U90dK4YjmC70eSrLTNoa6RVRlRsIW3VHrAeX5FWFw9mUUAljFB7f6glzknmmPhaRF2h26G5RoqhOtamPiRb6sSdoAk42QPb4B2rGXw2lpoANqo1mP0UtYTmj7iXBco2xo1OdjUZpVkN8gmXhB36c3zdTFU81/oaFRj4Es6Cl6gQOmxnyfCkuuNjiGchu3v+AJoSfdaIcIT+dw5/HnkPmsQjO/Jv1l+09ExWYvsddpi/pw6vsKjC363WHM4Jmvnfqjw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gRfJtSgh7DCh7K2+1KAE7utDGA1YBrNR/WgqT7HlCuPdCUCVwrEZrZ25Rp34lxIKls4ayfb3frAWezlLnN07HAvflzWHcI803nONPl/x7yDkssrVWp375RvSORIt2OdYW5WPkMQ4O4KkUeM92JdXWtuu7iBbqFU0ekKioATYa9rF3A7lRr55/PWO+N9RMUMAcyh1l7fXQLRRYSnwoOC4+IZ35zhVLzKeas6mRqtyBcTYMeem5odeZSaN9nM3MFVrymnmT96Dpu5Nn98IxvG/f/fFEYiwqrMurZv92puba0Qdd96QUn+sHGdA3MHSXlmXiG3rYsIcNvjT8mtB8lQD8Q==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 05 Aug 2022 13:13:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYqMxj+SsCb6WfSkeThh/1USfbDq2gSIcA
- Thread-topic: [PATCH] arm/domain: fix comment for arch_set_info_guest
> On 5 Aug 2022, at 14:08, Luca Fancellu <luca.fancellu@xxxxxxx> wrote:
>
> The function arch_set_info_guest is not reached anymore through
> VCPUOP_initialise on arm, update the comment.
>
> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Hi All,
Sorry I forgot to put v2 in the tag.
Cheers,
Luca
> ---
> Changes in v2:
> - rephrased comment to not list caller functions (Julien)
> ---
> xen/arch/arm/domain.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 2cd481979cf1..9db8a37a089c 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -885,9 +885,8 @@ static int is_guest_pv64_psr(uint64_t psr)
> #endif
>
> /*
> - * Initialise VCPU state. The context can be supplied by either the
> - * toolstack (XEN_DOMCTL_setvcpucontext) or the guest
> - * (VCPUOP_initialise) and therefore must be properly validated.
> + * Initialise vCPU state. The context may be supplied by an external entity,
> so
> + * we need to validate it
> */
> int arch_set_info_guest(
> struct vcpu *v, vcpu_guest_context_u c)
> --
> 2.17.1
>
>
|
