Re: [PATCH 2/2] automation: qemu-smoke-arm64: Run ping test over a pv network interface

[Xenia Ragiadakou <burzalodowa@xxxxxxxxx>]

Hi Stefano,

On 8/6/22 04:18, Stefano Stabellini wrote:
> On Fri, 5 Aug 2022, Stefano Stabellini wrote:
> > On Sat, 6 Aug 2022, Xenia Ragiadakou wrote:
> > > This patch modified the test in the following way
> > > - Dom0 is booted with an alpine linux rootfs with the xen tools.
> > > - Once Dom0 is booted, it starts xenstored, calls init-dom0less to setup
> > > the xenstore interface for the dom0less Dom1, setups the bridged network
> > > and attaches a pv network interface to Dom1.
> > > - In the meantime, Dom1 in its init script tries to assign an ip to eth0
> > > and ping Dom0,
> > > - If Dom1 manages to ping Dom0, it prints 'passed'.
> > >
> > > Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
> [...]
>
> > > @@ -113,5 +148,5 @@ timeout -k 1 240 \
> > >       -bios /usr/lib/u-boot/qemu_arm64/u-boot.bin |& tee smoke.serial
> > >   
> > >   set -e
> > > -(grep -q "^BusyBox" smoke.serial && grep -q "DOM1: ${passed}" smoke.serial) || 
> > > exit 1
> > > +(grep -q "^Welcome to Alpine Linux 3.12" smoke.serial && grep -q "DOM1: 
> > > ${passed}" smoke.serial) || exit 1
> > >   exit 0
> > This patch looks great! One minor comment: Should we great only for
> > "^Welcome to Alpine Linux" without the version (3.12) to make it easier
> > to upgrade in the future?
> >
> > If you are OK with it, I can remove "3.12" on commit.
> We also need to remove DOMU_ENHANCED[0] from the ImageBuilder config
> otherwise this is not going to work.
>
> diff --git a/automation/scripts/qemu-smoke-arm64.sh 
> b/automation/scripts/qemu-smoke-arm64.sh
> index a79401fd81..0d19ad52cc 100755
> --- a/automation/scripts/qemu-smoke-arm64.sh
> +++ b/automation/scripts/qemu-smoke-arm64.sh
> @@ -118,7 +118,6 @@ NUM_DOMUS=1
>   DOMU_KERNEL[0]="Image"
>   DOMU_RAMDISK[0]="initrd"
>   DOMU_MEM[0]="256"
> -DOMU_ENHANCED[0]=0
>   
>   LOAD_CMD="tftpb"
>   UBOOT_SOURCE="boot.source"
This change was not there when I was testing, that's why.
I will wait a bit in case there are more comments and I will send a v2 
with this fixed and 3.12 removed.
--
Xenia