[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 8/8] xen: retrieve reserved pages on populate_physmap
- To: Penny Zheng <Penny.Zheng@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 9 Aug 2022 09:59:02 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W7IiJ0bbjzrhdCSZ6D0gXF1meTgCbnqHa0H9BLQw6KU=; b=Qf2xYocpjtyzWmUhyn75AVr17Tjk7BkV31lYTVJD8GaFH8p5f3qVgwDKhvZj/8/MA9dkvZ/nMCKAhInLfM+iZI6wZJrGrwP+05sAvTkg5Jv4u9ZvqsIiCdFFepaeU0rt0lTyWC7cXm4YA48Q3926EGKyE4wTJhjkkl/cZRvYNMJ9e9mco6r+RTd3huvF85ncEbRTASblKF7P7ntrZL75kadVEsKUYyueO0+nfaw3k4JDIWeqzs+KkdAPEqWA99e76w7lFWPYEqVNI8twk5qDw2GQ2TMrJmN8Gtql9Udqzm6bxZp+eMQuspnqEpDy2XrbxpqITymIU8sWN4qLUXPB0Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DXk8lSG5XJgDwYKkzOgVs+XNC8Qrw1SQ8RehveMZWAPQcjGSe13SJiklneA8hetbR5v1Yr4wZKoexmXGkHiebhW0hXLuWp7+xpNwdyfH2yhNPRRf+Q6el9fq+ChPnwd0Yd/Vv4BhwYYfUwzgED6oriUCaGh24tosJ2WyrVTCoIK/+1fXgJy4HrBvt4zurbANj44RWBlVwuYnclFJbBjOAhUzsXpOlMSxFwGSQzAIVrTD9WBGEK9MCDY2Pu8gd5NpGo4SK0WWmOQTKvIE0AE7N9UsNQiK3hqJTXjrYTqar80iypnlce8WrOzTrRsWmNyo+xb8SsHvVx175N6lgELvAw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Wei Chen <Wei.Chen@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 09 Aug 2022 07:59:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09.08.2022 09:53, Penny Zheng wrote:
>> -----Original Message-----
>> From: Xen-devel <xen-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of Jan
>> Beulich
>> Sent: Monday, July 25, 2022 11:44 PM
>>
>> On 20.07.2022 07:46, Penny Zheng wrote:
>>> When a static domain populates memory through populate_physmap at
>>> runtime, it shall retrieve reserved pages from resv_page_list to make
>>> sure that guest RAM is still restricted in statically configured memory
>> regions.
>>> This commit also introduces a new helper acquire_reserved_page to make
>> it work.
>>>
>>> Signed-off-by: Penny Zheng <penny.zheng@xxxxxxx>
>>> ---
>>> v9 changes:
>>> - Use ASSERT_ALLOC_CONTEXT() in acquire_reserved_page
>>> - Add free_staticmem_pages to undo prepare_staticmem_pages when
>>> assign_domstatic_pages fails
>>
>> May I suggest to re-consider naming of the various functions? Undoing what
>> "prepare" did by "free" is, well, counterintuitive.
>>
>
> How about change the name "prepare_staticmem_pages" to
> "allocate_staticmem_pages"?
Perhaps - if what the function does really resembles allocation in some
way. So far I wasn't really certain in that regard, and hence I was
wondering whether "prepare" doesn't better describe what it does, but
then its inverse also doesn't really "free" anything.
Jan
|
