Re: [XEN PATCH 2/2] tools/libxl: Replace deprecated -soundhw on QEMU command line

[Jason Andryuk <jandryuk@xxxxxxxxx>]

On Mon, Aug 8, 2022 at 7:06 AM Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
>
> -soundhw is deprecated since 825ff02911c9 ("audio: add soundhw
> deprecation notice"), QEMU v5.1, and is been remove for upcoming v7.1
> by 039a68373c45 ("introduce -audio as a replacement for -soundhw").
>
> Instead we can just add the sound card with "-device", for most option
> that "-soundhw" could handle. "-device" is an option that existed
> before QEMU 1.0, and could already be used to add audio hardware.
>
> The list of possible option for libxl's "soundhw" is taken the list
> from QEMU 7.0.
>
> The list of options for "soundhw" are listed in order of preference in
> the manual. The first three (hda, ac97, es1370) are PCI devices and
> easy to test on Linux, and the last four are ISA devices which doesn't
> seems to work out of the box on linux.
>
> The sound card 'pcspk' isn't listed even if it used to be accepted by
> '-soundhw' because QEMU crash when trying to add it to a Xen domain.
> Also, it wouldn't work with "-device" might need to be "-machine
> pcspk-audiodev=default" instead.
>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Reviewed-by: Jason Andryuk <jandryuk@xxxxxxxxx>

With one question below.

> ---
>  docs/man/xl.cfg.5.pod.in                  |  6 +++---
>  tools/libs/light/libxl_types_internal.idl | 10 ++++++++++
>  tools/libs/light/libxl_dm.c               | 19 ++++++++++++++++++-
>  3 files changed, 31 insertions(+), 4 deletions(-)
>
> diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in
> index 6d98d73d76..b2901e04cf 100644
> --- a/docs/man/xl.cfg.5.pod.in
> +++ b/docs/man/xl.cfg.5.pod.in
> @@ -2555,9 +2555,9 @@ The form serial=DEVICE is also accepted for backwards 
> compatibility.
>
>  =item B<soundhw="DEVICE">
>
> -Select the virtual sound card to expose to the guest. The valid
> -devices are defined by the device model configuration, please see the
> -B<qemu(1)> manpage for details. The default is not to export any sound
> +Select the virtual sound card to expose to the guest. The valid devices are
> +B<hda>, B<ac97>, B<es1370>, B<adlib>, B<cs4231a>, B<gus>, B<sb16> if there 
> are
> +available with the device model QEMU. The default is not to export any sound
>  device.

Is it worth mentioning driver support?  I think Windows 7 and later
only have a built-in driver for hda.  Windows 7 definitely doesn't
have a built-in driver for ac97.  I think all the other devices are
even older, so I doubt Windows has drivers for those, but I have not
checked.

Regards,
Jason