[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: vgic: Fix coding style in macro REG_RANK_INDEX()
- To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 10 Aug 2022 10:07:57 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zZNhXIe12mODZAWTu2NFKAjjkycBWBTxGat3A+noRa4=; b=Y6cKD8TdLV5wPx5n5Th5ZEgVZ4Ay5W88dFT68JpkFuMQHJLfCm6aJcMsqB1Q9p0dX1wyHyNbsvJF0YykQx9sFB9YiIwuZJWDumViR2qaEqZk+YoskWGcrjaNAPpEkv/zDJ+bwCatwcdE4HTP2bSTTWQkZ5rSVXR4IFtnpDOet2Oi7BbksIyhMLkFyungMej6WK5jGkI+XdQpVYf/4UguFCbLejdp3ET2Wb4AUhd2E0V0SFjdLJbR6j6tZhqHKSwU0vDg+5toL+mKwzCkVprfVBKbvJvxsheR0OMSyeidznKk8sxFBudcrtXwuimf0pWnwjJeb9FbIY1UMAuAhyzd/g==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zZNhXIe12mODZAWTu2NFKAjjkycBWBTxGat3A+noRa4=; b=ZOqxgXVqdxhv/rXWMggZryoIBwnOnLbZlTCyH1ybpI2FLgh9R+wmasF6f231y6fMgxKxODS04D2QnUK61tjEZlTTc4/MBojOkPaJ+XUTwJ7+bGv9y0ALq4Y276GVPhql+NH41qFwYkY5U41hBN3yZ1qEkCLwL2FsD1o9v5WxZn19W99/FPIPxyR3v2bW+xVY+mt81ThDYkm4EXZ6KEG9Xg7UM4d1vj73pXId1hgsBtGh5m2ePbH7Uqa8a2tT0v4NryajJfLhBmR0K3UQYLI3yd3fBadXAJ/HSstw36NiogS4+lwASiNbWeQA5OBMM3GJMYH5IAgSCLJbdiHqA3fqOg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=gtWioYClUGyarODH/Tn0X+uMah09sLzit9ov5+jSLc4T8tZz/gmdonDleyLyfS0aiNrmOz/1E9zjXkRD8bCZf4d5dQPOPhq3kIvN0Y8Jl9O4xa/ZnV5aRXTRBmIQ75I535pTwVSbnuTrmEOxLU5p6qwqh2kcTW+z3z3PoXZXP3wKtfo+4gCWXiQbE/y/Mj80PUssWVUbgBuntrS5OocYZ5e+G5/SWhUpD6Vj3jxNa6ft7tgZjRX4zHReKgKwpwPrk6j4xt/0Y0AdmhU7tqh/baKV/m2DYRQ3vROsdYaip+Ave9r6vNe6ltz4kW9XcUEFWNbqKmHJdjxaHi5mmJADEA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RcMlhib3kGBOpdEt/nxE3ofj1XqOBTPBui0Cv+lw8hk7Me6ys3YtD6HyrOi7UnhAEjkMcSd2jBaCAp5Xdbk3IqpinFECP/9tlQjrobNy+lbD6Y5LQVwqSpLDp3BY2luPqJXsQ9Tr8Ip8dLHJqFLZgg7rcOtPXr99hanznC5CRRFlouZGacYia9BR40biomOSdjYT3PpfLBYQAKekPFcT/3N77qiPXvMLNSvNN60FJtv8q76MbHl8mNdlntkgoBMKtX/I0ggF2KnaKDiji4o8GGsqdQciYBrJcVdc5UW7W8UiyyqCp2AWJiQOf5WzxRzU+r8V6/zsWGM+ZuM8AXBiFg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 10 Aug 2022 10:08:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYrJ8rGrSNIysILUarIEyFwudE/62n6OAA
- Thread-topic: [PATCH] xen/arm: vgic: Fix coding style in macro REG_RANK_INDEX()
Hi Xenia,
> On 10 Aug 2022, at 10:53, Xenia Ragiadakou <burzalodowa@xxxxxxxxx> wrote:
>
> Add parentheses around the macro parameter 's' to prevent against unintended
> expansions. This, also, resolves a MISRA C 2012 Rule 20.7 violation warning.
>
> Add white spaces around the subtraction operator.
>
> Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
> ---
> xen/arch/arm/include/asm/vgic.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/include/asm/vgic.h b/xen/arch/arm/include/asm/vgic.h
> index d2a9fc7d83..3d44868039 100644
> --- a/xen/arch/arm/include/asm/vgic.h
> +++ b/xen/arch/arm/include/asm/vgic.h
> @@ -286,7 +286,7 @@ static inline paddr_t vgic_dist_base(const struct
> vgic_dist *vgic)
> * Offset of GICD_<FOO><n> with its rank, for GICD_<FOO> size <s> with
> * <b>-bits-per-interrupt.
> */
> -#define REG_RANK_INDEX(b, n, s) ((((n) >> s) & ((b)-1)) % 32)
> +#define REG_RANK_INDEX(b, n, s) ((((n) >> (s)) & ((b) - 1)) % 32)
>
>
> extern struct vcpu *vgic_get_target_vcpu(struct vcpu *v, unsigned int virq);
> --
> 2.34.1
>
|
