[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/cpu: Drop _init from *_cpu_cap functions


  • To: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • Date: Thu, 11 Aug 2022 10:21:50 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a36EBYFPt67N6elBvanE6Be5b6mseFgTOhjTIYc4vtY=; b=QjBOH+8TqUrz8ozxgarZcPAj4Eapub21IZKiauq6uFL1hbVxCeZn4lbwR0BUEQiRb5CAa7rg/hkIZXLvgXYULk0L15Jylf7tMifeu4y+7aU2yQ9lFmwfNXAIHtCBNMwSgZzkmSDkYb/OlA7NQ82RfYrpDghwT8ad6XXlb3g2e0i/pTdbNpbrnb/AwmA7tIyoKjF/xxp1/T6E7hRYGE2cxjqyuIHFIy0ZVN/cbujlDH4BEtP8hncHLOT3UB0g2gLxJkjb3/T97xN4lh57giiPwJfN8fgvR0fzoVbcYibGa5vHIGaSf3P7PUcV+5yXDV7vJbiZkmNzq9UoYtqVnsalbg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KcGzcXf5ChOLoH3uBFznLk4rPUxahW1bU9HPJipZwYQd6f+zM5/UK7B4nw+xpunStClUDbqa0o4+LGCxnoF1Z9+NoC/aFpM/meXzDfzWvMjHYKmPG6GaXIKTfaLn9ibJdgO3nYmSfU6HPSkdejJ6lQvH5C79QDnR1PQJ2rCLta2OGFKzjByKPxHS4JZRyrSpYNoe2Am4dzaxB9A0LsWB4xMtW4SwxIXEXlb896QhbEYZ58+AmGaWi6ytz3KOOYHcAS2wC6KmdhDZo3pifbSakj28EaAwEkZQ48kTQgCBmPd4HOwgePfoGerbP9mMPZnhvfCb4a+4ULdkdZMaxPXudg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Thu, 11 Aug 2022 10:22:07 +0000
  • Ironport-data: A9a23:KWY+c6tzYQq9p+9skf+Pk3ZKIOfnOphVZgL3LMmfNr3fOXjw2xdKXGK55aDH35v3Guxd+/pgKQ+wLbxTwizIborcBzKvaWIBRr3IGnh30Bx70HU1hOy1/YD3m4O2p2k5uZ9NwTk58X2NPwaQJHrViW21zxCWzWNrSULLaNdUChQ9uzNzZfDSVK30qWJ0TCMbkjPdM4joLnl6+NxmiTuPDhYo2P+oEomzmMbvRtFINa1hkNBpehmQwjQ70pfthmLaMvXDyLDVZFk80k8+UFS/BVGHoAAAX/JwcYnFk8Rd3V9ZHcSAECYH+2afv0nbBzwe/QCPay+alaqaA24XHB4LnVK3EiDwHCM8j2PTrDpN5vsW6iyMPOw6IWd04z59z89CjcCD68tz7e6RHJ4DyFMtMApS7ltB2xwzZCmZsDamLYEXXxBG5jzem3nhCrwnzuh9b7e92AL6u8c+WkdGAZOCLVV5L8UCxfTLvSdpDvUYriN7No85ddeMOOCoKV3aWHWO/95xdGIqmR3U/8TVEn8TmjUDKdiV+OFFJLwVmHFK47IW2emkA1TvxlA9AEPBeARWZEMRnP3+O3AeVEIJTSu7pylgcH9TYeWQbMzgVNd+x39Gb+Ls7xlR0JVRc6YtPBjy0noJik8o7WBdhK3Dfrh59WXS5M027EooXqFqy/hEHFHnkqCWfU+YRV2FoHXsq8ummn52RbFWvkIoHs9CFg7lYPaWBEqFubb4sRDuq57ocQhnMFkjlS77KG9vjtIruEtgSiGP4XxIINUX7swiQqVzMDCRf1JDErE/2RJ9m6KpIKdbPu8GLNUFL85+tDqgVlwywhZoldNRLezdzl8rbZfUSozDM5SXxzxMisTwOufad+UTJXz0CN6m3SFqcVNrKVBWecTvvxO+pVs3K4cZUMXo+3yNHKyyNMgGiqyV+h/hxZQkaZM8Fn9mwsMSxs0vRcvM5KLDpvJSPKcMlCwMNA43Nf1/jbVA78EvXI/dHg1NU4N0UuymSBQFcVG4TYOtdXLC8Q+8KIs24iYksFOm3TGeJx2xAe4lT/VGNKBshNH58y4Wibf9DVwA4VyIw1f0c0dRCmVFoXHmb1ao7XsandImaRzK69KQY7OO2XQ/rfTh6tpGVEdTtiLRYFoj+tTm8ogog/WDeHZCB8w7XSFfMndel2BZHgtGxfqEwkR9Z1lrLfARSNn36PFEPsB7oL7nqA6egz07ZjUlmbTJUDhXSyTYjb16Vc08PLJG0+naNxwj6yKiNUSKMrDmE02j4CiBTwagmSF3Wmto01kF7oRjsKjKm9zDqq26ZmoI0A5eZr9Odt6xrWH9g8dRQtw5umj72OmZTvwzMuM5RTjqdqBVZuBLu06BORA76xkJbT0ByAqbr2eyu1TAIRcOUv/6aplsFZF5rpjMuvdKtG5bGww6nBu5cC21N2GFGh4Ux5li1RRmQoVshOkwXxzHU6XDhkztk+1H/er1UQre7HdZOhdWOsYNQJ/gBHvoc9OwbyZ3VbrEY9+ZlWzXhFrL59BqHCmA+Ezj2OBuMGFXulLOTI1nz4DuxLxGV/FsFjqoNQwyFE8Ltwai9XQMX4X7Sfcsaewq76YuLdiy11C2o5xuTrrPktuZ5TQ1p34govxqf3rwWeQHWjxq4OI8Uj9yTZ2L7pdedgNqFUwcYALntIKficE57V7UBj7d6t4Wp0cx5D5lW3nLM3chYQXh2JND2jZLKeYRDAPtTnPLn5vrC3gPHL1MRGauHOobyE1zfnnnrFJFP238wotOO+XWdqfKBoCOrPaxugFqxVsoHJAaplnO8Ez21dXqn7tCOAB5jQM1hfirA3ijG4gGtmzPPvJz/0POyU+/xgt+5PB98jj+ti2batp+HFdt98LUgL/8NBKcNjV3oMQL3m5v/31hRVsQkgMZfVCUrbrW9txNQTu+HpwZyw1iW2M5Fuv100dDcSjdTyQ9z6GT5iKqcboocNCAmaCOOFPcBdUtYUiu2F5vMXKgu0yACrqXavBRIO1mH3daVM/eLEk31BpW6qrxFbuYbuGiSwywzDTEHkZWd8yNrPWPtZ87ZPvxG5JA/ThKmgutwFU+k/zg69Tfpus7Ls/1ybTgTwV2ZBGbPcRk7MQ3CLGkrHNyrR1RqjxLRBlAIkH2Zn9And5czvayO+0Ybs6eZxVZuBjeRwM6BycUv51ID7pL2PdIeEV9aTEgTxZAif0Uf5C0hHwPqr98C6afw2yJYSYO7JlxzLGXxK3k+PWX8aYFFxuIFcN+BKHoyZAAvfZvMFfkDgdNTEnLJPo1J2JAWcCXpmS7CA5Li9jkdK2lFQwJvEL33HWFvBFhz74LjpT//a1quFelNZqrXfvziB2cHs00AkEijsax7Lu5PM7Xky8OWM/ZfLXqgpWDIQgz+BR0GALCtjjXgdLsvbf5pHVLhr8sfaH9PaY2276mxFdOjDUzjkVA/6sJK3B4Xl1ulwSHP7D+l1JG8eNAZ+vo
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHYrWuqM0jpHL25IEyIFgBUnyY/9K2pfX2A
  • Thread-topic: [PATCH] x86/cpu: Drop _init from *_cpu_cap functions

On 11/08/2022 11:17, Ross Lagerwall wrote:
> These functions may be called by init_amd() after the _init functions
> have been purged during CPU hotplug or PV shim boot so drop the _init.
>
> Signed-off-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>

Hmm.  That's a bug in init_amd() I'd say.  These really shouldn't be
used after __init.

Which path exploded specifically?

~Andrew

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.