[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] config/x86: tidy {Free,Open}BSD LDFLAGS_DIRECT handling
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Thu, 11 Aug 2022 15:18:07 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zgln2IJQYzhWPJHWQZ7pwhxJksIdJuGOA6CPVhNYYj0=; b=gCZZEMwXlhoSkS0pgiBNXdIgcpky9xMQf7y5VVh3sI/l0T5fqOas9frooi7ms8FaffKe6vaaSoBvNhS9XHvb9jgJxKKhwMyddyHEvWwb31g8Kxs0SE22rBmZ1wBIubm0aq/ynYpI1aj23/WXS6va9e1dN2e6O/Hv2v5Q4Ytm2bTLjxIvirXMfSy3stVhTsnEcKI2K9z9SHsBbHY/3ukwyITeticbHcI+a/J0o+mRpnihRyhsynRXdiBKa5mXhtc6BktFoN8bjX5fTaWOTTmXnn0WEVB48KCpGg+hID2d0Ss/EA9jzigiYsYmsmpkSi4lrAPYHNpjoeDgE5LHk56Pug==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j2cz3BPtG475RL7ZSEEdGS0AInoqP4WnDffDdjDzx+l3eRqeEjKgWd8Lz+SXf3Gm5uX4ZfsXvEX6i3Zg6D9CGghkMzSQe6bOk4DZXA+Wn+QZoz4r1bwkwT+W2Zkfqn6aLxPkTe+H4GEdMZnebCDfCFGySxdr/NWhjHfYszNN4/6HOZWrrVyci+jr2tjL52N1Q2fmjzkwb0wtOMCTAdu6E6rRLOGu9S4zCs2Cu2mln2ldqOxf5D8F+IUBgX5zcijI0ZA5NiLqIgAfYaQNR8QTVOWyiCUZhNmDwfA/Dy3qmGN55oCDpHetkKAIv42fNgl3FDwYZO381/YvLQRckdMZuw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: George Dunlap <George.Dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Delivery-date: Thu, 11 Aug 2022 15:18:16 +0000
- Ironport-data: A9a23:Gcu0Oa1l5Mklq8iozPbD5RJwkn2cJEfYwER7XKvMYLTBsI5bpzUGz WUfDG7UbP/cYWLxf9Ala9uxpBgGupHWztY2SgNppC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOKn9RGQ7InQLpLkEunIJyttcgFtTSYlmHpLlvUwx4VlmrBVOSvU0 T/Ji5CZaQTNNwJcaDpOsfrT8Uo35pwehRtD1rAATaET1LPhvyF94KI3fcmZM3b+S49IKe+2L 86rIGaRpz6xE78FU7tJo56jGqE4aue60Tum0xK6b5OKkBlazhHe545gXBYqheW7vB3S9zx54 I0lWZVd0m7FNIWU8AgWe0Ew/y2TocSqUVIISJSymZX78qHIT5fj6/x/IVAXD4EGxsVQGUZi0 dczIQ0/bCnW0opawJrjIgVtruIKCZGxebg54zRnxzyfCus6S5feRamM/cVfwDo7msFJG7DZe tYdbj1sKh/HZnWjOH9OUM54wLju2ya5L20wRFG9/MLb50D6ygBr3aerG93SYtGQHu1en1qCp 3KA9GP8av0fHIPAmWrYrCnw7gPJtTLgWMFJOJ6IzNxNvmy09GE9OT4xckTu9JFVjWb7AbqzM Xc8+CAjsKwz/0yDVcTmUluzp3vslg4RXZ9cHvM37CmJy7HI+ECJC24cVDlDZdc68sgsSlQC1 EKNnt7vLSxitvuSU3313qyPsTq4NCwRLGkDTSwJVw0I55/kuo5bpg3LZsZuFuiylNKdJN3r6 zWDrSx7nLNKhMgC0v3h+Uid22784J/UUgQy+wPbGHq/6R90b5KkYIru7kXH6fFHL8CSSVzpU GU4pvVyJdsmVfml/BFhis1XdF11z55p6AHhvGM=
- Ironport-hdrordr: A9a23:0Fi0nK5hrnWFUBWLowPXwWuBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc0AxhI03Jmbi7Scq9qeu1z+853WBjB8bZYOCAghrlEGgC1/qp/9SEIUHDH4FmpM BdmsRFaeEYSGIK9foSgzPIXOrIouP3lpxA7N22pxgCcegpUdAY0+4TMHf4LqQCfngjOXNPLu v42iMonVqdUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLonys2Yndq+/MP4G LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlagkEyzzYJ7iJaYfy+Qzdk9vfrGrCV+ O85CvICv4DqU85uFvF5ycFlTOQiQrGoEWStGNwyUGT3fARAghKRfapzLgpDCcwoSAbza5B+b MO0GSDu5VNCxTc2Cz7+tjTThlv0lG5uHw4jIco/jViuKYlGchsRLYkjTVoOYZFGDi/5JEsEe FoAs2Z7PFKcUmCZ3ScumV02tSjUnk6Ax/DGyE5y4eo+ikTmGo8w1oTxcQZkHtF/JUhS4Nc7+ CBNqhzjrlBQsIfcKo4DuYcRsm8DHDLXHv3QSqvCEWiELtCN2PGqpbx7rlw7Oa2eIYQxJ93g5 jFWEMwjx9HR6svM7z64HRmyGG8fIzmZ0Wd9ih33ekLhpTsALz2LCaEVFci18O9vvR3OLyoZ8 qO
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYrXv86BETBjNVqUiyAXoW2q4Ghq2p0CUA
- Thread-topic: [PATCH] config/x86: tidy {Free,Open}BSD LDFLAGS_DIRECT handling
On 11/08/2022 13:14, Jan Beulich wrote:
> It's not clear why for x86-64 a different approach was used than the
> (shorter) one x86-32 has been using. Move the LDFLAGS_DIRECT_*BSD
> setting to the respective OS files and reuse x86-32's approach for
> x86-64.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> I was actually inclined to go further and rename the variable(s) as
> well, to e.g. XEN_ELF_SUB_FLAVOR, at the same time eliminating the
> indirection via $(XEN_OS).
Yeah, that looks neater. My ack stands either way.
|
