[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/3] PCI: simplify (and thus correct) pci_get_pdev{,_by_domain}()
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Rahul Singh <Rahul.Singh@xxxxxxx>
- Date: Thu, 11 Aug 2022 16:15:36 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YmWPOcTyyFe8ypUr/fHSs5KlmXuh1gcUOk0+I3vMoPo=; b=MQGiaoIRPTD4BFXxPMG7ZO7P431xsNSRFPV8MeOq8SI48H6ipUwzmRc1G5SwAwiRZPe/kfykR0Yaz595lJEPRAnJzOvtlYlgDp+AwzJpdMDLuwWd2iGve0d4hPHFeckT+/eLjM3w/J9Cmr4mAJbsRQsYculthrtw6RcchzT2N8Wh3cnzwnsHGIUTjTkPBFOYdekbUPkOGPhMSwp+OE2T3PlXJS5rTBeCdOmrl+8cVi8fp3jVuezV2AXmUdxWvM+9sWhnE2yv8k07YGmDJd8CuUs7ncf2Epne5vIERTxdYDj6rcn8hYHOimoj02Pujfvw3JF6erd25ANRUWj9YE+S3Q==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YmWPOcTyyFe8ypUr/fHSs5KlmXuh1gcUOk0+I3vMoPo=; b=Su4EYR1IEvsKIi6EXW7wGolSLdr73HQJFHppRTGThr5/3oDKEjSus+mgVxtdF4XLtCCQAZfRwafTeYozNHJ83e1wGNvkqfUKF7xpDeV3gqVUASWxI3bTZq8WAbzrXteMPO3CH/vTqtgLszHh5ECkwhoeEbs/bFEWIyDSI9opgyvEATzHJZbpAOZDDgpH985av/FxXfuibbOdMWPsz3dv4L/tmQpriLEe8dz65zHUolrRrKZXJoO0ePXoAedeaYegxOSUMIpVBDUrno9o8n2n7YDGZuEsAhj9eBCyq5yAdufGzpscbpOINc+dSeRaxrg8B7EeqFvaiP+zZeG8W/xIPA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=bAZuHkTKWuXzp8xSGD8HLjcgztGI7z9WlLQESko7wYZsGmypsjT963FkGz44p51qWZX1hoPb+33rk/RaeLbWQmo9kiyktzGa9VVezQISTF5PDmMlGQ647HMi6MO8dOQHp9NYuMrurTn3SEcljk7YIuN6gvpDvGebleZmTFeQ/NaQfzvHmrFWBDcNCVL/W0S2VKPPyd8Z8FPO2BM53l3+Z1GMXtQG3OhvpcqGutfjO6wWGmMsdjbNNi7r3LmSAeBAMuq5haylLHayH2lzN0Dg/aXJaS8JMFIkwa7yvvP62fwAzoVxxwO5/IspPSlZYg9snt7j6nW85Ioug3zmISWOyA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IgbGTn7URAP9e7yxKI3TiXjIl/G3D5MCKd+UUo5HACfkE1SJ+zaa0loUbSAKn6GtkGj8VrZS37AABfV9vdQ2YZxgi8k7Ne4W7EkT2yIR1uof4Wn+ikfT+tFMTTMuCc1B3iLydam6wr58T4J45W0L6DN+7aHhukucC18/ZqqFyPeCMv+cZtluqe22lc05kFtqOskB1ot9Gfg2uJq7Jge01A18Z+gM0/2pMFWN0HlWUTEN2krW7FGF4d0SQmMd+BwOiGB5dXAE49R5fOmapfH2IbgEjjazfg/n4aj+YDefOPH4KbRHxraXdHgRK89Ggp8Iiwics+qYIhdrWo4R5MYZdg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Thu, 11 Aug 2022 16:15:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYrXBYbAi5RKJo+EWRwqCP3VXH1K2p4E0A
- Thread-topic: [PATCH v2 1/3] PCI: simplify (and thus correct) pci_get_pdev{,_by_domain}()
Hi Jan,
> On 11 Aug 2022, at 11:51 am, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> The last "wildcard" use of either function went away with f591755823a7
> ("IOMMU/PCI: don't let domain cleanup continue when device de-assignment
> failed"). Don't allow them to be called this way anymore. Besides
> simplifying the code this also fixes two bugs:
>
> 1) When seg != -1, the outer loops should have been terminated after the
> first iteration, or else a device with the same BDF but on another
> segment could be found / returned.
>
> Reported-by: Rahul Singh <rahul.singh@xxxxxxx>
>
> 2) When seg == -1 calling get_pseg() is bogus. The function (taking a
> u16) would look for segment 0xffff, which might exist. If it exists,
> we might then find / return a wrong device.
>
> In pci_get_pdev_by_domain() also switch from using the per-segment list
> to using the per-domain one, with the exception of the hardware domain
> (see the code comment there).
>
> While there also constify "pseg" and drop "pdev"'s already previously
> unnecessary initializer.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
I tested the patch series on ARM and it works as expected.
Reviewed-by: Rahul Singh <rahul.singh@xxxxxxx>
Tested-by: Rahul Singh <rahul.singh@xxxxxxx>
Regards,
Rahul
|
