[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/3] PCI: fold pci_get_pdev{,_by_domain}()
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Rahul Singh <Rahul.Singh@xxxxxxx>
- Date: Thu, 11 Aug 2022 16:17:35 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jBz8oskOKNg4uyTxzLL9dteX8kqrlFfIJsinpsinzI0=; b=GWNsJq00cePFJTlKjqEcPWoPJYAxjKuVN+0xiQVh6hn4pikev2eNqHZ+zJ5wTTdyT3z8j+qU1U3Ih67Je3sTCIbz0O3qIsyuuwQonBqiv3Vei6YIq/Nj1kfdftPuNW7b4bpevxB2VsvUAoTcge9QR7aOrsWkBf6szmGbp7yyU+QQkAKClYxgdn1W22w31DbckNlfJ7cnfwhEet1jYtETXAlqzn0Y2CblzjnMK+uYIZMxv15iKOGn9s8euVyTyDA6aZ/jRFv3p18lA0jLou8yZiCxxfsMFga34afNO/EAmO6OK2IESRy+9FUPfZuN465iH7DN1/F/9WBZKNy+Cmo5hw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jBz8oskOKNg4uyTxzLL9dteX8kqrlFfIJsinpsinzI0=; b=WGiiCeNa2Gtu3qQl0c5Tp34oKVLegKyDrQmqQjDnBLXzPDa8A5QrS9x5qDz6HIIDa0LYlmyUO1XpNUO7Mr4GFEukps6MLFnxtH7PKmWwNga7KPAEQ3xsC0wzAlzNnSA9dQvfuOcqeh6Q0WrOWD4uyev31guubF+h+4Y5KSAru9C2sQZCxkN/jNYn6IDAvWdXzWPmnNVBcVDnTJ62O5x9SNqPY4+RUj+6j55+1kDlwWeuUOQUkW7KSABuCtP4mWuplCqXeQmGx5w+XU+w4fpsx5PtR7OmbC9loeezoL9OTxSvanInhazD1KZViZlPTKi97+LOZaDsuKVPgkyht3A35w==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=MSsLjl9COMfoVMMwoIIyB/kuRoahyZP2SXXnXY2eLeOVoK+c8ocSho6laXv1KVjjVhhR0ahjsGlL/x3SUtNLTzpv/DZznUZaOaEgekrsQT5YB9EIfZMlqYnjvXqsQPBbYJerAi57BdW0EiWx6B7X1k7G2K3iw/wYMz/EeANzghqyDCRe0pRVvPV3sde0c9je25Z6qeE1hPYv6G8P9pYKLpucN8eETr446Rrkxpp7KxzDg342Cf74mxibWapSZHawiwEY7DetM90tgkv8lSTVNe12irHNXBuiqkK0+RAoz4TVqVfY6WuDb9Q73HKBJq7/xHzbJd82fKn//X8R7M7ZYA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GxH7JE9wYb2Mx5q6sxz74FCrnGSN16VMeNV77FIJw6VjA3mwgiUDRAmJ6YNs371ThENRh+0POGwng7N/2/R/6m/yl9ucIDY2TwcmztKXIyZyZVU5m1KkfXbPBc68YjQ7B2I7Tv6xxYvX85G0muITZkiB+cDTtOoOGIurJgGYp1I9pVMaI/PGmFZxrv80I1U+Pp5aarKRg9vbzE38nuwUgxik1NJyG/Ekp8tqkg2nTuJUse85hs8D7KjOn3AXGa7awrj9T8tbqIRhZu9bya8ahEGcgMV2XxHi8SspdrNDUrBOA3iDCXiwdsmiseLyAwL2HWkrvODeDmw+L9KGZWking==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Thu, 11 Aug 2022 16:18:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYrXBoGW5nDLcLl06N/ag9xMtlQK2p4NqA
- Thread-topic: [PATCH v2 2/3] PCI: fold pci_get_pdev{,_by_domain}()
Hi Jan,
> On 11 Aug 2022, at 11:52 am, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> Rename the latter, subsuming the functionality of the former when passed
> NULL as first argument.
>
> Since this requires touching all call sites anyway, take the opportunity
> and fold the remaining three parameters into a single pci_sbdf_t one.
>
> No functional change intended. In particular the locking related
> assertion needs to continue to be kept silent when a non-NULL domain
> pointer is passed - both vpci_read() and vpci_write() call the function
> without holding the lock (adding respective locking to vPCI [or finding
> an alternative to doing so] is the topic of a separate series).
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Rahul Singh <rahul.singh@xxxxxxx>
Tested-by: Rahul Singh <rahul.singh@xxxxxxx>
Regards,
Rahul
|
