[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/3] x86/build: Don't convert boot/{cmdline,head}.bin back to .S
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 12 Aug 2022 15:26:53 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U8F8RJD9OBdZyvfAHhN85Uzi/hqo9sT9HDXI3nP7soU=; b=KViE3Otw0LwqLhN4y+LWAJ6J+9g7ZsJVWFsl/3+yqyzUE28vMQxIA3OQE74eQEbzTRK2x+k3zjjgFUVWDqWMM4A0S2HGhDUFlMWuYCMoxquVMY+VLGw+mMCHyyxWAjDNCj4RoQCwH/a9dDLEipHCfjiGMTKj2jQRO984z7SHjIxifKwRjZiHxwDOgDhBpbCuUm+HB7tDH9ncs0oy4ZD46u0bQHeZ95ACJId/dbNgAsP+1YW7btG61CjavEOMmDbPWPobtL8TlQv+Uxq61UUmq0YK+Sgl9Dt0sMj/RptgFBUEI3AYJwldPCIaipE4FjbrvlT0wWqRzi6hxvLChN+LoA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SxNS3mIQzi1cZKBXdc7Ka9Xg3mlX8cTwYwjJ9KnWgRM9nYAyBeAd25K4ncz0UfROKjqi6wae/x0jY+Qfg9ZE/5vlQ7eo6o80wg79sfqaXlv6JjRK8BVOvcTRPfo9GfCqhCmZTXRqPdtAb66QQhjzU4kk6gj1B5Eid41zvd7yh21NEyJXV4OM5JVP4ETbwZfH1D8h7+eaaCN/Fz02HqS/IIuTO2Lwj4z6M9BeUp9dDjRZkdJYjl55f6n6zxIP1Jn4DlORSItsWAnNwtEqauNl7sLUwGGM02Ac5WVF/uvHfrt7MAQioXsVD9f+l48l1+DEKucefNzRQwFbVTfOZCWe0g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 12 Aug 2022 13:27:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 12.08.2022 14:55, Andrew Cooper wrote:
> There's no point wasting time converting binaries back to asm source. Just
> use .incbin directly. Explain in head.S what these binaries are.
>
> Also, explicitly align the blobs. They contain 4-byte objects, and happen to
> be 4-byte aligned currently because of the position of `lret` and the size of
> cmdline.S but this is incredibly fragile.
>
> No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
|
