[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/7] xen/arm32: head: Move earlyprintk messages to .rodata.str
- To: Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 15 Aug 2022 08:43:34 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+gyH+t8kQ0tvFMhuleT/TOmVXvLCOykUtxmLXyht570=; b=FbSBCWdy02MDGQ2cYjufhRi90l8j8wVRnYSRAKz0tPf5wjLWaYfxWFuZCoqzfZ1gMGiVs4SGCmODkmSjKe9etkNlY7LJq8DUhY4elOqvZet/yKzrhkbVN1K6b27e8F/wVkHm70Z4xqrqLB4wWjLWQCHv9XNCZ+dUOzmz4AytrmX4YCKbbO5fy3AEy6vV0rdaA558rHQh3AFvVX6SWZ9JCcQHS2/p/VXpeZ5wclywTD6d0VCKGLEKJquQ8tiJdU7uguKqw2kKzMtEA3+xLnm/6Q6LTeNxhZqCRRQCKy3wFKijFtw3agfmzqskiQv+KMd8OZW4xUSvuHV2Btyx9Fb/EA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JL1T0GSkJzpZlwe90QkgULDa9X6bVPiurxwuiqLjh/f2Zs4cUi98luYqvOrly/xhrosMsjcbSo0jQcPxXNB8mJX+ERiNiWl4PWTwljPNtN2HCCIVIAUlXipkXrxI5gkw5WtmR2SP0MlBde0zvSu8rJNgZnisi+TNTqEd7HXsD/FOGo0gj8QY00K/0X+2Fan9ZAT9cy/vzaFdRnVKHBpQOUIBFNT4YkFgpYcTVVI1K69h5N9oRYVdUgz02+HzdJQccPaBgqs6Ua1BtOsWBG+zNZNn+DTMrEpStRCG0ToL1g6Ob95OTxmf7vUi+4OpsJsEpDdczr4FwhLNYMuJnhyuGQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 15 Aug 2022 06:43:58 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 12.08.2022 21:24, Julien Grall wrote:
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> At the moment, the strings are in text right after each use because
> the instruction 'adr' has specific requirement on the location
> and the compiler will forbid cross section label.
>
> The macro 'adr_l' was recently reworked so the caller doesn't need
> to know whether the MMU is on. This makes it easier to use where
> instructions can be run in both context.
>
> This also means that the strings don't need to be part of .text
> anymore. So move them to .rodata.str.
Wouldn't they better live somewhere in .init* ?
> --- a/xen/arch/arm/arm32/head.S
> +++ b/xen/arch/arm/arm32/head.S
> @@ -93,13 +93,10 @@
> */
> #define PRINT(_s) \
> mov r3, lr ;\
> - adr r0, 98f ;\
> + adr_l r0, 98f ;\
> bl puts ;\
> mov lr, r3 ;\
> - b 99f ;\
> -98: .asciz _s ;\
> - .align 2 ;\
> -99:
> + RODATA_STR(98, _s)
Nit: How about using uniform indentation here and ...
> @@ -736,7 +733,7 @@ ENDPROC(puts)
> * Clobbers r0-r3
> */
> putn:
> - adr r1, hex
> + adr_l r1, hex
> mov r3, #8
> 1:
> early_uart_ready r11, r2
> @@ -749,8 +746,7 @@ putn:
> mov pc, lr
> ENDPROC(putn)
>
> -hex: .ascii "0123456789abcdef"
> - .align 2
> +RODATA_STR(hex, "0123456789abcdef")
... here?
Jan
|
