[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 0/3] amd/msr: implement MSR_VIRT_SPEC_CTRL for HVM guests


  • To: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • Date: Mon, 15 Aug 2022 08:15:12 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E5wVteDfW/dWh22+9mUFG7jkgM81Fx1dz52uxY86x7U=; b=claWVyNcHN/GUtzJwp1+AMLfro9HX9eNUFquxz/5jMSm1mpwwvwWTwJ+Qlp6m6B91ZXN7dGCSytpqBxOX9hZalgbOgIMROGbvi+GOakNrpxCXycn4CMd9rj8+HZtLxfkSHUvErLg89Z+NouXv8LF9ieZ77dTGkrJjYEply6xRdWJkm12vhdhsmgZsMWBqJrIkScu6GrNSURJWkTPd0E0Vy8BGCM0ig40BOdOvUYGAys/FVoLgFIpfyf9TOz36M4AcNi+gulc0xeCfZrI5NNXTUPwJfyZhpByoYOaA3Y0K+qy77ZULTEOkB6bEN37WSkIqufTxV/q8e0Z1ij/6143Xw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g8p209n2WpSW80eygiAtK53GYG4KNYJTftq8ftq/MKX/lyHQlnHHqxYa5B7JN7vQlUWWC9WUS1axXHr1Yxwwefi85bUVJ2kSJCmVW7tp1sZfwCGD46V/b50bbgWt3ouoZDt0Mvv/aRkuhErYMmUMkJJZ6I5nPeY+O/WZb4vNb+JvhZIJjCQGGp2T1VKhsPlFsTk8R7M2fPA6ETB9M31jLunhQUElzQHEkUbRrfSUSiknpHAe7kPmzBr1o7l30MyE7mO60bXMFziA7F5+Fu+1Ekf2HYNSypf4J/Mya5kdEx2Cp9QlNaAutV2LEltjHSFPEO1ikNWIuniM0nlHjXtggA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Wei Liu <wl@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, Community Manager <community.manager@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 15 Aug 2022 08:16:02 +0000
  • Ironport-data: A9a23:6raEvaL1qgxM3jdNFE+RBpQlxSXFcZb7ZxGr2PjKsXjdYENS0jJTz DMeC2+PM/eCYDbyeI91aInn9h9U65HUy4VgGQRlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vraP65xZVF/fngbqLmD+LZMTxGSwZhSSMw4TpugOd8iYNz6TSDK1rlV eja/ouOYzdJ5xYuajhOs/La9Es21BjPkGhwUmIWNKgjUGD2zxH5PLpHTYmtIn3xRJVjH+LSb 44vG5ngows1Vz90Yj+Uuu6Tnn8iG9Y+DiDX4pZiYICwgwAqm8AH+v1T2Mzwy6tgo27hc9hZk L2hvHErIOsjFvWkdO81C3G0H8ziVEHvFXCuzXWX6KSuI0P6n3TE7qpzFkYPHIsjp8F4UEBk1 eERNwARR0XW7w626OrTpuhEoO0GdZCuF6RG/3ZqwHfeEOosRo3FT+PS/9hE0Twsh8dIW/HDe 84ebjkpZxPFC/FNEg5PVNRiw6H12D+mLW0wRFG9/MLb50D6ygBr3aerG93SYtGQHu1en1qCp 3KA9GP8av0fHIPAmWbfrC/z7gPJtS3RYaM4LbmmzdUp33mq31MrExc7D0Tu9JFVjWb7AbqzM Xc8+CAjsKwz/0yDVcTmUluzp3vslgEYc8pdFas98g7l4orZ5RyIQFcNSDFpYcYj8sQxQFQC3 ViMms7vBCB+9ricT3uS+628vT60ITISL2IJeWkDVwRty8nupsQ/gwzCSv5nEbWplZvlFDfo2 TeIoSMiwbIJgqY2O76T+FnGh3enocHPRwtsvwHPBDv7vkV+eZKvYJGu5R7D9/FcIY2FT16H+ n8Zh8yZ6+NIBpaI/MCQfNgw8HiSz67tGFXhbZRHRPHNKxzFF6afQL1t
  • Ironport-hdrordr: A9a23:QE5vZ6pc6I6s7eLf2ePXg30aV5rReYIsimQD101hICG9Evb0qy lhppQmPH7P+VIssRQb8+xoV5PufZqxz/BICOoqTNKftWvdyQiVxehZhOOP/9SJIUbDH4VmpM VdmsZFaeEZDTJB/LvHCAvTKadd/DFQmprY+ts3zB1WPH9Xg7kL1XYfNu4CeHcGPzWvA/ACZf yhz/sCnRWMU1INYP+2A3EUNtKz3eEixPrdEGc77wdM0nj3sQ+V
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHYagMx4yaKKSDaVEqrb6mC4jE4eK2wJomAgAADuAA=
  • Thread-topic: [PATCH v6 0/3] amd/msr: implement MSR_VIRT_SPEC_CTRL for HVM guests

On 15/08/2022 09:01, Jan Beulich wrote:
> On 17.05.2022 17:31, Roger Pau Monne wrote:
>> Roger Pau Monne (3):
>>   amd/msr: implement VIRT_SPEC_CTRL for HVM guests on top of SPEC_CTRL
>>   amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests
>>   amd/msr: implement VIRT_SPEC_CTRL for HVM guests using legacy SSBD
> I came to realize that I had announced that I would commit this about a
> month ago. I've done so now, but there was quite a bit of re-basing
> necessary, to a fair degree because of this delay that I did introduce
> by oversight. I hope I didn't screw up anywhere.

Revert them, or I will.

There has not been adequate review or testing.

Patch 2 in particular is firmly nacked, because the only thing I have
ever suggested in that area is deleting the patch.

~Andrew

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.