Xen project Mailing List

Re: [XEN PATCH v4 21/32] tools: Remove -Werror everywhere else

To: Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx

From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>

Date: Mon, 15 Aug 2022 07:34:59 -0400

Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>

Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660563383; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=sydKm57zQ1MrCdXRUQUN5smgdD0KlEnUS0QeYB/s2r0=; b=DEMwth6obuB6oUoBhtJCAjZ0PMMcD0kyj7XlBBETe26e5UpB34dBNm9HMRvA4lGZBFYgOpipTkTSCZqXR/TDwp5/ll31sr3bk5bpaHIR+Qe0W5D2ALo8uX8LnVvefGMDPIG1bvXdgKeuTMHmG3ve7NGxvLP4+Epu5W9uSAEjhcw=

Arc-seal: i=1; a=rsa-sha256; t=1660563383; cv=none; d=zohomail.com; s=zohoarc; b=hy11SL8CFRDbx1px1jS1qbtXN6nh8UhIeyuney7Apl9KTAoHl0ub/7n+3qVOvKK/GZCp9KyM1JsD8ikRj8TdmD4Qvh9LnXTOH9La/S/8W7n1IFC9vgYaFhhyjlADUf+lZbXCkpImXzhvkhVIN/7RYt9ciF4VTSGP2DKtsZzxpac=

Cc: Christian Lindig <christian.lindig@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Elena Ufimtseva <elena.ufimtseva@xxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, David Scott <dave@xxxxxxxxxx>

Delivery-date: Mon, 15 Aug 2022 11:36:44 +0000

List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 8/11/22 12:48, Anthony PERARD wrote:

Patch "tools: Add -Werror by default to all tools/" have added
"-Werror" to CFLAGS in tools/Rules.mk, remove it from every other
makefiles as it is now duplicated.

Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Acked-by: Christian Lindig <christian.lindig@xxxxxxxxxx>
---
  tools/console/client/Makefile   | 1 -
  tools/console/daemon/Makefile   | 1 -
  tools/debugger/kdd/Makefile     | 1 -
  tools/flask/utils/Makefile      | 1 -
  tools/fuzz/cpu-policy/Makefile  | 2 +-
  tools/misc/Makefile             | 1 -
  tools/tests/cpu-policy/Makefile | 2 +-
  tools/tests/depriv/Makefile     | 2 +-
  tools/tests/resource/Makefile   | 1 -
  tools/tests/tsx/Makefile        | 1 -
  tools/tests/xenstore/Makefile   | 1 -
  tools/xcutils/Makefile          | 2 --
  tools/xenmon/Makefile           | 1 -
  tools/xenpaging/Makefile        | 1 -
  tools/xenpmd/Makefile           | 1 -
  tools/xentop/Makefile           | 2 +-
  tools/xentrace/Makefile         | 2 --
  tools/xl/Makefile               | 2 +-
  tools/debugger/gdbsx/Rules.mk   | 2 +-
  tools/firmware/Rules.mk         | 2 --
  tools/libfsimage/common.mk      | 2 +-
  tools/libs/libs.mk              | 2 +-
  tools/ocaml/common.make         | 2 +-
  tools/xenstore/Makefile.common  | 1 -
  24 files changed, 9 insertions(+), 27 deletions(-)

...

diff --git a/tools/flask/utils/Makefile b/tools/flask/utils/Makefile
index 6be134142a..88d7edb6b1 100644
--- a/tools/flask/utils/Makefile
+++ b/tools/flask/utils/Makefile
@@ -1,7 +1,6 @@
  XEN_ROOT=$(CURDIR)/../../..
  include $(XEN_ROOT)/tools/Rules.mk

-CFLAGS += -Werror

  CFLAGS += $(CFLAGS_libxenctrl)

TARGETS := flask-loadpolicy flask-setenforce flask-getenforce flask-label-pci flask-get-bool flask-set-bool

Acked-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.