[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 02/13] cpufreq: Add perf_freq to cpuinfo


  • To: Jason Andryuk <jandryuk@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 15 Aug 2022 16:29:32 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cJUoXJ41Afn2/8h4zn4mXfQEV1+R1WAZ6DMSzZL2u+s=; b=Vbxz8IzMOPeoAwvS1i3/QdnCk2HYiPNBVEo152W8CWgXgnh4fiqgGeWoPWlBHrGGFKtdz208h8CozhK8Yux5Hf9wKbW3CW/Weu+BMdl0RXNZO+ldZ5fg5PyWv2tu0s5aVGWTm49pHXLqlxG9oXhQnao5Gk47+fP4oUv5hogys/fsJQDu9s9bKr/flgdX2V+VrFNgeHOS7zEzM4cYcc89Zw6XCh3vtgrZCFRfiGO5OE6ypH8CSOaAd+U/M5sLn1E2I4TGJr8ssa72vanKj6pE0WpVCyCygrfsaSuenA7Q7uohyMZUPqULuqiGA2h0SOdklBVc/bDmh3R4W2QcKaGY+g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M4nq/ZorM0s4NcGifkYeVtZk+zCTFslPIyJbZoJsWs35zKyay4NtQRyrQAkfN1XzPFRHoBMqpTQmSGkGYhUFRkMjmaktEtXNbo0i09Gncpwuw62O9TwyTnGLyte8VS/KI1VuJJ4WJgsnpnLUq0N/sqaO16RMiN5wjCJYyj6vXy8pw3g8dU30VO85MgprdW3xIJ+tMe0Z8WkeY3h2G+wS43oex/cnzJrtYyYqjtVw0OQpArcMvocJS7gEBrRP87hlAyNL750kRnwdRMXL/xQAzNuEFO/X+S5J5t6FZu7BX0EbLNvpP/BYZYMo5v4gcGuetxJEDI/Gp99xakoiVrUyTQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 15 Aug 2022 14:29:40 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 10.08.2022 21:29, Jason Andryuk wrote:
> acpi-cpufreq scales the aperf/mperf measurements by max_freq, but HWP
> needs to scale by base frequency.  Settings max_freq to base_freq
> "works" but the code is not obvious, and returning values to userspace
> is tricky.  Add an additonal perf_freq member which is used for scaling
> aperf/mperf measurements.
> 
> Signed-off-by: Jason Andryuk <jandryuk@xxxxxxxxx>
> ---
> I don't like this, but it seems the best way to re-use the common
> aperf/mperf code.  The other option would be to add wrappers that then
> do the acpi vs. hwp scaling.

I think that's okay-ish, so
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.