[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 03/13] cpufreq: Export intel_feature_detect
- To: Jason Andryuk <jandryuk@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 15 Aug 2022 17:23:24 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U6DATZEZ/WLJuwqXpjASVnD/jHlyJDpbHIRntJX3p/g=; b=QJNBQaZaCU+Uuq8m1HCEBZ3JChWaIX51+Ijtd5tQrE+OJW+HySs9SFcf9BMc+2TNGX8y0ABYkd0WJcqcby4hTngmhQURR7B9XOAEZHGWYrGzPZ7VG57RSpl1XlY+JFAXjZXMcrIWbAn2fVTdYkwrQHpvG6XiM9JGzMdnJIX+451g14cV2Rt7wMR0N0dEl3xd+WiKhVvfXtFiYXW1xr8+y1xDUjv2CqK9yZH9AxwZAa6+8WI6cmNgpYAP22mApypfIl9pFoum56GsWW7zpj7wk33So/6MUOf7jMoZN9verrvG9L2qHce9KTGPdq7jM/06seufT5pxRV+n3l5BPti1FA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZUyzhvgrLjVDmJKnOpS9Kh+vsWYCG+utjqMIiVvH3kwh5yj34zeBgYAqPo/iG7tT4DKJTzXiOGkMwu1gD06VBSRHJb9q5kyHrgLFRTBJJxP7sPyvkmrLKh0SnbL8CEl4RCS6AlhpN3g880V8BxQs9IePFKBj5u8usvs/HTrnUWZ3bLZIn+Xxsao+bPSebAmB1vXvfSijQJX4bx+bQYksF+2lm4w5F4Gmggj/YIk9MNQ5u4yEeQ+p9spPwsNO63KdwL5PX3Mg9/PaX0X3Slraq09MnxsY/1QSnAdjWlRfofujuo5x0rV3O1++YgG2Q1DMsEVxpuictxSDjKQcqOqEDQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 15 Aug 2022 15:23:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 15.08.2022 16:58, Jason Andryuk wrote:
> On Mon, Aug 15, 2022 at 10:34 AM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>
>> On 10.08.2022 21:29, Jason Andryuk wrote:
>>> Export feature_detect as intel_feature_detect so it can be re-used by
>>> HWP.
>>>
>>> Signed-off-by: Jason Andryuk <jandryuk@xxxxxxxxx>
>>> ---
>>> v2
>>> export intel_feature_detect with typed pointer
>>> Move intel_feature_detect to acpi/cpufreq/cpufreq.h since the
>>> declaration now contains struct cpufreq_policy *.
>>
>> I don't mind the new placement, but I don't follow the reasoning.
>
> v1 added
> void intel_feature_detect(void *info);
> to acpi/cpufreq/processor_perf.h
>
> v2 adds
> void intel_feature_detect(struct cpufreq_policy *policy)
> to acpi/cpufreq/cpufreq.h, which was selected to have the type available.
But you don't need the type to be available just for a function
declaration. For such a purpose a forward decl of the struct is
sufficient. Anyway - not an issue here.
Jan
|
