[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 6/7] xen/arm: Tweak the dump page-table walk output
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Mon, 15 Aug 2022 16:12:48 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zLjzj+P0SSvc2QVxwimUuoqsu/cLdbLeS9hyfM5SieE=; b=gCsaRImJemPftVePqp9BNAbYvVHz15515Sl1zjzvUtR8vgVpuiFrQcjPU4wpqtSAxCVZm7xRgI59V2JuLICzwHMZhrJ53L7TuON04aykX3pDk+W4dCIlWnFYyzLZP9xacCI0SVohU1JVaEsb4geDAWrAc963o+kEfpWysPekPtTouXMzXaetXuuP4YQHMoisU5rxu9Ey+REsh2s1nyxeL3fK1jc9NYpUOqXPws6DrB7f+zrlVELNoZgvk/9cd76VSTAc5hNltLHZhJ791hqmW6qcsHpnh0VwVVFMfNUPn3dfhLjvxqwjaRmQGpfF8dsW7ucTtNcP0kkuVdCOWlyxJw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zLjzj+P0SSvc2QVxwimUuoqsu/cLdbLeS9hyfM5SieE=; b=eZwU174LnPPjdr79biLY0NJmdusQBfQ6vBMl6/gTNXIBONDmBul1ha8vQ0X2F+GLR9hIS/CpAELvctrLOBi3JHfj/83BPoLbklCa51PomNnuwlU9x0xbZBK0YTPLiP0cVI9F5Im1VksgiRHsB6wyGR+BkoPsJX7qYehYNnYsx1A9emWDTduftqIUEGJxva5YoQZpL1kyozOFCrIk0MxtYna7rLCCcFnK33dD4z+dIcFGa8fmoBDDUNCyUxsPP59t8QMZrnntufkcqk0Xb3FpYys7zq4H6q8gavfopvFxc+t4m2XN8JnKEI+ga8Sdnkn4xrmUlZ36qj64JGAlY/zbGA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=kMnGMvFydj6MAQkHbAa5zpXReJX7fbmjVjAmvzDmaBrqzAbJSJizqMu7IElG7h7t0k4WO4CEL5iviZx6DpniEqoqhoEbqw6PEX/3a3Pwr0fGmb6DO/UKU3T27NHlXWNW7pKSW0fsqRdqMLoIoWai/5FU4bOr67TE6xBncTWX6MJzS3Xj7jVImbVBkzC8jqCvQ9W2bT3AhyFb4eIr9fPCIlSRYcCiUj6kI9z0Px5KwTlMP2eN3yXKh64IV6/luCGhx1PYT4pbqJW1Lt/Ph/fUZgrf8Uoz+M7tvMBXVtAh8XxDp7NCA/cX+TDue0cGWZ5jpVYMo2N43185lLSAJ8pD4A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=egTxF5RLLNFl/uHdTAnCFPzFoD3No7JIL7pr7Kcmq5yGIgDDr4+17TW5/4ySwezjC5v4e2db6tWccqWKsZHxwKvTFhLbZTxlcwRVJV7wq7zaNuVH8HzbUvu2LE9J7xalNg9IITGB1kB9xT/Db3qlYOpKvxGze/G9z0Xff+9CDYkIpTHRV2au8/0SvCkS1w/1vgyyxOyZU2i2b3+MLbMPfnl43ClC0nKiI8VTLvn4Zc4FpzfWfa0zaZevh7v94R+kcIRgS6RfyrBsd337G0IvY+evqa5Z7Ielp7ISU4SXmVK2lYezo4JMnj2U1WxXqXN7ijvqkosZ1yMpOxShJlxUZQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 15 Aug 2022 16:13:07 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYroFFaGbMXO0OOk6jmUdl8jgLY62wJrWA
- Thread-topic: [PATCH 6/7] xen/arm: Tweak the dump page-table walk output
Hi Julien,
> On 12 Aug 2022, at 20:24, Julien Grall <julien@xxxxxxx> wrote:
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> Currently the output is looking like:
>
> (XEN) 1ST[0x1] = 0x000000004015ff7f
> (XEN) 2ND[0x1f] = 0x00500000bfe00f7d
>
> The content of the entries are not aligned making a bit trickier to
> read (I appreciate this is a matter of taste).
>
> Align the values by forcing the index to be always printed using
> 3 characters (enough to cover 512 in hexadecimal).
>
> New output:
>
> (XEN) 1ST[0x001] = 0x000000004015ff7f
> (XEN) 2ND[0x01f] = 0x00500000bfe00f7d
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
> ---
> xen/arch/arm/mm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index b42cddb1b446..c81c706c8b23 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -234,7 +234,7 @@ void dump_pt_walk(paddr_t ttbr, paddr_t addr,
>
> pte = mapping[offsets[level]];
>
> - printk("%s[0x%x] = 0x%"PRIpaddr"\n",
> + printk("%s[0x%03x] = 0x%"PRIpaddr"\n",
> level_strs[level], offsets[level], pte.bits);
>
> if ( level == 3 || !pte.walk.valid || !pte.walk.table )
> --
> 2.37.1
>
|
