[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 7/7] xen/arm32: traps: Dump more information for hypervisor data abort
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Mon, 15 Aug 2022 16:39:08 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tfpsNsjbhbCj+pcx7fX0GODGxtw9mPwYtLwvKAQNYXU=; b=INhLTz9ZlUYdvBVkW6GNXPUxqV0Jq/ObyIBCAgKkKRDHDVsS3hje06s44yUzgJHWDgX8otLMIhpuVpW5AjQc7J9ypsygt80YOQx4t19gwBZEW3fiIgBjnms42fHkLSJxGt+6vSHFXyFLs0IE+6+qZC4XQACGNHihA67jTAKRkL8nZnh17Eqr8iiuNpkT8L9BWWt4toomhKekYrGiRQ5R0oyply+Fn01aGwOVIlxrDPg4px6ju78zuw+rEZGJ1bwi8u5r97TgUolS8yWveBm10stFL4HgcL1pOL7qJ8tUs58f9Vl5tQafBIAd8wVwZzB2XKKKho4c3jPoB7qs5ZUdnw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tfpsNsjbhbCj+pcx7fX0GODGxtw9mPwYtLwvKAQNYXU=; b=C068Ui2klDLdFvjynAp3qL7PCY6UMM87yS/tOLPj1Sln05+YQ/bUuBciws0Orm0HrO8oFcMfzSCT1LYI+emV0/Ai/8QHJqDpSSC37V+7+53+0EdS8GJt3C9PqBW5e6rkqqO267h6YwlgibQm2q43MOL7jpzrXBt+h059mF6DvhSoPW5/LAbemMZjsua+GQ+uW/auDOUuyS0Egvg1AZSKxClrqcETCoJibeWkkrVTAXe5zVC19JKFLebHpL1kk/uGVtL8wJvhj4u2xnkGZxnDPSSpX/6gOg4uOw3m10lxBOv4xrCsSRRzpppTJ74nWvN59hy9s4lJ67Q0FhxKqCoCVA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=LkD98OvCQoY1eFTot7e9DgXK+ezwKQWQjxBnEs/0L5+AzASHMvIa5DGOZjvw8oiGuQgiHkmvEW2UsYwJK+8VoWgndiyHtYp6G8Ax8Vdjjh/ub0552xzr70I40Uk5aE8HqpB+w16v2SdNH3TrBpfdtjkGotZ1fD84kx06skQ2qPhxENpuL9FI8zztz3fV06ecJkYFpQQOJ0jqN+v0s3lCiwE9nyivh9fu7y03luKCIPYMHvmRft8yerfTuN78UZ1IYkZf3yMFBb8v77YAiVyczpPWlu+YFC88cyTk4KdCzMfN3XYj1SwNQH/XKhcW2Pw2RciwDSXInhpZ1F+vY57KDg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ltdek6maqaWyY5E5lt4rjQ+I5qdaol6JJLb4X2/I3GYa0JPz9UdhwongM4d9leJiPDcH734YBPdlwkVqeNGnyf6vpsKzlQcvkESfWCLsq0CHJnXDP0YxHt6+sIHliOKmZDVJQ9Wms6GFDASo1Uu+KQlsbIiEQUcCp/+8wd8hHE0yWsAUPkQjtaqzvaZC6NdhLbsI27pRSY8WE3DfxEkfAV9/rBtZLa6xgiDrZIZObnTuI9Cw2P/wMCsMC7R2HqYamtScF/JRDgFzkqgxQvwQgZzjIFMbXxLw4F8PLb5pXBnyF0pSLaepMhb+9NCyFP2enzBx+adcLCHBPKtq7z8acQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 15 Aug 2022 16:39:35 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYroFFG1SBMYgirU+4BTxPWgpRqa2wLhCA
- Thread-topic: [PATCH 7/7] xen/arm32: traps: Dump more information for hypervisor data abort
Hi Julien,
> On 12 Aug 2022, at 20:24, Julien Grall <julien@xxxxxxx> wrote:
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> Unlike arm64, on arm32 there are no extra information dumped (e.g.
> page table walk) for hypervisor data abort.
The code in arch/arm/traps.c has nothing arm32 specific like that so
could you explain this statement ?
Here the arm32 code will call the generic function which has only
something specific for BRK handling but the rest is generic.
>
> For data abort, the HSR will be set properly and so replace the call
> to do_unexpected_trap() with do_trap_hyp_sync() to dispatch the error.
I agree with that, I just do not understand your previous statement here.
Cheers
Bertrand
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> ---
> xen/arch/arm/arm32/traps.c | 2 +-
> xen/arch/arm/include/asm/traps.h | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/arm32/traps.c b/xen/arch/arm/arm32/traps.c
> index a4ce2b92d904..a2fc1c22cbc9 100644
> --- a/xen/arch/arm/arm32/traps.c
> +++ b/xen/arch/arm/arm32/traps.c
> @@ -81,7 +81,7 @@ void do_trap_data_abort(struct cpu_user_regs *regs)
> if ( VABORT_GEN_BY_GUEST(regs) )
> do_trap_guest_serror(regs);
> else
> - do_unexpected_trap("Data Abort", regs);
> + do_trap_hyp_sync(regs);
> }
>
> void finalize_instr_emulation(const struct instr_details *instr)
> diff --git a/xen/arch/arm/include/asm/traps.h
> b/xen/arch/arm/include/asm/traps.h
> index 08bc0b484c75..883dae368eac 100644
> --- a/xen/arch/arm/include/asm/traps.h
> +++ b/xen/arch/arm/include/asm/traps.h
> @@ -73,6 +73,7 @@ int do_bug_frame(const struct cpu_user_regs *regs, vaddr_t
> pc);
>
> void noreturn do_unexpected_trap(const char *msg,
> const struct cpu_user_regs *regs);
> +void do_trap_hyp_sync(struct cpu_user_regs *regs);
>
> /* Functions for pending virtual abort checking window. */
> void abort_guest_exit_start(void);
> --
> 2.37.1
>
|
