[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/entry: fix entry_INT80_compat for Xen PV guests
- To: Juergen Gross <jgross@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 16 Aug 2022 09:48:09 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UJqymMDKp7KAlg5ez9bNluzviYjMIjegjNZ0iC38OBc=; b=msFF6F4NhQFaXI864rbZ/fqBEo1cv1VQsdZ8SDU+5A+J2YP5Wm8GAWNnB5O4hvmw5OXdwLakFf4+A4E78U4x4oo3AT3KSpk/JbdGZsOUBUCcKDXrhBGRODiBwWtqJDD7xw58Xecn+C7h6cfNRLcpiE03QQBcM4oQ/1zsSEVzoG1MtuH8nRIk15zHbSV10itkNYjJ/hrTywQI5QKKXMyp+exmcfPEHpwd1O7nUyUDmWE8R172eifBB1W4pG5geqoFxz+9p4cPyNsK5xVT6vDhPBzK7/injtc6WO5qP9ZKy56VNSygcjePJv7WqaTpDj3HZrYsFRsNrEhhLYJLP1IKDg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XeaEjy7G5S6qYXqW1CWdpWySaZW2leshRGxAUKdPYZIWPIHrRtmMdAjU1kiwzRWu+yALSRHSo8R6J5r3FWLFWKLq2lcmzKDP9GjitVsoWC9X0jvC6Jt0xVxYM1qL/Ow9NCXYmRvRRpRBGI4oN7z4jWh53g8PGrhoYD1wgb/fQRAJ3S1GHR3OzAfS9B8Uma3OZ8o3/jyR+0L+5ExJH6RO10ls+XgXpX6pOaD1/UuHE+7NukRnCNggf/1gpFIecN78whwFBENbTChUkYc+T4sUhhG6cygqul/cjsNTDbctMOj44P3Glw/InQyErojNgMV2YKdtV9CUsvNkYbYLGXZDMw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andy Lutomirski <luto@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, stable@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, x86@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- Delivery-date: Tue, 16 Aug 2022 07:48:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16.08.2022 09:11, Juergen Gross wrote:
> Commit c89191ce67ef ("x86/entry: Convert SWAPGS to swapgs and remove
> the definition of SWAPGS") missed one use case of SWAPGS in
> entry_INT80_compat. Removing of the SWAPGS macro led to asm just
> using "swapgs", as it is accepting instructions in capital letters,
> too.
>
> This in turn leads to splats in Xen PV guests like:
>
> [ 36.145223] general protection fault, maybe for address 0x2d: 0000 [#1]
> PREEMPT SMP NOPTI
> [ 36.145794] CPU: 2 PID: 1847 Comm: ld-linux.so.2 Not tainted
> 5.19.1-1-default #1 openSUSE Tumbleweed
> f3b44bfb672cdb9f235aff53b57724eba8b9411b
> [ 36.146608] Hardware name: HP ProLiant ML350p Gen8, BIOS P72 11/14/2013
> [ 36.148126] RIP: e030:entry_INT80_compat+0x3/0xa3
>
> Fix that by open coding this single instance of the SWAPGS macro.
>
> Cc: <stable@xxxxxxxxxxxxxxx> # 5.19
> Fixes: c89191ce67ef ("x86/entry: Convert SWAPGS to swapgs and remove the
> definition of SWAPGS")
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
|
