[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH] MAINTAINERS: CC Anthony on Xen's build system changes


  • To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 16 Aug 2022 14:52:19 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Yw2ena/XP2tlzURslaoK7HTdPAMCVf6O1iSC4Er5MPY=; b=YTJwoGzSQSN0mZLvtiHe/lXVk7BJ7EhAKgEyF3g3wMnBhwVViPbqa3Iv4ie6AcOggXu6rU5uGdjOO0H43jyIrFo/JNujVYdgJchzAaIUjDDCqIvoqHI4H9fIVZhoBHc/DEvmbODQ6p8ofyoiBJgECnVpQOHiV5RU1YfAC1koie55Uh2gPOQhzPCdKLmfKfyfJDZa2UMzNvIzCN/RacmBWm1awFbb7koxZM1CWrg+EHZtqLyx2eKu7nbJhegqZCiqWsmSZNkDpDzA8V0t8llWalgFUrCw4dzU9gyjcQCj2IlavYQJRlqvOAKV0p+43wOWJ+J76YNkw6Qe3fPAYQWWwg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aIE+2OAARIwPq3HsYVOTxoI/7uafet5z8XV2hkNn0vaw3RsrRa4Pglm1AYt2hDyajpGZba6eFXuscKnSz6pwYjW29P73TYenC7WbVzW30xonUm0gHpKJawyk03lkj749NN7VVknMXsAF0R7i0jakX61DxU9XddbTx9xgocgxvOCYsElIjz8nlyPhJXIUk7zubAm/locqODeGV0hC/TNJ3p+OcgecC5ZKmaAVcOe7L/coCxaNm9ttFwePhSTHQyq8M3eBPSLR/B1X8kBaFXIk592mpPge4fpG48romUIvMiCM8EHG2OdhKwa67bSS7QXlKfqj0crpRalJ8h5QNGX3Rg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 16 Aug 2022 12:52:42 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 16.08.2022 13:03, Anthony PERARD wrote:
> I'd like to keep an eye on any changes in the Makefiles, to avoid
> further break of the build system.
> 
> With this entries, it means that THE REST will not be CCed anymore for
> changes in
> - xen/Makefile
> - xen/*.mk
> - xen/scripts/Kbuild.include
> - xen/scripts/Makefile.*
> This could be an issue.
> 
> Most other files are also listed in other sections so would have a
> maintainer. There's probably a few Makefiles in subdirectory that
> would have CC THE REST but won't with this new section.

Ideally the script would still pick REST if there's no M: entry;
I have no idea whether that's already the case.

> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -260,6 +260,20 @@ M:       Rahul Singh <rahul.singh@xxxxxxx>
>  S:   Supported
>  F:   xen/drivers/passthrough/arm/smmu-v3.c
>  
> +BUILD SYSTEM XEN
> +R:   Anthony PERARD <anthony.perard@xxxxxxxxxx>
> +S:   Supported
> +F:   xen/Makefile
> +F:   xen/*.mk
> +F:   xen/scripts/Kbuild.include
> +F:   xen/scripts/Makefile.*
> +F:   xen/common/efi/efi-common.mk
> +F:   xen/arch/*/*.mk
> +F:   xen/*/Makefile
> +F:   xen/*/*/Makefile
> +F:   xen/*/*/*/Makefile
> +F:   xen/*/*/*/*/Makefile

I'm curious what the sorting criteria (if any) was for the individual
F: lines. And I guess the last four lines can't really be collapsed
into xen/**/Makefile ...

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.