[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH] build: Fix x86 build without EFI
- To: Anthony Perard <anthony.perard@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Tue, 16 Aug 2022 16:08:07 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SaieZhczY+8s0OVgPCLhMTCyCP5l1OnZctEKpgoE698=; b=fAxI8VFLZ2YO5hts1hQ7kcqR1IqyEr3+gI4OL7oXNwaQ2bXZRRLFneZ6M1Lq36lj9EfsV/ewn4IPkMN6VrN5sPPAllrd7O7hbDzZi7z3f7aERoB6SlOT/qQcw40ahDBbOR2dB7te+oDYufJ0rP9vMPCWcxfIzh+8ZW28h51EEmVmc5bhhZ1L7P0p8Mj/p093pQlYdAJ72jjwXzIJlnyMpnlud3pM0gsS6ioEJ3cVYgN29nXfwWJvI2gzo7DO30cTfuMn1TWzVHuqYCXzxCnXDO76JhTMFtJ0Vz6629Lj3dfxlVYLnkAcuwahcktOv734QFpx2gDnJ3/U1dH3WYYzaw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BoCkY/5NEGqyOeQKImKvUZJYPwigWRdy3/ivptY4mDU4N6YGXW/KJkMynI87bvFOJAueUQPmA48vD0jVVC3+4DXq38d/WYMxoXEIHH8J7iVGUPsY75o1ThQgc6WVfKTpixWKqVtObf+M0fTfFtdGxe66Pg/MUHrURR8AS0qoAAieYiv2+HP1oOrHqc3va4ZlzMZ1WKW4Mj4uAnkbOIl9W6uRI4joZbqbvtJODVvs8gYaYT8YFS7c8IQ8H2tbhgU11nla2Lc+tOxkZvUejmUKgmqWthrENo8MHZtrZUZxJiR76KMtKeA4qIfYFTSbunnwtpt/9SxnjH9LntgYMlh7Bw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Wei Chen <wei.chen@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 16 Aug 2022 16:08:46 +0000
- Ironport-data: A9a23:F4wSsKw60tkqdMnsXhN6t+ezxyrEfRIJ4+MujC+fZmUNrF6WrkUEy GJKXDvQaP3YM2fxfN0iboXj8BgB6MTQz9RkT1c5qCAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv676yEUOZigHtLUEPTDNj16WThqQSIgjQMLs+Mii8tjjMPR7zml4 LsemOWCfg7+s9JIGjhMsfjb+Eox5K6aVA4w5TTSW9ga5DcyqFFNZH4vDfnZB2f1RIBSAtm7S 47rpF1u1jqEl/uFIorNfofTKiXmcJaLVeS9oiM+t5yZqgpDvkQPPpMTb5LwX6v1ZwKhxLidw P0V3XC5pJxA0qfkwIzxWDEAe81y0DEvFBYq7hFTvOTKp3AqfUcAzN1PPk80BKs2yt9nCFNQs tsFOjItNwyM0rfeLLKTEoGAh+wFBeyyZMY1nC4lyjvUS/E7XZrEXqPGo8dC2ys9jdxPGvCYY NcFbT1ob1LLZBgn1lU/Ucpi2rv3wCanNWQA8Tp5poJui4TX5CV33KLgL5z+fduSSN8Otk2Zu njH7yLyBRRy2Nm3lmrfqCr32LCncSXTc6MiKrCG9OZTrX7UhWMLFzsMdHakrqzs4qK5c5cFQ 6AOwQI+oK53+EG1Q93VWxyjvGXCrhMaQ8BXEeAx9EeK0KW8ywSTC3UATzVBQMc7r8JwTjsvv neWktKvDjxitpWcU3fb/bCRxRupIjQcJ2IGYS4CTCMG7sPlrYV1iQjAJv5hDaq0g9vdCTz2h TeQo0AWjbgJkdQC0an9+Fndmi+tvbDAVAtz7QLSNkqb6Qd+aJ+gdpafw1HR5vZdL66UVlCE+ nMDnqCjAPsmCJiMkGmHRroLFbTwv/KdamSE2BhoAoUr8Cmr9zi7Z4dM7TpiJUBvdMEZZTvuZ 0yVsgRUjHNOAEaXgWZMS9rZI6wXIWLITI2Nuiz8BjaWXqVMSQ==
- Ironport-hdrordr: A9a23:tbvfoKFNwWlC9sTEpLqFwJLXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5Vp2RvnhNNICPoqTM2ftW7dySeVxeBZnMHfKljbdxEWmdQtsp uIH5IeNDS0NykDsS+Y2nj2Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf +hD6R8xwaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oK+RSDljSh7Z/9Cly90g0FWz1C7L8++S yd+jaJp5mLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjow4OyjhkQGhYaVmQvmnsCouqO+ixV42mJ 3nogsmPe5093TNF1vF7yfF6k3F6nID+nXiwViXjT/IusriXg83DMJHmMZwbgbZw1BIhqA+7I t7m0ai87ZHBxLJmyrwo/LSUQtxq0ayqX0+1cYOkn1kV5cEYrM5l/1cwKoVKuZEIMvJ0vFhLA BcNrCb2B+QSyLCU5nthBgq/DVrZAVqIv7JeDlYhiXf6UkqoJkw9Tpl+CVYpAZByHt1ceg72w yPWJ4Y641mX4sYa7lwC/wGRtbyAmvRQQjUOGbXOlj/ErobUki94qIfzY9Fk91CQqZ4uqcaid DEShdVpGQyc0XhBYmH24BK6AnERCG4US72ws9T6pBlsvmkLYCbehGrWRQriY+tsv8fCsrUV7 K6P49XGebqKS/rFZxS1wPzVpFOIT0VUdETuNw8R1WSy/i7YrHCp6jearLeNbDtGTErVif2BW YCRiH6IIFa4kWiShbD8WzssrPWCznCFL5LYdjnFrIoufkw36V3w3sooEX84N2XIjtftaFzdF diIdrc49GGmVU=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYsVtOBicyb/5hREGrPWYjX4A7za2xsgiA
- Thread-topic: [XEN PATCH] build: Fix x86 build without EFI
On 16/08/2022 11:30, Anthony Perard wrote:
> We can't have a source file with the same name that exist in both the
> common code and in the arch specific code for efi/. This can lead to
> comfusion in make and it can pick up the wrong source file. This issue
> lead to a failure to build a pv-shim for x86 out-of-tree, as this is
> one example of an x86 build using the efi/stub.c.
>
> The issue is that in out-of-tree, make might find x86/efi/stub.c via
> VPATH, but as the target needs to be rebuilt due to FORCE, make
> actually avoid changing the source tree and rebuilt the target with
> VPATH ignored, so $@ lead to the build tree where "stub.c" dosen't
> exist yet so a link is made to "common/stub.c".
>
> Rework the new common/stub.c file to have a different name than the
> already existing one. And build both *stub.c as two different objects.
> This mean we have to move some efi_compat_* aliases which are probably
> useless for Arm.
>
> Avoid using $(EFIOBJ-y) as an alias for $(clean-files), add
> common_stub.c directly to $(clean-files).
>
> Fixes: 7f96859b0d00 ("xen: reuse x86 EFI stub functions for Arm")
> Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Tested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
