[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v2] build: Fix x86 out-of-tree build without EFI


  • To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 17 Aug 2022 12:38:36 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SReFO7fDnj7SzKY7MhJIBp/Ob2Kh5NHQE7Gvvp3ypIc=; b=abX2l6o4qcz7TdAbN3y1DPMKJAwGP4QPnbvtNkml7hBd5LxeyeUn8N3ny5AcCDl2RgaZNuW6bHqBOWq0XpkEIpgy1v2Wz9wa7czCc0r4w6lxyLVyz28fSNNPwLAk5zJeOgvhyfR7ifbNPotgIqVuTZmD8BlFulKjw2CL3UJHcDRFQHuLzjTP0ZyVkV62buXssegbPKerVfmjgws4lz0TWts4F7EJKJqEjpQN/E4G3q2eFyR7aMgiq05CJAKaOFOUw1eAIAREA7O5oScpft6arVL/DCEyopWpk40brtxzHmpFV2t7fOTYz/LjQ5eMYHcTAzmj4I8U88zTzZfYadR4yQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EthBee6Y9CB38Lr+j4X9fb2Tn0e3BmCQUxaBRXzDor8rh/f4JLPFwd66nS3A4tSwCuOlu3r5vAuaBjcQcGNmX6rsdIWPTbPRIfjJc/Qt+3WSt8VQju8IspKU1O/8aLiwioFZ/haXOy2l88yUfZ45r1j5kdXk4kMEsnb2vZgf2nIPAPlOzkDPmW9jwi36b0M8updhuD2FE1Mc2bQhoN860omc/R0iTT6TwR5ffNWiV9r8+qxI+VybSxFvyIV+FA//p5GL8Lv5VX0y0sxgaOm+7TzEQtyEvQQGrs3JL4l6dZyHc6GJc+u+v9q+9bKlci747krfHZPQulrt751fVTjvTQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 17 Aug 2022 10:38:47 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 17.08.2022 11:15, Anthony PERARD wrote:
> --- a/xen/common/efi/efi-common.mk
> +++ b/xen/common/efi/efi-common.mk
> @@ -9,9 +9,9 @@ CFLAGS-y += -iquote $(srcdir)
>  # e.g.: It transforms "dir/foo/bar" into successively
>  #       "dir foo bar", ".. .. ..", "../../.."
>  $(obj)/%.c: $(srctree)/common/efi/%.c FORCE
> -     $(Q)test -f $@ || \
> -         ln -nfs $(subst $(space),/,$(patsubst %,..,$(subst /, 
> ,$(obj))))/source/common/efi/$(<F) $@
> +     $(Q)ln -nfs $(subst $(space),/,$(patsubst %,..,$(subst /, 
> ,$(obj))))/source/common/efi/$(<F) $@

I'm afraid the commit message hasn't made clear to me why this part of
the change is (still) needed (or perhaps just wanted). The rest of this
lgtm now, thanks.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.