[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Use direct I/O for loop devices


  • To: Demi Marie Obenour <demi@xxxxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 18 Aug 2022 16:12:10 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c6Uyciml7mRjKwb4uEigthI/E9mN6oKAmwHxwJYuWss=; b=WP7NYN1hjDWYToYMAGgRn8bASq3NLiWoI2xa+wW5d8LLmAUTcQwskdZ7J1hFLf5z55o8Nwo9D8yufFFNgdPjYca5jpin6U9R+tlSJP9stXX8MCMVCErA8Ost5bqNVwajeMSnjUxFxa6ak1fGEO8fwRXPWabJyTv2jGVHMgSZNlgkTQTa8p52qgoMK8aBiaiF5EVKQ9bJTjGL0ZWlkyjbxOCh318TE+w8QTsaQK5+1TaUDRg8riAWXSKDK8icMALgUDKnZ13blwNYRqjvQz8rYRptEpmlJEOoPtv+Y4Ly4WyA/VBYSMqy33kLqKvsB3/+CpByRbRumZe679VXprvIzA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KJK/YE6L5GOgWlP9IGwWPCmSCKzmsPzafS3Qa7RsnkeVU39GZplVh4UHKFHw9TzAZeHbMa+MD61vQe4/v7eWIJiUg5+8tiMQXUceCk6EOU3wpRGSrBIWCtq8BtLMheL/02CtWu2dLSsDq8E0nAm6Lwd+ieizJZTnV92UWkKmWNYjcUH412UmsR5hcDIctn2Vzw7YQ3IjN+NtAXAtNARzFymlkqgYFzF0++qTKa0qJNqurXzDbclGRut7PTj/PSCOk9rT9EOf/YZkKtdkLboSxSACBOY5EFZJOnPEe8/8NnmNV8SpuEcXnH30AAt30lEbmXPoO+KNt6mQKoG6y2z1Wg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Xen developer discussion <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 18 Aug 2022 14:12:20 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 18.08.2022 16:04, Demi Marie Obenour wrote:
> On Thu, Aug 18, 2022 at 09:02:11AM +0200, Jan Beulich wrote:
>> On 17.08.2022 22:46, Demi Marie Obenour wrote:
>>> --- a/tools/hotplug/Linux/block
>>> +++ b/tools/hotplug/Linux/block
>>> @@ -330,7 +330,7 @@ mount it read-write in a guest domain."
>>>          else
>>>            roflag=''
>>>          fi
>>> -        do_or_die losetup $roflag "$loopdev" "$file"
>>> +        do_or_die losetup --direct-io=on $roflag "$loopdev" "$file"
>>
>> I guess you want to first check (maybe in tools/configure) that losetup
>> actually supports that option. The old-ish one I'm looking at doesn't,
>> according to its --help output at least.
> 
> What version are you referring to?

The tool itself doesn't recognize --version. It originates from
util-linux 2.19.1 from all I can tell.

> In Qubes OS the current plan is to use a block “script” written in C, to
> improve performance and (when combined with kernel patches) eliminate
> race conditions.  This code could be made a wrapper for the C version.

Is this relevant here in some way I don't recognize, or did you say this
only to provide some further background info?

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.