[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] Arm32: tidy the memset() macro
- To: Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 19 Aug 2022 10:02:25 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BR4PK+t4pG48d+FtjHCAGkQdqKixBM2NDX6ZX/kNB8g=; b=Lq1FrPs8UCgHTcMTCEiN/l0Al75LEb6/nYt1Wal54ue1JTwcv7qnRz0fNLW3IpfFdgheOIf/PrnfyCtGozDo67OuzuP6Ja/tnIQjTXufwtKS22OVpYrl0gh2JkRkvh36z8UY3aUxFq62c9j6uO9Fwq8ZoAKx/d1hN7dhrD/PoLHYLCeMp7/4dLYK+wPTWBZhw3cOyryXTgp5bImmaWYeme9hzll9DG0Nb9+c6xtXOm/ZIgiu3nLiwm2qaBI2YFKtksr046EWyY0PP/mQOO2dDmszznV6JXyCCOm5/W+TiShqQgbu7OjbJk7rpntJHoAd/Etfa3qud2kICm64i9QSNQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LngbvELNnqOi7fzE1SCCaTr4fp9u7aZ8kKDQuX/K5PM4aLddmcKCWrW9587ZJEvAlmCFyjIskVx2qbcYJnN15UbM8wPp9WDyGKO9uzG+hcXcT1uLyvAXWPjEQdqWnkOvxhKaoTw1GAIuatcWkYI0uk/YoZ04awwq3qaB98led15xe3RVgDJRSxjJoCsJIdONMy39UM+sTdWlcelaLLJo1lgV9dNB2DfIyyi3PFqlCEw1Lwn4ecvvzU7KfphkFWTsYus5n55NrOMojJaaXhJUbD77U60QUVz1kAi70Q/ZEjMOlABLbEX9avUrqw+2kmoGtchNfq1ADtHpEUPYTK0XHg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 19 Aug 2022 08:02:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.08.2022 09:58, Julien Grall wrote:
> On 19/08/2022 08:50, Jan Beulich wrote:
>> - add parentheses where they were missing (MISRA)
>> - make sure to evaluate also v exactly once (MISRA)
>> - remove excess parentheses
>> - rename local variables to not have leading underscores
>> - apply Xen coding style
>
> This code has been taken from Linux. From you write above, I don't see
> any strong reason for us to modify it (even if it is small).
At least the MISRA issues want addressing, I suppose. Plus I wasn't
able to spot the macro in Linux anymore (nor __memzero()), so to me
there seemed to be little point to consider keeping anything "in sync"
here.
Jan
|
