[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] xenbaked: properly use time_t in dump_stats()


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Fri, 19 Aug 2022 09:27:18 +0100
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Fri, 19 Aug 2022 08:27:38 +0000
  • Ironport-data: A9a23:Czyd96kSxmpaXjult/z/sJ7o5gzvJkRdPkR7XQ2eYbSJt1+Wr1Gzt xIfUT+Fb/7cYjagLdh0YIi+804GuZbdnYVnGlFk+Sg0RCMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV ena+qUzA3f4nW8vWo4ow/jb8kk37K2i4GhwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2kRI7wow9dqOF1n9 M4UaxQfaEiMmOGPlefTpulE3qzPLeHuNYIb/Hph0SvYHbAtRpWrr6fivIECmm1q34YXQKiYN 5FxhTlHNXwsZzVGPEsXD5Qv2v+lnHDlfxVTqU6PpLpx6G/WpOB0+Oe9aYuJJY3aLSlTtkqU+ U/B+WD7OU9ZOeCWzAiro2D2vMaayEsXX6pNTeblp5aGmma72Wg7GBAQE1yhrpGRmkO4Ht5SN UEQ0i4vtrQpslymSMHnWB+1q2LCuQQTM/JSGeAn7ACGyoLP/h2UQGMDS1Z8hMcO7ZFsA2Zwj xnQwo2vVWcHXKCppWy10amlnQqDJBEpBG4waWwgXw1d7MbgmdRm5v7QdeqPAJJZn/WsR2+ok 2/W9Xhg71kApZVVjvvmpDgrlxrp/8GUFVBtu207S0r/tmtEiJiZi5tEALQxxdJJN86nQ1aIp xDocODOvblVXflheMFgKdjh/Y1FBN7faVUweXY1Q/EcG82FohZPh7x47jBkP1tOOc0ZYzLva 0K7kVoPuscDYCT1PPMpM9nZ5yEWIU/IRLzYug38NIISMvCdiifclM2RWaJg9z+0yxV9+U3OE ZyabdytHR4nNEiT9xLvHr91+eJ6mUgDKZb7H8+TI+KPjeXDPxZ4iN4tbDOzUwzOxPrU/l2Io 4gEa5DiJtc2eLSWXxQ7OLU7dTgiRUXXz7ivwyCLXoZv+jZbJVw=
  • Ironport-hdrordr: A9a23:H2liK6s88TSIN3Q4ivxUGtUk7skDdNV00zEX/kB9WHVpmszxra GTddAgpHjJYVcqKRUdcL+7VJVoLUmyyXcx2/h2AV7AZniChILLFvAA0WKK+VSJcEeSygce79 YDT0EXMqyIMbEQt6bHCWeDfeod/A==
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Fri, Aug 19, 2022 at 09:59:26AM +0200, Jan Beulich wrote:
> "int" is not a suitable type to convert time()'s return value to. Avoid
> casts and other extra fiddling by using difftime(), on the assumption
> that the overhead of using "double" doesn't matter here.
> 
> Coverity ID: 1509374
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> v2: Properly use %.0f everywhere.

Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks,

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.