[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Ping: [XEN PATCH v4 01/32] tools/debugger/gdbsx: Fix and cleanup makefiles
- To: Elena Ufimtseva <elena.ufimtseva@xxxxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Fri, 19 Aug 2022 13:57:41 +0100
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: Wei Liu <wl@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 19 Aug 2022 12:58:06 +0000
- Ironport-data: A9a23:Bk/iVqoJGt7RyiHMEMb283lT1hReBmJpZRIvgKrLsJaIsI4StFCzt garIBmEaPeIYDOjL9knPNu+8h4GucTQn9NrTQI4/yhhFXgXopuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt MiaT/f3YTdJ4BYpdDNPg06/gEk35q6q6GpI5gdWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqUV+uxbDnFnx MAHMQ0QcDqxhfCT8I6kH7wEasQLdKEHPasas3BkizrYEewnUdbIRKCiCd1whWlqwJoURLCHO pRfOWEHgBfoOnWjPn8eDo4+m+G5wGHyaTRCpHqepLYt4niVxwt0uFToGIqMIoXbFJ0I9qqej kXD+yfbMBUUDsKk2CPery2xxbbQujyuDer+E5Xnr6U30TV/3Fc7GBAQEFe2v/S9okq/QM5Eb VwZ/DI0qqo//1DtScPyNzWnpFaUsxhaXMBfe8U37AyLw+zJ7QecGnMJUDdpb8Yvv8s7Azct0 ze0c8jBXGI19ufPEDTEq+nS/Wja1TUpwXEqaC8OYQQVyujfv5gOkwzlfNRxNZ6JkYigcd3v+ AxmvBTSlp1K05BTh/rnpACZ696/jsOXF1Bov207Skrgt1okP9D9OuRE/HCBtZ59wJClok5tV ZTus+yX96gwAJ6Ej0Rhq81dTejyt55p3NAx6GOD/qXNFBz3ohZPhagKvFlDyL5Ba67ogwPBb k7Joh9275ROJnasZqIfS9vvVZx6kfe/RIi7Bqu8gj9yjn9ZJWe6ENxGPxbMjwgBbmB3+U3AB XtrWZn1VitLYUiW5DG3W/0cwdcW+8zK/kuKHMiT50n2jtKjiIu9E+ht3K2mMr9kt8tpYWz9r 75iCid9404DCL2mO3eLqtJ7wJJjBSFTOK0aYvd/LoarSjeK0kl4YxMN6dvNo7BYopk=
- Ironport-hdrordr: A9a23:5JHkxK0RG+N0YP9sEzWACAqjBLIkLtp133Aq2lEZdPRUGvb3qy mLpoV+6faUskd1ZJhOo7290cW7LU80sKQFhrX5Xo3SPjUO2lHJEGgK1+KLqFfd8m/Fh41gPM 9bAs5D4bbLbGSS4/yU3DWF
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Elena,
Could you give a ack or review this patch?
Thanks,
On Thu, Aug 11, 2022 at 05:48:14PM +0100, Anthony PERARD wrote:
> gdbsx/:
> - Make use of subdir facility for the "clean" target.
> - No need to remove the *.a, they aren't in this dir.
> - Avoid calling "distclean" in subdirs as "distclean" targets do only
> call "clean", and the "clean" also runs "clean" in subdirs.
> - Avoid the need to make "gx_all.a" and "xg_all.a" in the "all"
> recipe by forcing make to check for update of "xg/xg_all.a" and
> "gx/gx_all.a" by having "FORCE" as prerequisite. Now, when making
> "gdbsx", make will recurse even when both *.a already exist.
> - List target in $(TARGETS).
>
> gdbsx/*/:
> - Fix dependency on *.h.
> - Remove some dead code.
> - List targets in $(TARGETS).
> - Remove "build" target.
> - Cleanup "clean" targets.
> - remove comments about the choice of "ar" instead of "ld"
> - Use "$(AR)" instead of plain "ar".
>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
--
Anthony PERARD
|