[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v4 21/32] tools: Remove -Werror everywhere else


  • To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 19 Aug 2022 16:56:05 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uAE4ajIzBGIWPLYM69sgRqx2ZRTgZcDz0hEtzpPXQZ8=; b=bFUK10kd1FTvT8YNmfufsaFqxWUMZDbRf72NbvxZyKQeu18jLuZdRjPlqsg8l0AQjUSxp3tmdwxxUHSWe9ehc2IZ/bKFC6B1LN5TuxD9iDeQYCHvMh8bX6AlalgzCVxZmt8QgP3GLWlZPqU9VSxs0ltBBF13j+HXM4H0xdvxb9qY2o2Fjdsrb+qVtCGbOOpagMrqvuITJ7OG81l9zUnOgrVGg0rXPrhmxZnrgyQ6p9JOLT8YzxH57FNcb+RHTV3pbxqc2P+co1zLSUdx60wLH79K9ERj9hQLxFWBn2zdkZJCabeJgEKegeLaWNN6NT5Kg816IK4rQYCZ3UR4AA7iew==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H/6ifCAW8gW318oRTZqNIsDz7SU3Q7ty1vHjJG7opUGAKJZ19Ew35H0sbjFWaYIslhWVojZs5ldkRZHfXm9b2raoPycYcoZWqdUQ9K+88p8FKyMoKs+uGPW16E8VTumSN5EBhNL5yb9Tkx7gYUilgb2RpEVQd6um4PoCzgcS0cXgO9VR4/3NUoN4HghEy04gBt3bbk/bCEK7Z9JmtXJKDlxqlw2k7ZCJ+zGMITcWBR0J90Bl8dXrYHpXoCbrEwdvgklmvK1uZYRqtYlSIAy6K8659xeY1Y0lZD1uxeU9qSdNVuuHcXPcFMzvq0MSRVDGzOcMQfmEg7Iv9ovU1G+V1g==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Christian Lindig <christian.lindig@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Elena Ufimtseva <elena.ufimtseva@xxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, David Scott <dave@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 19 Aug 2022 14:56:37 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 11.08.2022 18:48, Anthony PERARD wrote:
> Patch "tools: Add -Werror by default to all tools/" have added
> "-Werror" to CFLAGS in tools/Rules.mk, remove it from every other
> makefiles as it is now duplicated.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> Acked-by: Christian Lindig <christian.lindig@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
for the tiny parts where it's applicable.

I'm curious:

> ---
>  tools/console/client/Makefile   | 1 -
>  tools/console/daemon/Makefile   | 1 -
>  tools/debugger/kdd/Makefile     | 1 -
>  tools/flask/utils/Makefile      | 1 -
>  tools/fuzz/cpu-policy/Makefile  | 2 +-
>  tools/misc/Makefile             | 1 -
>  tools/tests/cpu-policy/Makefile | 2 +-
>  tools/tests/depriv/Makefile     | 2 +-
>  tools/tests/resource/Makefile   | 1 -
>  tools/tests/tsx/Makefile        | 1 -
>  tools/tests/xenstore/Makefile   | 1 -
>  tools/xcutils/Makefile          | 2 --
>  tools/xenmon/Makefile           | 1 -
>  tools/xenpaging/Makefile        | 1 -
>  tools/xenpmd/Makefile           | 1 -
>  tools/xentop/Makefile           | 2 +-
>  tools/xentrace/Makefile         | 2 --
>  tools/xl/Makefile               | 2 +-
>  tools/debugger/gdbsx/Rules.mk   | 2 +-
>  tools/firmware/Rules.mk         | 2 --
>  tools/libfsimage/common.mk      | 2 +-
>  tools/libs/libs.mk              | 2 +-
>  tools/ocaml/common.make         | 2 +-
>  tools/xenstore/Makefile.common  | 1 -
>  24 files changed, 9 insertions(+), 27 deletions(-)

Normally these are sorted (as are the actual patch hunks), helping
the quick spotting of individual files of interest. Was there
anything unusual you did to prevent the (full) sorting?

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.