[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] arm/domain: fix comment for arch_set_info_guest
- To: Julien Grall <julien@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Mon, 22 Aug 2022 06:56:55 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0OAcYnGpEiVeK5XYu6NBnR2hlpsWbN7xaMRNfyxM5xM=; b=BYhgQdNycbu7kLFIwEl8w+N57TWROmgVZAc2X68y2dIiBWAYStAZDIri8OD0/UNI5ZvHiOmR7JKvYb4NmMF9OanCXNmZHDhR2V3SS6ymgwWCyBm/WS+xpDvJVnE35tnMTbsz1uVOtG1nBz8p3BpPfZtlKMfw8pA4IsyJ+BVHkHKoN0RTrFo9fYnvu38MkruQgbMiJdKlWD4SAAcszmVlsqrIsnnIzt0wVP9zNRl1fCoSI6UwlbkWA7QhN5kxEwPtB9xO2YLH6tie48y68sCRyZRkoh+vUlTxfNaZS7tJURUIcTGUodO7VOOIa8B61AOAOV6S/i5JoQ/tHr+cuH2iGA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0OAcYnGpEiVeK5XYu6NBnR2hlpsWbN7xaMRNfyxM5xM=; b=AFjIAHC6sC79fzxFeoY90gM38Lim3WN3A7NoJqr6eVEqGNSVjOFfqUYE1ezTJM/oGx/EVUIbh8ZLgd7xJzaxQzJdgxb/fKaYkS+xA0vHmXISBClzd57GBP4VNlZPOirQN+gfV+y6hl73y4YqKmH18XziU+airUYtiFHvQCD0MaHyVDxe397tEnOyhRJzAgZ6TFhJqAzHQ1cbyDDagWHifx9vmYzz1TkqP1Is7tee25oOZvBySWoEEL35J8/IN61zO7Okrk/T/2Ks4ymHSuEOfhUIp1+k6fQTBBk2EmGMG3BocBIQbeQXBZSuqYRogLp5sEED7+6QWwFVvc1qC1dy/A==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=RJSOxWiyUXNMzDYqXB7o9zvqkPLPNYaW+GRYG0HvhvjIrlU96wyg4CVbQxiKUKu3bFhEeMQAQ/ObvuWbtIYE6ewkYH52d/iBQvucW+jZUsTKxZZyB6y2ZkUeeHZ1SkCXVUDAPe9RfGRv/+2QS1gzvGtDU1de8DXrmwYVTM5f25woWvHn7F/e1J+dat7pSSUfisjBDJeDdGrWH6xl0efL3JrP/gJg0vkHDo9HZy1SG+2tNrixpkaEo1s8obvlzniCU02FowIIMoLW0F0Y8FaoTN8ZXRVNHyO/Xs1EPBRRNOP0BCasKFvB/fL5adhtXCp9X+QGwCnKefpsbveUg3umVg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OTpnEMVM4bOhxMk1+21U6zf+8A+32LUanvF7mQ2FIhWcTKT2cWKVzEQzTmhJL0W6tpbU/af8oibFS1dz6Z1RGrzsvKPcM+vEON30uvTNyhEorecoPPUkUraNFeIqpTzgap3vvPQ4sWDz9leEHQAgVt3NVlfZvKh8fUpCXTk2BS3Kctdtj6pgKsnT0s3BKzy3BWhKdGx24f5URWOPZ81ap5IzAdNU+dsLbYnN16V6GlTJ6INTPAMSRGEaxy73QO+ASpDpCEYlELmQsoO9QPScoC3k2TM3UYxeEZaXxJyJ/fABlRAx/szbYMEGjnA8tmVRTCxxOT0Trv2e4Arvg75Ssw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen development discussion <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 22 Aug 2022 06:57:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYqMxj+SsCb6WfSkeThh/1USfbDq2gke8AgBoFMQA=
- Thread-topic: [PATCH] arm/domain: fix comment for arch_set_info_guest
> On 5 Aug 2022, at 18:35, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Luca,
>
> On 05/08/2022 14:08, Luca Fancellu wrote:
>> The function arch_set_info_guest is not reached anymore through
>> VCPUOP_initialise on arm, update the comment.
>> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
>> ---
>> Changes in v2:
>> - rephrased comment to not list caller functions (Julien)
>> ---
>> xen/arch/arm/domain.c | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
>> index 2cd481979cf1..9db8a37a089c 100644
>> --- a/xen/arch/arm/domain.c
>> +++ b/xen/arch/arm/domain.c
>> @@ -885,9 +885,8 @@ static int is_guest_pv64_psr(uint64_t psr)
>> #endif
>> /*
>> - * Initialise VCPU state. The context can be supplied by either the
>> - * toolstack (XEN_DOMCTL_setvcpucontext) or the guest
>> - * (VCPUOP_initialise) and therefore must be properly validated.
>> + * Initialise vCPU state. The context may be supplied by an external
>> entity, so
>> + * we need to validate it
>
> NIT: Missing a full stop. This can be added on commit.
>
> Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
Hi Julien,
Any plan to commit this one? Not an important change, just asking so that I can
remove it
from my watch list.
Cheers,
Luca
>
> Cheers,
>
> --
> Julien Grall
|
