[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/7] xen/evtchn: modify evtchn_bind_interdomain to support static evtchn
- To: Julien Grall <julien@xxxxxxx>
- From: Rahul Singh <Rahul.Singh@xxxxxxx>
- Date: Tue, 23 Aug 2022 09:23:12 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zXNyk0uak+sMNoqFZ/H1Ta7Ck8GLF1wWXmHUj9pspAM=; b=dmlF1bzSzn7QoK4DcZVKOGUgntE6ekax5v7Wbh1H6Y34EiF4t8zH79MH/GH1ND0FBUD4lKyCeZENFBtRqWeVnzUPQlx8EZbgg/lrPm2eU38U21uiULZhK/cwHvfkBMDsIfrK71N+8mHKPIVB0BlHAzroFuwSFt+F3WzIQndS48INSHG+KqHAuCMPdAQLHEetSKPHFOUSI/V6GfAzywQwTROeUMJHbTlBu9MyZxOWUV9d4WRwu/JHebS12PcpF7fuQek3rWXTX0rwOqzsxxpwdMHMFKLrUudbJ/ydaLpim04sdkMVDSGScsWkyxoOD1lyYx6gpw7+Q65DbHkQZEgEZA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zXNyk0uak+sMNoqFZ/H1Ta7Ck8GLF1wWXmHUj9pspAM=; b=ltfbZOYjCUnAxrPuuYrwVUEGvq/2aLnZjUBsf5hxwywPMOscqlR6oG2Fhp59QvV8cDQytFAcc2od2FGO3twMq9+3KeErF+owKQDOuqYcQdeAH776y4iEd8xk7VonmAEukdoFnandNwxntDI7oFNZjjjfao1bSwDonCDqx9/3FgsGwhOh10uYIuOM2leuu4hm7KiRhzY02HF9hjlFgZwSV7OcMF50lD3hAiaeJTH5ZrdNV+n54iUjGzquVHMdQN2zq9afdOP59qkGxqrlU5pptX6HjTAkae0htSKQUI9U99m/ZpXKfMt/Y9rs/Kjx30oYn6VEnNHAMF+249Ud+TympA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=NlDuV0KQU3osurfkfL7uE0Y7Hi8CAQJ/9ipWvdU7Y9MYOwFgv9UgV4wEEKIsuyerbPZjKXdG+0scl4++wTrh55sIc+tmFOuei6XbX3vQvyp/aFhAfhyo1bIedXaN/ybP1ZFJ+V0JP9VUJtT0jbjGtYO1kiES9Sb8MAR/wr3DeHSnqCWhofUbbHh3jIcKi/EzgBLMcDozluSxSXjioLkGlyNzLKATfbsCGR2tV8ghwzjMB7/yx/rhZ+LI1giKyuwYt8JW7xDqaTevloPZDTfnxSRUKpT6/CBLVv2RbfBBN7k0pizwU8sdxARcmSqa62JyjwZDFF196SChW8L+PWhb/Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ORVk7bmJFvQFldwa4fe08l9CxSBAYODMQZ2Xv3qvlK+uBoMW0+JGAdB6v8689XkdrA4jYVe6PK9oRK9tHZLd3Fy2IfDKo6zch0BFcOKCu3mCLFby+exDRSm3uabZreMCjM1K4u4/gxP7ErS4Y3eymjP/vLsG/JvzlTgSKtm+vP6j2QDl2R6HuKOUr53DeR6ZpEtzJ0/HUup/NW3Mr/fgE8C201AFh/sJIlDcLUDIKM0c+emX9WKzbNgNx+UxMJMo63YyBhDEMBh9e8vqySQBQ7hYIfYZoSaedj6y9sReZxggrM44fyk2dCYRCxgPghIRm2oujYud0czTiXvKCGP68A==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 23 Aug 2022 09:23:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYs7NTCp0JlYyBzkaD0R6ri3cXH628K9qAgAAQrQA=
- Thread-topic: [PATCH v2 4/7] xen/evtchn: modify evtchn_bind_interdomain to support static evtchn
Hi Julien,
> On 23 Aug 2022, at 9:23 am, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Rahul,
>
> On 19/08/2022 11:02, Rahul Singh wrote:
>> Static event channel support will be added for dom0less domains. Modify
>> evtchn_bind_interdomain to support static evtchn.
>> It is necessary to have access to the evtchn_bind_interdomain function
>> to do that, so make evtchn_bind_interdomain global and also make it
>> __must_check.
>> evtchn_bind_interdomain() always allocates the next available local
>> port. Static event channel support for dom0less domains requires
>> allocating a specified port.
>
> NIT: I first read this as you are trying to describe what the patch does. I
> would add "currently", "at the moment" or similar to make clear this is the
> current behavior.
Ack. I will add “currently” in next version.
>
>
>> Modify the evtchn_bind_interdomain to
>> accept the port number as an argument and allocate the specified port
>> if available. If the port number argument is zero, the next available
>> port will be allocated.
>> evtchn_bind_interdomain() finds the local domain from "current->domain"
>> pointer. evtchn_bind_interdomain() will be called from the XEN to create
>> static event channel during domain creation. "current" pointer is not
>> valid at that time, therefore modify the evtchn_bind_interdomain() to
>> pass domain as an argument.
>
> Ditto.
Ack.
Regards,
Rahul
|
