[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 2/9] xen/arm: move regpair_to_uint64() and uint64_to_regpair() to regs.h
- To: Jens Wiklander <jens.wiklander@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Wed, 24 Aug 2022 10:23:02 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linaro.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pMMfRtpp13sv74mmBq5wbSAkHtO6JyVW2xw7VNixoYs=; b=VvAdsaSblUf0rttsAJCrh1X2zJKO1tJbVehTfpQdTfZXE+2LY0fAM1U+TBhLtc0oTGNUUfn/xpDecRE9MvcvRjrZq4znnwtTCTgMd9WpMX82gpC5Lw2/KfYTcSBGjvxnW4oSZH3DxursJqsaJtfdTfgPqZUI/z19XbI80M80sxN/0IX4DnmKEXxbBPNyI9AIWzkRSS0Fk1M4wNT4dZLd9z9Y3+NAKvkCArArPUeXm/dpVL9OypPvJ2q+oHLgVWOeqiUV52lIXjEybK8yfBnuPV4yzTK/QSF8s22ELQfPrwPrfMK9BPrNzavOQljoHt88vk3ET+n08SBnE5Pt2k185g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WI9dfoEB9BWxPDyYPQPycfzzMneUT0R1P7Mg+Tq6GDo57iqK4Mii0cSxbsIfw3iww63pqIco57WAcHLFUK2A+DSaMVdZIQmSiiRuEDlO7VI5BEkejqLBgr6HGK3RJVlXEwZqxn2ty/CjTAiiV9XDhU8FVLMQUFc7PV1kVcEK2I9upWOzlE8KhHCCSoeQJYAH9AMjxlbcYcn/RfZjwni+dW071uyUYT7vIUIMwhAq8oKFh555oZ0uEijzJd5bKOrttF1rF4UDlKqvhmQJUoSnAVXW0+w5J9fqQMBxBNvwfmtMOpKXWYm8jUsQ9x6+ipLCKQwbZ/nPOkbR58/m10BP6A==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, <Bertrand.Marquis@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 24 Aug 2022 08:23:28 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Jens,
On 18/08/2022 12:55, Jens Wiklander wrote:
> Moves the two helper functions regpair_to_uint64() and
> uint64_to_regpair() from xen/arch/arm/tee/optee.c to the common arm
> specific regs.h.
>
Would be good to add a justification that these helpers will be needed by
subsequent patches.
Also I can see that you make use of them only in the last patch so it would be
natural to
move this patch right before the one making use of these helpers.
> Signed-off-by: Jens Wiklander <jens.wiklander@xxxxxxxxxx>
As for the patch itself:
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
