[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen: let ASSERT_UNREACHABLE() WARN() in non-debug builds

To: Juergen Gross <jgross@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
From: Julien Grall <julien@xxxxxxx>
Date: Wed, 24 Aug 2022 11:29:27 +0100
Cc: Henry.Wang@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
Delivery-date: Wed, 24 Aug 2022 10:29:39 +0000
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hi Juergen,

Thanks for sending the patch quickly :).

On 24/08/2022 11:22, Juergen Gross wrote:

Hitting an ASSERT_UNREACHABLE() is always wrong, so even in production
builds a warning seems to be appropriate when hitting one.

In order not to flood the console in reproducible cases, introduce
WARN_ONCE() to be used in this case.

Signed-off-by: Juergen Gross <jgross@xxxxxxxx>


Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall

References:
- [PATCH] xen: let ASSERT_UNREACHABLE() WARN() in non-debug builds
  - From: Juergen Gross

Prev by Date: [PATCH] xen: let ASSERT_UNREACHABLE() WARN() in non-debug builds
Next by Date: Re: [PATCH] xen: let ASSERT_UNREACHABLE() WARN() in non-debug builds
Previous by thread: [PATCH] xen: let ASSERT_UNREACHABLE() WARN() in non-debug builds
Next by thread: Re: [PATCH] xen: let ASSERT_UNREACHABLE() WARN() in non-debug builds
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.