[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen: let ASSERT_UNREACHABLE() WARN() in non-debug builds
- To: Jan Beulich <jbeulich@xxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Wed, 24 Aug 2022 11:19:50 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PTS5kuBOwMjUM8JcMdoCxpXOFFv4M73EeI7k7a3z2nY=; b=Lu7DIeNes2fRplLlNa+OJc10b/3/rmEISVWHKsdAkt7bSVNzgWBtgPOoq7kkjhOmkUude3d5FVV2bqQ1bPrLG9zp0zdLQ7qIUbt5u8uTMpfxtMmlna4m7Q7r2IX2EFXDhVwmhE8+0CSAsi7uI0vcXBpFrYp5LAhYrQsuhtfon2ls9IpzZCzJkqVanaiYaG4xemv+SK0S2WMX8c4aKkWJsXtGbn0dTbg5xrr+bKJEgdFkhrI8FxRRtwHGtKm+Coya/E4VVcepYyLUrOLKwJzd49/fQA133tnl68xwVHugKmkr9PGz24kpYs9zYS8IeV3eXlVj0+YKlt3b8HmQt7LXEg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C4ZRaYYceal3WMKh00OV1qLUhAokbhd0vKzfkSEp58Q01lZQgETDjG4ShPXbRJ/OpvVbrN62sIKErV2SQh1zLraD9zABe0evtY6df2gphVn7mCC61yaXtuHO81wnCvFa5N9TVjZHjQn33ffcFzanvcEyVMMe/sRoioWl/I0T5hNvskbHvXVMmV03+X0A48l0ENyUOjy2ZrMJMxyoUFKq/2YJ2IbqYX2Lp8y7JeFgqFdziTYufvAk/IB+jwNqIAiCQLQfSQ+QGmHlNjgV/c/KAYTGL29p7b9Pbtswwr1Fk17f4E/QyxRZYrs+y9+q1sCnECj1c50G0ka8Geytg1YXmQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "Henry.Wang@xxxxxxx" <Henry.Wang@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 24 Aug 2022 11:20:08 +0000
- Ironport-data: A9a23:JrayXKuMGXI4ka53TxGNYgpb6ufnVLpfMUV32f8akzHdYApBsoF/q tZmKTzVafrfajfzeNB+Ody19x5XupLWytVnTwc+qS0wEXhE+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo rsemeWGULOe82MyYzl8B56r8ks15qyi4m9A5zTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/ /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FYApotdaIV9fz vFGcx4INxCq28Dq763uH4GAhux7RCXqFKU2nyg6iB38U7MhS52FRLjW79hF2jt2ntpJAfvVe 8seb3xocQjEZBpMfFwQDfrSns/x3iW5L2Ie9QPT/PVqi4TQ5FUZPLzFGdzZYNGVA+5SmV6Vv Dnu9GXlGBAKcteYzFJp91r837STwHunBer+EpW5p9Vy3Q2D11BDAR8JD0rmjvLiqRKXDoc3x 0s8v3BGQbIJ3E6hQ8T5Xha4iGWZpRNaUN1Ve8U45xuK0bH8+BuCCy4PSTspQPwrstUnAwMj0 FChlsnsQzdotdW9S2+Z97qShSO/P24SN2BqTTQfUQIP7t3noYcyphHCVNBuFOiylNKdMS706 yCHqm45nbp7pd4G0eC38E7Khxqop4PVVUgl6wPPRGWn4whlIom/aOSVBUPz6P9BKMOVSweHt X1dwcyGtrlRUNeKiTCHR/gLEPex/fGZPTbAgFlpWZ486zCq/H3ldodViN1jGHpU3g8/UWeBS CfuVcl5vfe/4FPCgXdLXr+M
- Ironport-hdrordr: A9a23:jH0YkaAVhT5pVy7lHegPsceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuKKdkrNhR4tKOzOW9FdATbsSp7cKpgeNJ8SQzJ876U 4NSclD4ZjLfCBHZKXBkUaF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca Z0iPAmmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlml9yZbdwkK7aYp8G DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4gow3TX+0WVjbZaKvi/VQMO0aWSAZER4Z 7xSiIbToZOArXqDyeISFXWqlDdOX0VmgLfIBej8AfeSIrCNXwH4oN69PxkmlGy0TtegPhslK 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59bs5Vza/poVFZql/1owGpFVJMbWC7q4oEuF+ djSMna+fZNaFufK3TUpHNmztCgVmk6Wk7ueDlIhuWFlzxN2HxpxUoRw8IS2n8G6ZImUpFBo+ DJKL5hmr1CRtIfKah9GOACS82qDXGle2OFDEuCZVD8UK0XMXPErJD6pL0z+eGxYZQNiIA/nZ zQOWkowVLau3iefPFm8Kc7giwlGl/NLAgF4vsulKRRq/n7WKfhNzGFRRQnj9agys9vcPHmZw ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYt6Nrm2AFVHMPaUulll9Nh94Tqq292w4AgAAMhAA=
- Thread-topic: [PATCH] xen: let ASSERT_UNREACHABLE() WARN() in non-debug builds
On 24/08/2022 11:35, Jan Beulich wrote:
> On 24.08.2022 12:22, Juergen Gross wrote:
>> Hitting an ASSERT_UNREACHABLE() is always wrong, so even in production
>> builds a warning seems to be appropriate when hitting one.
> I disagree, for two reasons: This violates the implication of NDEBUG
> meaning ASSERT() and friends expand to no actual code.
I agree. ASSERT() and friends should no code in !DEBUG builds.
Furthermore, if an ASSERT_UNREACHALBE() is proving to be problematic
even at runtime, then it's not the correct construct in the first place.
~Andrew
|
