[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/CPUID: surface suitable value in EBX of XSTATE subleaf 1
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Wed, 24 Aug 2022 12:02:23 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j/g7Vsf/B17xYcTUDMcLj8uV9rv3tD9EyRScQdKjd8Y=; b=nce+o7ivD7dhtdarSOp/ASfHABfDjIjeXBWn5iaUmw2OaaF18hhMk2yx72xHkReKjeKPIqMKaHmuEqfoYIetS6AJy3/p1KUPZ4oaUSCBhh4ndzo0Yx2mfQ6Vg2nsp3etFO3XAk2TcszeYrQR8Lkqdr2MHkM3jK1Tusvo/xYKZG+MDEIlgsuHEE0Qc7UBhX57zjWZdnSG9b1Fw3PL+RaAMdbOobuD0MTA+zMWa2OEBgZ2Uw8/ixsUre+eF6oWh/lRZ/xie9nwqOInUO5pfkOek4yCoddCrfGSxQm2aD0Bx/6F3nlhgviqG4F4oD98G4l8TTs7cK7yKxd3wRND7HJl3Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bgytx6zfNl/8vj+50AWhlj24lwt7G38fI7VCcR1935Dp7WsLRs2moXIAbpCg9Ul92/DVZ1kqv/NFoV5VVP6gn2P/PN1hqmGrAaWbvXHuuIoxLVdBaAYxZh1J6M/zG0S6ps8h45teSC0eehMTYZyKDWohsYECFHom1s126mNNiqZb6aL4Xg9QKCwahUYcEE/VX77Hwt8wr4jtOiGt9BuVRwJPiBA3/24ygzBDm3qcFMkA1t8Hq38i1VcRWhyEY0SAz1WGDt0miezhfwQ04wrQh9Pa9QehUFNZNxHJZbwKTSM+wTQiNYcaYoWTtSsuMlQBnx+BogfVjbhGJ/1xK6SSuw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 24 Aug 2022 12:02:54 +0000
- Ironport-data: A9a23:0A7CPa6pu5zMXdpL+uU/5AxRtO3GchMFZxGqfqrLsTDasY5as4F+v mFOUDuObPveYzfzeNAjPI+x80gFscKBnII1GVY/pSFhHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yM6jclkf5KkYMbcICd9WAR4fykojBNnioYRj5VhxNO0GGthg /uryyHkEALjimUc3l48sfrZ8ks/5qiq4Vv0g3RlDRx1lA6G/5UqJMp3yZGZdxPQXoRSF+imc OfPpJnRErTxpkpF5nuNy94XQ2VSKlLgFVHmZkl+AsBOtiNqtC0qupvXAdJHAathZ5dlqPgqo DlFncTYpQ7EpcQgksxFO/VTO3kW0aGrZNYriJVw2CCe5xSuTpfi/xlhJG9uJLMp5bhwOl5tz 8EBEmtUMDashf3jldpXSsE07igiBO/CGdtF/1tGlHTeB/tgRo3fSaLX49MexC03ms1FAffZY YwedCZraxPDJRZIPz/7CrpnxLvu2ia5LmQe9A/9SakfugA/yCRY1rT3PcWTUduNXchPxW6Tp 37c/nS/CRYfXDCa4WXVqiv32LSe9c/9cLsjMqXo6/Jyu1C0/WFCWQEfZwK2hPbs3yZSXPoac ST44BEGr6I/6UiqRdnVRACjrTiPuRt0c8VUO/037keK0KW8ywOQHG0NVDNCQN0gqs4tRDYu2 0OJntXmHjhmuvueTnf13qubqSOaPSkTMHMYYikFXU0J7rHLsIw1yx7CUNtnOKq0lcHuXyH9x SiQqyozjKlVitQEv5hX5njCijOo45LPFwg8412IWnr/tl8kIom4e4av9F7Xq+5aK5qURUWAu 35CnNWC6OcJDteGkynlrPgxIYxFLs2taFX06WOD1bF4n9hx0xZPpbxt3Qw=
- Ironport-hdrordr: A9a23:Qcp8v6FrwgcR4gGwpLqFS5HXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5Vp2RvnhNNICPoqTM2ftW7dySeVxeBZnMHfKljbdxEWmdQtsp uIH5IeNDS0NykDsS+Y2nj2Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf +hD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnY4j4uFxd0hZsy+2 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlUFtyssHfqWG1SYczGgNkHmpDq1L/sqq iKn/4UBbUw15oWRBDynfKi4Xi47N9k0Q6e9bbRuwqenSW+fkN1NyMJv/MmTvOSgXBQw+1Uwe ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRjxkC3fLFuH4O5l7Zvin99AdMFBmb3+YonGO 5hAIXV4+tXa0qTazTcsnN0yNKhU3wvFlPeK3Jy8fC9wnxThjR03kEYzMsQkjMJ8488UYBN46 DBPr5znL9DQ8cKZeZ2BfsHQ8GwFmvRKCi8eF66MBDiDuUKKnjNo5n47PE84/yrYoUByN8olJ HIQDpjxBoPkoLVeLizNbFwg2DwqT+GLEXQI+lllutEk6y5Qqb3OiueT11rm9e8opwkc7/mZ8 o=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYtrt8/1v0WOY/4kiCtfQ8qrAcS628L8cAgAAH3wCAABa0AIAAFEkAgAGSoQA=
- Thread-topic: [PATCH] x86/CPUID: surface suitable value in EBX of XSTATE subleaf 1
On 23/08/2022 13:01, Jan Beulich wrote:
> On 23.08.2022 12:48, Andrew Cooper wrote:
>> On 23/08/2022 10:27, Jan Beulich wrote:
>>> On 23.08.2022 10:59, Andrew Cooper wrote:
>>>> On 23/08/2022 07:42, Jan Beulich wrote:
>>>>> +++ b/xen/arch/x86/cpuid.c
>>>>> @@ -1142,7 +1142,7 @@ void guest_cpuid(const struct vcpu *v, u
>>>>> switch ( subleaf )
>>>>> {
>>>>> case 1:
>>>>> - if ( p->xstate.xsaves )
>>>>> + if ( p->xstate.xsavec || p->xstate.xsaves )
>>>> If we're doing this, then it wants to be xsavec only, with the comment
>>>> being extended to explain why.
>>> Why would that be? Both insns use compacted format, and neither is
>>> dependent upon the other in terms of being supported. IOW XSAVES alone
>>> and XSAVEC alone enabled for a domain should still lead through this
>>> path.
>> Hmm. Because my fixes to compaction handling haven't been committed
>> yet, and in particular one the one which makes XSAVES strictly depend on
>> XSAVEC.
>>
>> In which case this hunk is correct for Xen as it currently is, and will
>> be need to be adjusted when I rebase the compaction series.
> May I translate this to an Ack then? Iirc there were no other change
> requests.
I was hoping that Marek would have time to test it too, seeing as he
reported the bug first. But seeing as he's busy...
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> (with the typo in
the commit message fixed.)
~Andrew
|
